[GitHub] [beam] scwhittle commented on a change in pull request #17162: [BEAM-14157] Don't request work on a closed windmill GetWorkStream

[GitBox <gi...@apache.org>]

scwhittle commented on a change in pull request #17162:
URL: https://github.com/apache/beam/pull/17162#discussion_r832974995



##########
File path: runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/GrpcWindmillServer.java
##########
@@ -936,7 +936,11 @@ protected void onResponse(StreamingGetWorkResponseChunk chunk) {
               .execute(
                   () -> {
                     try {
-                      send(extension);
+                      synchronized (this) {
+                        if (!clientClosed.get()) {

Review comment:
       Should send itself be changed to check this?
   
   Most sends are wrapped with
    catch (IllegalStateException) 
   but then ignore the exception or just log.
   
   Was this causing issues other than unnecessary IllegalStateExceptions?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org