You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/04/29 01:21:10 UTC
Review Request: Fixed post-reviews to submit branch name.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10819/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Ben Mahler.
Description
-------
See summary.
Diffs
-----
support/post-reviews.py 97a1e783d8a8765bd46a9aa3a0cbba61b5212826
Diff: https://reviews.apache.org/r/10819/diff/
Testing
-------
See "Branch:" above
Thanks,
Vinod Kone
Re: Review Request: Fixed post-reviews to submit branch name.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10819/#review19832
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On April 28, 2013, 11:21 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10819/
> -----------------------------------------------------------
>
> (Updated April 28, 2013, 11:21 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> support/post-reviews.py 97a1e783d8a8765bd46a9aa3a0cbba61b5212826
>
> Diff: https://reviews.apache.org/r/10819/diff/
>
>
> Testing
> -------
>
> See "Branch:" above
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Fixed post-reviews to submit branch name.
Posted by Vinod Kone <vi...@gmail.com>.
> On April 29, 2013, 3:55 a.m., Benjamin Hindman wrote:
> > What was the motivation behind this?
When working on multiple different features at a time, I tend to forget which branch name corresponds to which review. I end up doing "git branch -a | grep <magic phrase>" to figure out the branch (or worse do a git grep <commit message> and figure out the branch that contains the commit). This change helps me (others?) avoid that.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10819/#review19838
-----------------------------------------------------------
On April 28, 2013, 11:21 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10819/
> -----------------------------------------------------------
>
> (Updated April 28, 2013, 11:21 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> support/post-reviews.py 97a1e783d8a8765bd46a9aa3a0cbba61b5212826
>
> Diff: https://reviews.apache.org/r/10819/diff/
>
>
> Testing
> -------
>
> See "Branch:" above
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Fixed post-reviews to submit branch name.
Posted by Vinod Kone <vi...@gmail.com>.
> On April 29, 2013, 3:55 a.m., Benjamin Hindman wrote:
> > What was the motivation behind this?
>
> Vinod Kone wrote:
> When working on multiple different features at a time, I tend to forget which branch name corresponds to which review. I end up doing "git branch -a | grep <magic phrase>" to figure out the branch (or worse do a git grep <commit message> and figure out the branch that contains the commit). This change helps me (others?) avoid that.
>
> Benjamin Hindman wrote:
> I see ... the concern I have here is that this branch is not actually accessible to anyone else, so while the naming might help you it might also cause someone to look for this branch in one of our public repositories and never find it.
Fair enough. Dropping this in favor of a git alias.
If interested, this is how it looks in my gitconfig:
[alias]
rb = !sh -c 'git log --all --grep=$1 --oneline | cut -d\" \" -f1 | xargs git branch --contains' -
Usage:
➜ git rb 10814
* vinod/gc_disk_fix
➜ git rb r/10814
* vinod/gc_disk_fix
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10819/#review19838
-----------------------------------------------------------
On April 28, 2013, 11:21 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10819/
> -----------------------------------------------------------
>
> (Updated April 28, 2013, 11:21 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> support/post-reviews.py 97a1e783d8a8765bd46a9aa3a0cbba61b5212826
>
> Diff: https://reviews.apache.org/r/10819/diff/
>
>
> Testing
> -------
>
> See "Branch:" above
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Fixed post-reviews to submit branch name.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On April 29, 2013, 3:55 a.m., Benjamin Hindman wrote:
> > What was the motivation behind this?
>
> Vinod Kone wrote:
> When working on multiple different features at a time, I tend to forget which branch name corresponds to which review. I end up doing "git branch -a | grep <magic phrase>" to figure out the branch (or worse do a git grep <commit message> and figure out the branch that contains the commit). This change helps me (others?) avoid that.
I see ... the concern I have here is that this branch is not actually accessible to anyone else, so while the naming might help you it might also cause someone to look for this branch in one of our public repositories and never find it.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10819/#review19838
-----------------------------------------------------------
On April 28, 2013, 11:21 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10819/
> -----------------------------------------------------------
>
> (Updated April 28, 2013, 11:21 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> support/post-reviews.py 97a1e783d8a8765bd46a9aa3a0cbba61b5212826
>
> Diff: https://reviews.apache.org/r/10819/diff/
>
>
> Testing
> -------
>
> See "Branch:" above
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Fixed post-reviews to submit branch name.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10819/#review19838
-----------------------------------------------------------
What was the motivation behind this?
- Benjamin Hindman
On April 28, 2013, 11:21 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10819/
> -----------------------------------------------------------
>
> (Updated April 28, 2013, 11:21 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> support/post-reviews.py 97a1e783d8a8765bd46a9aa3a0cbba61b5212826
>
> Diff: https://reviews.apache.org/r/10819/diff/
>
>
> Testing
> -------
>
> See "Branch:" above
>
>
> Thanks,
>
> Vinod Kone
>
>