You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apex.apache.org by davidyan74 <gi...@git.apache.org> on 2016/03/23 01:24:40 UTC
[GitHub] incubator-apex-core pull request: Testing DelayOperator unit test ...
GitHub user davidyan74 opened a pull request:
https://github.com/apache/incubator-apex-core/pull/284
Testing DelayOperator unit test with travis, DO NOT merge
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/davidyan74/incubator-apex-core APEXCORE-403
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-apex-core/pull/284.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #284
----
commit 2f7fef942cafac987c425c1d816045861935ffd8
Author: David Yan <da...@datatorrent.com>
Date: 2016-03-23T00:23:58Z
test unit test
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: Testing DelayOperator unit test ...
Posted by davidyan74 <gi...@git.apache.org>.
GitHub user davidyan74 reopened a pull request:
https://github.com/apache/incubator-apex-core/pull/284
Testing DelayOperator unit test with travis, DO NOT merge
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/davidyan74/incubator-apex-core APEXCORE-403
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-apex-core/pull/284.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #284
----
commit 2f7fef942cafac987c425c1d816045861935ffd8
Author: David Yan <da...@datatorrent.com>
Date: 2016-03-23T00:23:58Z
test unit test
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-403 Fixed unit test
Posted by PramodSSImmaneni <gi...@git.apache.org>.
Github user PramodSSImmaneni commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/284#discussion_r57247928
--- Diff: engine/src/test/java/com/datatorrent/stram/plan/logical/DelayOperatorTest.java ---
@@ -349,6 +352,7 @@ public void testFibonacciRecovery1() throws Exception
@Override
public Boolean call() throws Exception
{
+
--- End diff --
empty line?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-403 Fixed unit test
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-apex-core/pull/284
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-403 Fixed unit test
Posted by davidyan74 <gi...@git.apache.org>.
Github user davidyan74 commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/284#issuecomment-200566464
@PramodSSImmaneni please merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-403 Fixed unit test
Posted by PramodSSImmaneni <gi...@git.apache.org>.
Github user PramodSSImmaneni commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/284#discussion_r57248038
--- Diff: engine/src/test/java/com/datatorrent/stram/plan/logical/DelayOperatorTest.java ---
@@ -473,4 +476,5 @@ public void testValidationWithMultipleStreamLoops()
dag.validate();
}
+ private static final Logger LOG = LoggerFactory.getLogger(DelayOperatorTest.class);
--- End diff --
unused?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: Testing DelayOperator unit test ...
Posted by davidyan74 <gi...@git.apache.org>.
Github user davidyan74 closed the pull request at:
https://github.com/apache/incubator-apex-core/pull/284
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---