[jira] [Commented] (YARN-5208) Run TestAMRMClient TestNMClient TestYarnClient TestClientRMTokens TestAMAuthorization tests with hadoop.security.token.service.use_ip enabled

["Sunil G (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-5208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15320633#comment-15320633 ] 

Sunil G commented on YARN-5208:
-------------------------------

Thanks [~rohithsharma] for the patch and analysis.
Approach looks fine for me. Few points from my end.

- Since this issue will hit for those test cases which connects  through proxy, we can write some clear java doc and comments explaining the reason. For these kinds of tests cases, we must use IP as host resolver.
- In {{TestAMRMClientOnRMRestart#tearDown}}, NULL check for conf is not needed. We can create a new conf object and set it.

Could we trigger jenkins one more time so that we can ensure the test cases are good enough.? 

cc/[~vinodkv], [~vvasudev].

> Run TestAMRMClient TestNMClient TestYarnClient TestClientRMTokens TestAMAuthorization tests with hadoop.security.token.service.use_ip enabled
> ---------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-5208
>                 URL: https://issues.apache.org/jira/browse/YARN-5208
>             Project: Hadoop YARN
>          Issue Type: Test
>          Components: test
>            Reporter: Rohith Sharma K S
>            Assignee: Rohith Sharma K S
>            Priority: Blocker
>              Labels: test
>         Attachments: 0001-YARN-5208.patch, 0002-YARN-5208.patch, 0003-YARN-5208.patch, 0004-YARN-5208.patch
>
>
> All YARN test cases are running with *hadoop.security.token.service.use_ip* disabled. As a result few tests {{TestAMRMClient TestNMClient TestYarnClient TestClientRMTokens TestAMRMTokens}} cases are consistently failing because of unable to resolve hostname(see HADOOP-12687 YARN-4306 YARN-4318)
> I would suggest to run tests with *hadoop.security.token.service.use_ip* enabled by default. And for the HA test cases which require mandatory disabling , change test cases as required by setting 
> {code}
> conf.setBoolean(
>         CommonConfigurationKeys.HADOOP_SECURITY_TOKEN_SERVICE_USE_IP, false);
>     SecurityUtil.setConfiguration(conf);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org