You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/02 15:24:59 UTC
[GitHub] [apisix-dashboard] guoqqqi commented on a change in pull request #1610: feat: improve the config plugin button enable disable status
guoqqqi commented on a change in pull request #1610:
URL: https://github.com/apache/apisix-dashboard/pull/1610#discussion_r606283989
##########
File path: web/src/components/Plugin/PluginPage.tsx
##########
@@ -180,16 +180,17 @@ const PluginPage: React.FC<Props> = ({
key={item.name}
actions={[
<Button
- type={
- initialData[item.name] && !initialData[item.name].disable
- ? 'primary'
- : 'default'
- }
+ type='primary'
+ danger= {initialData[item.name] && !initialData[item.name].disable}
Review comment:
```suggestion
type= {initialData[item.name] && !initialData[item.name].disable ? 'primary' : 'default'}
danger= {initialData[item.name] && !initialData[item.name].disable}
```
##########
File path: web/src/components/Plugin/PluginPage.tsx
##########
@@ -180,16 +180,17 @@ const PluginPage: React.FC<Props> = ({
key={item.name}
actions={[
<Button
- type={
- initialData[item.name] && !initialData[item.name].disable
- ? 'primary'
- : 'default'
- }
+ type='primary'
+ danger= {initialData[item.name] && !initialData[item.name].disable}
Review comment:
I think the button should be displayed as default before enabling, it is better to be primary after enabling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org