[GitHub] [iceberg] kbendick opened a new issue #1291: [ErrorProne] Fix outstanding error prone warnings of type UnusedVariable.

[GitBox <gi...@apache.org>]

kbendick opened a new issue #1291:
URL: https://github.com/apache/iceberg/issues/1291


   There are currently a number of warnings emitted by the error prone linter when building etc.
   
   One of them is `UnusedVariable`. There's only a few of these, and they should likely either be fixed or suppressed (in the case that they're needed for serialization concerns or other reasons).
   
   As with the others, I'm tracking this as a separate issue so that they can be worked on over time, as some will definitely be easier than others (I'm looking at you, ReferenceEquaity!).
   
   This one should be easy to fix. I'll submit a patch in the next few days.
   
   Here's an example of one such warning for reference. I would likely suppress this one, as _eventually_ it feels inevitable that a Logger will be needed, but others might have different opinions.
   
   ```
   The field 'LOG' is never read.
     private static final Logger LOG = LoggerFactory.getLogger(IcebergInputFormat.class);
                                 ^
       (see https://errorprone.info/bugpattern/UnusedVariable)
     Did you mean to remove this line or 'static { LoggerFactory.getLogger(IcebergInputFormat.class); }'?
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org