[GitHub] [pulsar-client-go] zengguan commented on a diff in pull request #1029: [Issue 1027][producer] fix: split sendRequest and make reconnectToBroker and other operate in the same coroutine

["zengguan (via GitHub)" <gi...@apache.org>]

zengguan commented on code in PR #1029:
URL: https://github.com/apache/pulsar-client-go/pull/1029#discussion_r1230394670


##########
pulsar/producer_partition.go:
##########
@@ -150,7 +151,8 @@ func newPartitionProducer(client *client, topic string, options *ProducerOptions
 		log:              logger,
 		options:          options,
 		producerID:       client.rpcClient.NewProducerID(),
-		eventsChan:       make(chan interface{}, maxPendingMessages),
+		dataChan:         make(chan *sendRequest, maxPendingMessages),
+		cmdChan:          make(chan interface{}, 10),
 		connectClosedCh:  make(chan connectionClosed, 10),
 		closeCh:          make(chan struct{}),

Review Comment:
   yes. removed it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org