You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/03/31 04:15:28 UTC
[GitHub] [beam] youngoli opened a new pull request #17224: [rollback][release-2.38.0][BEAM-14116][BEAM-14179] Rolling back PRs causing release-blocking issues.
youngoli opened a new pull request #17224:
URL: https://github.com/apache/beam/pull/17224
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] dpcollins-google commented on pull request #17224: [rollback][release-2.38.0][BEAM-14116] Rollback of #17004: Chunk commit requests dynamically
Posted by GitBox <gi...@apache.org>.
dpcollins-google commented on pull request #17224:
URL: https://github.com/apache/beam/pull/17224#issuecomment-1086289581
@TheNeuralBit it was a flaky failure, so I wasn't able to reproduce it but it replicated like 50/100 runs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] youngoli merged pull request #17224: [rollback][release-2.38.0][BEAM-14116] Rollback of #17004: Chunk commit requests dynamically
Posted by GitBox <gi...@apache.org>.
youngoli merged pull request #17224:
URL: https://github.com/apache/beam/pull/17224
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] youngoli commented on pull request #17224: [rollback][release-2.38.0][BEAM-14116][BEAM-14179] Rolling back PRs causing release-blocking issues.
Posted by GitBox <gi...@apache.org>.
youngoli commented on pull request #17224:
URL: https://github.com/apache/beam/pull/17224#issuecomment-1085298401
Nevermind, I finally understood what people have been trying to explain about #17094 which is that it only reveals a bug that would still be present without it. So rolling back the PR wouldn't fix anything, a cherry-pick is actually necessary.
I'll change this PR to only roll back #17004 and create a new cherry-pick PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] youngoli commented on pull request #17224: [rollback][release-2.38.0][BEAM-14116][BEAM-14179] Rolling back PRs causing release-blocking issues.
Posted by GitBox <gi...@apache.org>.
youngoli commented on pull request #17224:
URL: https://github.com/apache/beam/pull/17224#issuecomment-1086260449
That was @dpcollins-google btw. But at the time he wasn't able to reproduce it and was saying the error we originally got was the false positive (i.e. an error when there wasn't actually a problem).
But like I said, we investigated it offline (Daniel, Luke, and I) and we were able to replicate it after all. So it does look like a rollback on master may be necessary too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #17224: [rollback][release-2.38.0][BEAM-14116][BEAM-14179] Rolling back PRs causing release-blocking issues.
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #17224:
URL: https://github.com/apache/beam/pull/17224#issuecomment-1086171371
@youngoli you said earlier:
> I think the issue with https://github.com/apache/beam/pull/17004 was a false positive (or at least not reproducible)
If it was a false positive do we need to roll it back on the release branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] dpcollins-google commented on pull request #17224: [rollback][release-2.38.0][BEAM-14116][BEAM-14179] Rolling back PRs causing release-blocking issues.
Posted by GitBox <gi...@apache.org>.
dpcollins-google commented on pull request #17224:
URL: https://github.com/apache/beam/pull/17224#issuecomment-1084640430
For #17004: the issue mentioned by @lukecwik was not reproducible, and I think we should import again
For #17094: This revealed an issue somewhere else in the codebase, what is the triggering test? I'll run it and fix that location as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] dpcollins-google commented on pull request #17224: [rollback][release-2.38.0][BEAM-14116][BEAM-14179] Rolling back PRs causing release-blocking issues.
Posted by GitBox <gi...@apache.org>.
dpcollins-google commented on pull request #17224:
URL: https://github.com/apache/beam/pull/17224#issuecomment-1084650173
#17228 fixes the metrics issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] dpcollins-google commented on pull request #17224: [rollback][release-2.38.0][BEAM-14116][BEAM-14179] Rolling back PRs causing release-blocking issues.
Posted by GitBox <gi...@apache.org>.
dpcollins-google commented on pull request #17224:
URL: https://github.com/apache/beam/pull/17224#issuecomment-1084751500
I don't think either of these needs to be rolled back on master or the release branch. I think the issue with https://github.com/apache/beam/pull/17004 was a false positive (or at least not reproducible) and #17094 just revealed an issue that would otherwise have failed later in processing on runnerv2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #17224: [rollback][release-2.38.0][BEAM-14116][BEAM-14179] Rolling back PRs causing release-blocking issues.
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #17224:
URL: https://github.com/apache/beam/pull/17224#issuecomment-1084749248
Shouldn't we roll these back on master and then cherrypick to the release branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] youngoli commented on pull request #17224: [rollback][release-2.38.0][BEAM-14116][BEAM-14179] Rolling back PRs causing release-blocking issues.
Posted by GitBox <gi...@apache.org>.
youngoli commented on pull request #17224:
URL: https://github.com/apache/beam/pull/17224#issuecomment-1084056636
R: @lukecwik @dpcollins-google @TheNeuralBit (whoever gets to it first)
For now I'm rolling these back to give the RC a try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] dpcollins-google commented on pull request #17224: [rollback][release-2.38.0][BEAM-14116][BEAM-14179] Rolling back PRs causing release-blocking issues.
Posted by GitBox <gi...@apache.org>.
dpcollins-google commented on pull request #17224:
URL: https://github.com/apache/beam/pull/17224#issuecomment-1084874186
https://github.com/apache/beam/pull/17228 is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] youngoli commented on pull request #17224: [rollback][release-2.38.0][BEAM-14116][BEAM-14179] Rolling back PRs causing release-blocking issues.
Posted by GitBox <gi...@apache.org>.
youngoli commented on pull request #17224:
URL: https://github.com/apache/beam/pull/17224#issuecomment-1085276118
After some offline investigation, we were able to reproduce the error. As for cherry-picking #17228, I'm going forward with rollback because I'm hesitant to delay any further for a cherry-pick (I already should've started the RC yesterday).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org