You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/11/28 07:28:07 UTC

[GitHub] [netbeans] BradWalker opened a new pull request #2566: [NETBEANS-5074] - cleanup ArrayList warnings..

BradWalker opened a new pull request #2566:
URL: https://github.com/apache/netbeans/pull/2566


   This work cleans up a bunch of warnings surrounding the use of ArrayList..
   
   For example:
   
      [repeat] /home/bwalker/src/netbeans/platform/core.multitabs/src/org/netbeans/core/multitabs/impl/TabLayoutManager.java:245: warning: [unchecked] unchecked conversion
      [repeat]             List<Integer>[] rowIndexes = new ArrayList[rowCount];
      [repeat]                                          ^
      [repeat]   required: List<Integer>[]
      [repeat]   found:    ArrayList[]
   
   ActionsManager.java was especially involved since one change would require another. And keeping track of
   that, so as not to break things, was hard.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] mklaehn commented on a change in pull request #2566: [NETBEANS-5074] - cleanup ArrayList warnings..

Posted by GitBox <gi...@apache.org>.
mklaehn commented on a change in pull request #2566:
URL: https://github.com/apache/netbeans/pull/2566#discussion_r532026010



##########
File path: java/java.sourceui/src/org/netbeans/modules/java/source/ui/OpenProjectFastIndex.java
##########
@@ -550,7 +550,7 @@ private PI getCacheInfo(Project p) {
         private final int         size;
         private final Project     project;
         
-        NameIndex(Project p, FileObject root, String files, ArrayList indices) {
+        NameIndex(Project p, FileObject root, String files, List indices) {

Review comment:
       ```suggestion
           NameIndex(Project p, FileObject root, String files, List<Object[]> indices) {
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] BradWalker commented on a change in pull request #2566: [NETBEANS-5074] - cleanup ArrayList warnings..

Posted by GitBox <gi...@apache.org>.
BradWalker commented on a change in pull request #2566:
URL: https://github.com/apache/netbeans/pull/2566#discussion_r532084529



##########
File path: java/java.sourceui/src/org/netbeans/modules/java/source/ui/OpenProjectFastIndex.java
##########
@@ -550,7 +550,7 @@ private PI getCacheInfo(Project p) {
         private final int         size;
         private final Project     project;
         
-        NameIndex(Project p, FileObject root, String files, ArrayList indices) {
+        NameIndex(Project p, FileObject root, String files, List indices) {

Review comment:
       Hey @mklaehn , thanks for the sharp eyes!
   
   It's been changed and integrated..




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] matthiasblaesing merged pull request #2566: [NETBEANS-5074] - cleanup ArrayList warnings..

Posted by GitBox <gi...@apache.org>.
matthiasblaesing merged pull request #2566:
URL: https://github.com/apache/netbeans/pull/2566


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists