You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/11/17 17:07:00 UTC
[jira] [Commented] (AVRO-2106) Revisit dependencies on Jetty,
servlet-api, and Netty
[ https://issues.apache.org/jira/browse/AVRO-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16257233#comment-16257233 ]
ASF GitHub Bot commented on AVRO-2106:
--------------------------------------
GitHub user dkulp opened a pull request:
https://github.com/apache/avro/pull/259
[AVRO-2106] Start splitting jetty/netty out of avro-ipc
This is not ready to be merged, but wanted to prototype this to start a discussion to see if this is the right track.
Basically, I pulled the jetty/netty stuff out of avro-ipc into implementation specific avro-ipc-jetty and avro-ipc-netty modules. Thus, the stuff remaining in avro-ipc is more "generic" and doesn't rely on either of the implementations.
To avoid the "split package" issue, I had to move them to separate packages. That's an incompatibility, but hopefully not major. However, I updated the Ipc.java to (reflectively) create the appropriate server that it can find. I'm slowly updating the rest of the projects to use Ipc.createServer instead of "new HttpServer" or "new NettyServer" which then allows selection of the impl based on which dependency is found.
Anyway almost all the tests are duplicated in all three modules now (that needs to be cleaned up) and I'm still working on downstream modules to flip to using the Ipc.createServer stuff, but I wanted to start a discussion before going too far with it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dkulp/avro AVRO-2106
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/avro/pull/259.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #259
----
commit 6123bc0242a831af1d8fe878592b6e97eb9c2b39
Author: Daniel Kulp <dk...@apache.org>
Date: 2017-11-17T16:59:25Z
[AVRO-2106] Start splitting jetty/netty out of avro-ipc
----
> Revisit dependencies on Jetty, servlet-api, and Netty
> -----------------------------------------------------
>
> Key: AVRO-2106
> URL: https://issues.apache.org/jira/browse/AVRO-2106
> Project: Avro
> Issue Type: Improvement
> Components: java
> Affects Versions: 1.7.2, 1.8.0
> Reporter: Nandor Kollar
>
> The compile scoped dependency on jetty servlet-api in the IPC pom file can be problematic if using Avro in a webapp environment. Would it be possible to make this dependency either optional or provided? Or maybe Avro modularize into sub-modules in such a way that desired features can be assembled piecemeal?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)