You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/25 22:40:47 UTC
[GitHub] [incubator-superset] zuzana-vej opened a new issue #11070: SQL Lab: Search table name with schema will cause page to crash
zuzana-vej opened a new issue #11070:
URL: https://github.com/apache/incubator-superset/issues/11070
When you paste table name without selection a schema, the SQL Lab page crashes. This has been noticed as a regression - which would have likely been introduced in the last week.
### Expected results
### Actual results
SQL Lab page crashes
#### Screenshots
#### How to reproduce the bug
1. Switch to other schema
2. Switch back to the schema you want
3. in the “See table schema” select box type: “foo” and hit enter
4. Wait and see the page crash
### Environment
Latest master version
### Checklist
Make sure these boxes are checked before submitting your issue - thank you!
- [ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] zuzana-vej commented on issue #11070: SQL Lab: Search table name with schema will cause page to crash
Posted by GitBox <gi...@apache.org>.
zuzana-vej commented on issue #11070:
URL: https://github.com/apache/incubator-superset/issues/11070#issuecomment-701026707
@willbarrett it's possible there was a fix which was merged into master the last 6 days (we are currently 6 days behind). We will check tomorrow and let you know tomorrow if we still see and if yes, more details on how to reproduce it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat edited a comment on issue #11070: SQL Lab: Search table name with schema will cause page to crash
Posted by GitBox <gi...@apache.org>.
graceguo-supercat edited a comment on issue #11070:
URL: https://github.com/apache/incubator-superset/issues/11070#issuecomment-700241378
It's still reproduce-able the latest master branch. after load sql lab, type `abc` in schema input box, then type `abc` in table input box, then you will see sql lab page crashed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] zhaoyongjie edited a comment on issue #11070: SQL Lab: Search table name with schema will cause page to crash
Posted by GitBox <gi...@apache.org>.
zhaoyongjie edited a comment on issue #11070:
URL: https://github.com/apache/incubator-superset/issues/11070#issuecomment-699595597
hi, @zuzana-vej , which version do you use or give me the SHA string, like flowing the image.
<img width="351" alt="image" src="https://user-images.githubusercontent.com/2016594/94358252-4377f800-00d2-11eb-9535-ca96d3ed4784.png">
By the way, the latest master branch. the SQLLab can not select table if you do not choose schema.
<img width="310" alt="image" src="https://user-images.githubusercontent.com/2016594/94358328-c00ad680-00d2-11eb-9bf3-fbf39c5fd1e7.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #11070: SQL Lab: Search table name with schema will cause page to crash
Posted by GitBox <gi...@apache.org>.
issue-label-bot[bot] commented on issue #11070:
URL: https://github.com/apache/incubator-superset/issues/11070#issuecomment-699193872
Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.98. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!
Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] zuzana-vej edited a comment on issue #11070: SQL Lab: Search table name with schema will cause page to crash
Posted by GitBox <gi...@apache.org>.
zuzana-vej edited a comment on issue #11070:
URL: https://github.com/apache/incubator-superset/issues/11070#issuecomment-701026707
@willbarrett it's possible there was a fix which was merged into master the last 6 days (we are currently few days behind). We will check tomorrow and let you know tomorrow if we still see and if yes, more details on how to reproduce it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] zuzana-vej commented on issue #11070: SQL Lab: Search table name with schema will cause page to crash
Posted by GitBox <gi...@apache.org>.
zuzana-vej commented on issue #11070:
URL: https://github.com/apache/incubator-superset/issues/11070#issuecomment-712301265
Agreed, it looks fixed (also couldn't repro it anymore).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on issue #11070: SQL Lab: Search table name with schema will cause page to crash
Posted by GitBox <gi...@apache.org>.
willbarrett commented on issue #11070:
URL: https://github.com/apache/incubator-superset/issues/11070#issuecomment-701022022
@graceguo-supercat @zuzana-vej I'm unable to replicate this - can you share information on browser used and anything else that might help me find the issue? For me, the "table" dropdown is not enabled until I select a valid schema, even when I put a search string into the schema search field.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett closed issue #11070: SQL Lab: Search table name with schema will cause page to crash
Posted by GitBox <gi...@apache.org>.
willbarrett closed issue #11070:
URL: https://github.com/apache/incubator-superset/issues/11070
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] zhaoyongjie commented on issue #11070: SQL Lab: Search table name with schema will cause page to crash
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on issue #11070:
URL: https://github.com/apache/incubator-superset/issues/11070#issuecomment-699595597
hi, @zuzana-vej , which version do you use or give me the SHA string, like flowing the image.
<img width="351" alt="image" src="https://user-images.githubusercontent.com/2016594/94358252-4377f800-00d2-11eb-9535-ca96d3ed4784.png">
by the way, the latest master branch. the SQLLab can not select table if you do not choose schema.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on issue #11070: SQL Lab: Search table name with schema will cause page to crash
Posted by GitBox <gi...@apache.org>.
willbarrett commented on issue #11070:
URL: https://github.com/apache/incubator-superset/issues/11070#issuecomment-712263426
Closing as unable to reproduce.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat commented on issue #11070: SQL Lab: Search table name with schema will cause page to crash
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on issue #11070:
URL: https://github.com/apache/incubator-superset/issues/11070#issuecomment-700241378
It's still reproduce-able the latest master branch. after load sql lab, type `abc` in schema input box, then type `abc` in table input box.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org