[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8883: add parquet support to native batch

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #8883: add parquet support to native batch
URL: https://github.com/apache/incubator-druid/pull/8883#discussion_r347210413
 
 

 ##########
 File path: extensions-core/parquet-extensions/src/main/java/org/apache/druid/data/input/parquet/ParquetExtensionsModule.java
 ##########
 @@ -46,14 +60,42 @@
             .registerSubtypes(
                 new NamedType(ParquetAvroHadoopInputRowParser.class, PARQUET_AVRO_INPUT_PARSER_TYPE),
                 new NamedType(ParquetHadoopInputRowParser.class, PARQUET_SIMPLE_INPUT_PARSER_TYPE),
-                new NamedType(ParquetParseSpec.class, PARQUET_SIMPLE_INPUT_PARSER_TYPE)
+                new NamedType(ParquetParseSpec.class, PARQUET_SIMPLE_INPUT_PARSER_TYPE),
+                new NamedType(DruidNativeParquetInputFormat.class, PARQUET_SIMPLE_PARSE_SPEC_TYPE)
             )
     );
   }
 
   @Override
   public void configure(Binder binder)
   {
+    final Configuration conf = new Configuration();
+
+    // Set explicit CL. Otherwise it'll try to use thread context CL, which may not have all of our dependencies.
 
 Review comment:
   This is copied from the HDFS module to initialize Hadoopy things... Not sure of a good way to share this because it requires Hadoop libraries that core Druid doesn't have... 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org