You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "abhi-ksolves (via GitHub)" <gi...@apache.org> on 2024/07/31 06:31:01 UTC
[PR] KAFKA-16327: Removed Deprecated variable StreamsConfig#TOPOLOGY_OPTIMIZATION [kafka]
abhi-ksolves opened a new pull request, #16744:
URL: https://github.com/apache/kafka/pull/16744
Deprecated Variable StreamsConfig#TOPOLOGY_OPTIMIZATION is removed
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16327: Removed Deprecated variable StreamsConfig#TOPOLOGY_OPTIMIZATION [kafka]
Posted by "abhi-ksolves (via GitHub)" <gi...@apache.org>.
abhi-ksolves commented on PR #16744:
URL: https://github.com/apache/kafka/pull/16744#issuecomment-2315926103
Hi @mjsax these commits come from while doing rebasing itself. I will make new branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16327: Removed Deprecated variable StreamsConfig#TOPOLOGY_OPTIMIZATION [kafka]
Posted by "abhi-ksolves (via GitHub)" <gi...@apache.org>.
abhi-ksolves commented on PR #16744:
URL: https://github.com/apache/kafka/pull/16744#issuecomment-2275016593
> I just checked the full repo, and also found `TOPOLOGY_OPTIMIZATION` mentioned in `docs/streams/upgrade_guide.html` -- I think we should update it there, too.
Yes, Mentioned changes are updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16327: Removed Deprecated variable StreamsConfig#TOPOLOGY_OPTIMIZATION [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on PR #16744:
URL: https://github.com/apache/kafka/pull/16744#issuecomment-2261817050
I just checked the full repo, and also found `TOPOLOGY_OPTIMIZATION` mentioned in `docs/streams/upgrade_guide.html` -- I think we should update it there, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16327: Removed Deprecated variable StreamsConfig#TOPOLOGY_OPTIMIZATION [kafka]
Posted by "abhi-ksolves (via GitHub)" <gi...@apache.org>.
abhi-ksolves commented on PR #16744:
URL: https://github.com/apache/kafka/pull/16744#issuecomment-2316863780
@mjsax Conflicts resolved. Please review again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16327: Removed Deprecated variable StreamsConfig#TOPOLOGY_OPTIMIZATION [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on PR #16744:
URL: https://github.com/apache/kafka/pull/16744#issuecomment-2319593137
Thanks for the PR! Merged to `trunk`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16327: Removed Deprecated variable StreamsConfig#TOPOLOGY_OPTIMIZATION [kafka]
Posted by "abhi-ksolves (via GitHub)" <gi...@apache.org>.
abhi-ksolves commented on PR #16744:
URL: https://github.com/apache/kafka/pull/16744#issuecomment-2277580644
Hi @mjsax,
Could you please review this PR? I attempted to rebase it, but now it contains too many commits. Should I close this PR and create a new one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16327: Removed Deprecated variable StreamsConfig#TOPOLOGY_OPTIMIZATION [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on code in PR #16744:
URL: https://github.com/apache/kafka/pull/16744#discussion_r1699295185
##########
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##########
@@ -846,14 +846,6 @@ public class StreamsConfig extends AbstractConfig {
private static final String LOG_SUMMARY_INTERVAL_MS_DOC = "This configuration controls the output interval for summary information.\n" +
"If greater or equal to 0, the summary log will be output according to the set time interval;\n" +
"If less than 0, summary output is disabled.";
- /**
- * {@code topology.optimization}
- * @deprecated since 2.7; use {@link #TOPOLOGY_OPTIMIZATION_CONFIG} instead
- */
- @Deprecated
- public static final String TOPOLOGY_OPTIMIZATION = TOPOLOGY_OPTIMIZATION_CONFIG;
-
-
Review Comment:
Nit: we should not remove all blank lines, but leave exactly one blank line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16327: Removed Deprecated variable StreamsConfig#TOPOLOGY_OPTIMIZATION [kafka]
Posted by "abhi-ksolves (via GitHub)" <gi...@apache.org>.
abhi-ksolves commented on PR #16744:
URL: https://github.com/apache/kafka/pull/16744#issuecomment-2285929949
Hi @mjsax can you please check & confirm?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16327: Removed Deprecated variable StreamsConfig#TOPOLOGY_OPTIMIZATION [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax merged PR #16744:
URL: https://github.com/apache/kafka/pull/16744
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16327: Removed Deprecated variable StreamsConfig#TOPOLOGY_OPTIMIZATION [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on PR #16744:
URL: https://github.com/apache/kafka/pull/16744#issuecomment-2316524287
Seems there is conflicts. Can you try again to rebase? (Did you create the new branch from latest `trunk`? Wondering why there are still conflicts...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16327: Removed Deprecated variable StreamsConfig#TOPOLOGY_OPTIMIZATION [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on PR #16744:
URL: https://github.com/apache/kafka/pull/16744#issuecomment-2306108112
Not sure what happened to this PR, but it contains 45 commits and thoughts of LOC... Can you please cleanup the PR by rebasing it to latest `trunk` such that it only contains the relevant changes? And we can take it from there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org