Re: Commit failure via out of date proxy - issue #3561 - with Serf

[Kamesh Jayachandran <ka...@collab.net>]

On 01/29/2010 04:18 PM, Kamesh Jayachandran wrote:
> On 01/28/2010 09:08 PM, C. Michael Pilato wrote:
>> Julian Foad wrote:
>>> On Thu, 2010-01-28 at 10:23 -0500, C. Michael Pilato wrote:
>>>> Julian Foad wrote:
>>>>> On Wed, 2010-01-20, Julian Foad wrote:
>>>>>> I have added issue #3561
>>>>>> <http://subversion.tigris.org/issues/show_bug.cgi?id=3561>  to 
>>>>>> track this
>>>>> Just now, using a client built from today's trunk code, I got the 
>>>>> same
>>>>> problem when committing with Serf:
>>>> [...]
>>>>
>>>>> In earlier emails [1] and [2], Kamesh indicated that Serf does not
>>>>> suffer the same problem because it does not issue the PROPFIND, 
>>>>> but that
>>>>> was in the context of Mike asking about HTTPv2, so I am not clear
>>>>> whether that applies to an ordinary build or if I have to do 
>>>>> something
>>>>> special to use HTTPv2.
>>>> You have to have a server that supports HTTPv2.  The ASF server is 
>>>> not such
>>>> a server (because we haven't released Subversion 1.7 yet).
>>> Ah, thanks. So when it's upgraded, that part of the problem will be
>>> solved too. That's good.
>> Right.  Now, that said, it might be prudent to make the same fix in 
>> Serf's
>> non-HTTPv2 codepath that Kamesh made for Neon.  I mean, if there's an 
>> easy
>> client-side fix to be had, seems silly to require a server upgrade 
>> instead.
>>
>> Kamesh, can you look into this?
>>
> Attached patch fixes it, though I need to get better context to the 
> relevant code base to give a 100% confident fix, which I will do it 
> sooner.
>
> With regards
> Kamesh Jayachandran
>
Committed this patch at r905326.

With regards
Kamesh Jayachandran

Re: Commit failure via out of date proxy - issue #3561 - with Serf

[Justin Erenkrantz <ju...@erenkrantz.com>]

On Mon, Feb 1, 2010 at 9:02 AM, Julian Foad <ju...@wandisco.com> wrote:
>> > Committed this patch at r905326.
>>
>> Xlnt.  Thanks, Kamesh.
>
> Ah, my favourite kind of bug fix: *removing* a bunch of code (and adding
> one line instead).

Sweet.  =)  -- justin

Re: Commit failure via out of date proxy - issue #3561 - with Serf

[Julian Foad <ju...@wandisco.com>]

On Mon, 2010-02-01 at 11:40 -0500, C. Michael Pilato wrote:
> Kamesh Jayachandran wrote:
> >>> Right.  Now, that said, it might be prudent to make the same fix in Serf's
> >>> non-HTTPv2 codepath that Kamesh made for Neon.  I mean, if there's an easy
> >>> client-side fix to be had, seems silly to require a server upgrade
> >>> instead.
> >>>
> >>> Kamesh, can you look into this?
> >>>
> >> Attached patch fixes it, though I need to get better context to the
> >> relevant code base to give a 100% confident fix, which I will do it
> >> sooner.
> >>
> >> With regards
> >> Kamesh Jayachandran
> >>
> > Committed this patch at r905326.
> 
> Xlnt.  Thanks, Kamesh.

Ah, my favourite kind of bug fix: *removing* a bunch of code (and adding
one line instead).

Thanks.

- Julian

Re: Commit failure via out of date proxy - issue #3561 - with Serf

["C. Michael Pilato" <cm...@collab.net>]

Kamesh Jayachandran wrote:
>>> Right.  Now, that said, it might be prudent to make the same fix in Serf's
>>> non-HTTPv2 codepath that Kamesh made for Neon.  I mean, if there's an easy
>>> client-side fix to be had, seems silly to require a server upgrade
>>> instead.
>>>
>>> Kamesh, can you look into this?
>>>
>> Attached patch fixes it, though I need to get better context to the
>> relevant code base to give a 100% confident fix, which I will do it
>> sooner.
>>
>> With regards
>> Kamesh Jayachandran
>>
> Committed this patch at r905326.

Xlnt.  Thanks, Kamesh.

-- 
C. Michael Pilato <cm...@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand