You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Loyal-Young (via GitHub)" <gi...@apache.org> on 2026/10/20 08:56:51 UTC
[PR] fix(consumer): scope mock progress to its instance [rocketmq-dashboard]
Loyal-Young opened a new pull request, #7253:
URL: https://github.com/apache/rocketmq-dashboard/pull/7253
## Summary
- Tie Mock progress and subscription fixtures to the original active group record and its instance.
- Use the same ownership check for offset-reset previews, so a same-named group in another instance cannot inherit another group's queues or an enabled reset action.
- Add a same-name, different-instance regression; it failed before the fix with six leaked progress rows.
Fixes #7252.
## Verification
- Before the fix: the new test failed because `getConsumerProgress` returned the original instance's six rows.
- After rebasing onto the current `rocketmq-studio` head, `npm test -- --run src/services/consumerService.test.ts`: 29 passed.
- TypeScript build, changed-file ESLint and Prettier, and `git diff --check` passed.
## AI assistance
I used AI assistance to compare Mock fixture ownership with the instance-scoped group records and draft the regression. I reproduced the cross-instance leak, reviewed the three read paths, and ran the focused tests and static checks locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(consumer): scope mock progress to its instance [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #7253:
URL: https://github.com/apache/rocketmq-dashboard/pull/7253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org