You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/11/24 06:50:10 UTC

[GitHub] [hudi] danny0405 commented on a change in pull request #4065: [HUDI-2817] Sync the configuration inference for HoodieFlinkStreamer

danny0405 commented on a change in pull request #4065:
URL: https://github.com/apache/hudi/pull/4065#discussion_r755743573



##########
File path: hudi-flink/src/main/java/org/apache/hudi/streamer/HoodieFlinkStreamer.java
##########
@@ -97,8 +99,21 @@ public static void main(String[] args) throws Exception {
       }
     }
 
-    DataStream<HoodieRecord> hoodieRecordDataStream = Pipelines.bootstrap(conf, rowType, parallelism, dataStream);
+    // bulk_insert mode and Append mode is same in streaming
+    final String writeOperation = conf.get(FlinkOptions.OPERATION);
+    if (WriteOperationType.fromValue(writeOperation) == WriteOperationType.BULK_INSERT
+        || OptionsResolver.isAppendMode(conf)) {
+      Pipelines.append(conf, rowType, dataStream);
+    }
+

Review comment:
       Do we still need bootstrap for `bulk_insert` and `append` mode ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org