You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by nickwallen <gi...@git.apache.org> on 2018/08/21 20:53:23 UTC

[GitHub] metron pull request #1170: METRON-1741 Move REPL Port of Profiler to Separat...

GitHub user nickwallen opened a pull request:

    https://github.com/apache/metron/pull/1170

    METRON-1741 Move REPL Port of Profiler to Separate Project

    This separates out the Profiler code specific to the port which runs in the Stellar REPL into its own project.  This also creates a separate tarball and RPM for the Profiler in the Stellar REPL.
    
    Since there will soon be 3 ports of the Profiler; Storm, the REPL, and Spark, I want to separate out the code base so that it cleanly delineate which code is used by which port.
    
    This is dependent on the following PRs .  By filtering on the last two commits, this PR can be reviewed before the others are reviewed and merged.
    - [ ] #1163 
    
    ### Testing
    
    1. Spin-up the development environment.
    
    1. Validate the development environment by ensuring alerts are visible within the Alerts UI and that the Metron Service Check in Ambari passes.
    
    1. Launch the REPL and follow the instructions in the Profiler README to [create and execute a profile in the REPL](https://github.com/apache/metron/tree/master/metron-analytics/metron-profiler#creating-profiles).
    
    1. Follow the instructions in the README to[ deploy the same profile in Storm](https://github.com/apache/metron/tree/master/metron-analytics/metron-profiler#deploying-profiles).  Ensure that you can retrieve values from HBase using `PROFILE_GET`.
    
    
    ## Pull Request Checklist
    
    - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
    - [x] Have you included steps or a guide to how the change may be verified and tested manually?
    - [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
    - [x] Have you written or updated unit tests and or integration tests to verify your changes?
    - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nickwallen/metron METRON-1741

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/1170.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1170
    
----
commit 6ce28594659928a8c87c57edddd22e1ab00d798d
Author: Nick Allen <ni...@...>
Date:   2018-07-10T14:08:48Z

    METRON-1703 Make Core Profiler Components Serializable

commit 0051359cbb277881de896526345bb4fce1d5139c
Author: Nick Allen <ni...@...>
Date:   2018-07-10T19:42:19Z

    METRON-1704 Message Timestamp Logic Should be Shared

commit 2413726bdf96221ec775a9c8de524e3ec92148b7
Author: Nick Allen <ni...@...>
Date:   2018-07-27T17:20:15Z

    METRON-1706: HbaseClient.mutate should return the number of mutations

commit 21980ca764b98ddb96c4c8732e0ef7a6c5ea2c56
Author: Nick Allen <ni...@...>
Date:   2018-07-24T18:02:36Z

    METRON-1705 Create ProfilePeriod Using Period ID

commit be15126419a2862864a7acd67349281b086f52cf
Author: Nick Allen <ni...@...>
Date:   2018-07-31T19:26:20Z

    METRON-1707 Port Profiler to Spark

commit c410e412c50f4510f8674cd4fa5d4481f28a4a13
Author: Nick Allen <ni...@...>
Date:   2018-08-09T15:54:41Z

    No need to handle packaging yet. That will come in a future PR

commit f1a8b49f99029e8d801dc62cfa9c2a0827a46cd8
Author: Nick Allen <ni...@...>
Date:   2018-08-13T13:25:56Z

    Renamed execute() to run()

commit 7f585e0afaa76386934f785407eecc5d65175d8c
Author: Nick Allen <ni...@...>
Date:   2018-08-13T14:52:17Z

    Reducing the size of the telemetry for the integration test. No need to have so much data

commit 5d9cf3a34e196712c3d38f476514000faab3092b
Author: Nick Allen <ni...@...>
Date:   2018-08-13T18:39:10Z

    METRON-1708 Run the Batch Profiler in Spark

commit 14bee4f88e526a17c648eaa92681e2d6b891ed22
Author: Nick Allen <ni...@...>
Date:   2018-08-14T14:53:30Z

    No need to change this from what was done in METRON-1707

commit 9a5bf5e02b1580a21df51289385043233c1dcff3
Author: Nick Allen <ni...@...>
Date:   2018-08-14T14:56:52Z

    Revert "No need to change this from what was done in METRON-1707"
    
    This reverts commit 14bee4f88e526a17c648eaa92681e2d6b891ed22.

commit 09cdf975de70f8381cc37e08d918813cc2e7e536
Author: Nick Allen <ni...@...>
Date:   2018-08-14T14:35:55Z

    Refactor BatchProfiler to make it simpler to grok hopefully.

commit 126b78d2a084a714ede5b5c8a7abe62efa05c9fc
Author: Nick Allen <ni...@...>
Date:   2018-08-14T18:35:01Z

    METRON-1714 Create RPM Packaging for the Batch Profiler

commit c7175ee527daf429a7eb1a0fa678b403949cebd6
Author: Nick Allen <ni...@...>
Date:   2018-08-14T19:19:55Z

    Updated 'Provides' clause

commit 0a57f158179d46731ff135233b4623122113893a
Author: Nick Allen <ni...@...>
Date:   2018-08-15T20:05:40Z

    Merge remote-tracking branch 'apache/feature/METRON-1699-create-batch-profiler' into METRON-1714

commit 649093baa101f8ba37a62bca8ba2d7a525dc2c9a
Author: Nick Allen <ni...@...>
Date:   2018-08-16T12:47:58Z

    Merge remote-tracking branch 'apache/feature/METRON-1699-create-batch-profiler' into METRON-1714

commit 9bdba0ae685422729aab998245a4dbb46132cb4f
Author: Nick Allen <ni...@...>
Date:   2018-08-21T20:00:18Z

    METRON-1741 Moved REPL port of the Profiler to its own project

commit 36a4a0653588c1dc9dc9e7686854d512f162d9f2
Author: Nick Allen <ni...@...>
Date:   2018-08-21T20:44:02Z

    METRON-1741 Created separate packaging for Profiler for the Stellar REPL

----


---

[GitHub] metron issue #1170: METRON-1741 Move REPL Port of Profiler to Separate Proje...

Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on the issue:

    https://github.com/apache/metron/pull/1170
  
    Thanks for the review!  This has been merged into the feature branch.


---

[GitHub] metron pull request #1170: METRON-1741 Move REPL Port of Profiler to Separat...

Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen closed the pull request at:

    https://github.com/apache/metron/pull/1170


---

[GitHub] metron issue #1170: METRON-1741 Move REPL Port of Profiler to Separate Proje...

Posted by merrimanr <gi...@git.apache.org>.
Github user merrimanr commented on the issue:

    https://github.com/apache/metron/pull/1170
  
    I ran this up in full dev and went through the testing instructions.  Everything worked great.  +1


---