You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/10 06:32:18 UTC

[GitHub] [shardingsphere] terrymanu opened a new issue, #20810: use recursion to setNextException with chain in classes JDBCBackendTransactionManager and LocalTransactionManager

terrymanu opened a new issue, #20810:
URL: https://github.com/apache/shardingsphere/issues/20810

   Please use recursion to setNextException with chain, not overlap in classes JDBCBackendTransactionManager and LocalTransactionManager.
   
   Just search `// TODO` to find the codes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] strongduanmu commented on issue #20810: use recursion to setNextException with chain in classes JDBCBackendTransactionManager and LocalTransactionManager

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #20810:
URL: https://github.com/apache/shardingsphere/issues/20810#issuecomment-1275436741

   Hi @null-sys , could we finish this issue in 5.2.1?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] null-sys commented on issue #20810: use recursion to setNextException with chain in classes JDBCBackendTransactionManager and LocalTransactionManager

Posted by GitBox <gi...@apache.org>.
null-sys commented on issue #20810:
URL: https://github.com/apache/shardingsphere/issues/20810#issuecomment-1240845042

   Hey @terrymanu , I am interested in resolving this issue. This will be my first contribution here, let me know if this needs to be assigned to me or I can raise a PR for this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] strongduanmu commented on issue #20810: use recursion to setNextException with chain in classes JDBCBackendTransactionManager and LocalTransactionManager

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #20810:
URL: https://github.com/apache/shardingsphere/issues/20810#issuecomment-1277015455

   Since this task is not complete, I will move it to 5.2.2.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] github-actions[bot] commented on issue #20810: use recursion to setNextException with chain in classes JDBCBackendTransactionManager and LocalTransactionManager

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #20810:
URL: https://github.com/apache/shardingsphere/issues/20810#issuecomment-1272348607

   Hello , this issue has not received a reply for several days.
   This issue is supposed to be closed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] TeslaCN commented on issue #20810: use recursion to setNextException with chain in classes JDBCBackendTransactionManager and LocalTransactionManager

Posted by GitBox <gi...@apache.org>.
TeslaCN commented on issue #20810:
URL: https://github.com/apache/shardingsphere/issues/20810#issuecomment-1247685296

   Hi @null-sys 
   Assigned.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] null-sys commented on issue #20810: use recursion to setNextException with chain in classes JDBCBackendTransactionManager and LocalTransactionManager

Posted by GitBox <gi...@apache.org>.
null-sys commented on issue #20810:
URL: https://github.com/apache/shardingsphere/issues/20810#issuecomment-1248027066

   Current implementation adds exceptions in liner chain say e.g. for exception collection { e1, e2, e3 } = e1->e2->e3. 
   I suppose this issue requires implementation such that for exception collection { e1, e2, e3 } = e3->e2->e1
   If I am wrong,  @terrymanu @TeslaCN please help me understand the requirement.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] null-sys commented on issue #20810: use recursion to setNextException with chain in classes JDBCBackendTransactionManager and LocalTransactionManager

Posted by GitBox <gi...@apache.org>.
null-sys commented on issue #20810:
URL: https://github.com/apache/shardingsphere/issues/20810#issuecomment-1275476102

   Hey @strongduanmu development was done and it was approved. I just resolved conflicts. You can check this 
   [PR](https://github.com/apache/shardingsphere/pull/21076) . @terrymanu please have a look and merge


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] github-actions[bot] closed issue #20810: use recursion to setNextException with chain in classes JDBCBackendTransactionManager and LocalTransactionManager

Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed issue #20810: use recursion to setNextException with chain in classes JDBCBackendTransactionManager and LocalTransactionManager
URL: https://github.com/apache/shardingsphere/issues/20810


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] terrymanu closed issue #20810: use recursion to setNextException with chain in classes JDBCBackendTransactionManager and LocalTransactionManager

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu closed issue #20810: use recursion to setNextException with chain in classes JDBCBackendTransactionManager and LocalTransactionManager
URL: https://github.com/apache/shardingsphere/issues/20810


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org