You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "MatrixManAtYrService (via GitHub)" <gi...@apache.org> on 2023/06/30 17:58:45 UTC

[GitHub] [airflow] MatrixManAtYrService opened a new issue, #32291: The `"org.apache.airflow.main-image.commit-sha"` image label is empty

MatrixManAtYrService opened a new issue, #32291:
URL: https://github.com/apache/airflow/issues/32291

   ### Apache Airflow version
   
   2.6.2
   
   ### What happened
   
   Regarding the images that are released on dockerhub, I've noticed that the image label which contains the commit is now an empty string.  It was correctly populated in 2.2.4:
   
   ```
   $ docker buildx imagetools inspect docker.io/apache/airflow:2.2.5 --format '{{ json (index .Image.Config) }}' | gron | grep commit
       json.Labels["org.apache.airflow.main-image.commit-sha"] = "7c3513903462511212df742263a49ec1f729ec0e";
   
   $ docker buildx imagetools inspect docker.io/apache/airflow:2.3.0 --format '{{ json (index .Image "linux/amd64").Config }}' | gron | grep commit
       json.Labels["org.apache.airflow.main-image.commit-sha"] = "";
   ```
   
   ### What you think should happen instead
   
   The `airflow.main-image.commit-sha` label should tell me which git ref goes with the image.
   
   ### How to reproduce
   
   inspect the released image's labels
   
   ### Operating System
   
   any
   
   ### Versions of Apache Airflow Providers
   
   n/a
   
   ### Deployment
   
   Official Apache Airflow Helm Chart
   
   ### Deployment details
   
   _No response_
   
   ### Anything else
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk closed issue #32291: The `"org.apache.airflow.main-image.commit-sha"` image label is empty

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed issue #32291: The `"org.apache.airflow.main-image.commit-sha"` image label is empty
URL: https://github.com/apache/airflow/issues/32291


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on issue #32291: The `"org.apache.airflow.main-image.commit-sha"` image label is empty

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #32291:
URL: https://github.com/apache/airflow/issues/32291#issuecomment-1657191827

   cc: @nathadfield -> I have not realised you self-assigned it, so I fixed it in https://github.com/apache/airflow/pull/32949, sorry - but I think it's good we get it fixed before 2.7.0 :). 
   
   You might take a look what it involved though.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] nathadfield commented on issue #32291: The `"org.apache.airflow.main-image.commit-sha"` image label is empty

Posted by "nathadfield (via GitHub)" <gi...@apache.org>.
nathadfield commented on issue #32291:
URL: https://github.com/apache/airflow/issues/32291#issuecomment-1657197347

   No worries. I've been off for a while so not had time to spend on it. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org