You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Sunny Gleason <no...@github.com> on 2013/06/05 04:29:43 UTC
[jclouds] implementation of DynECT HTTP Redirect service API (#28)
Hi there! I needed support for the DynECT HTTP redirect service for one of
my sites, so I whipped up the code to make that happen in JClouds.
Would this be an interesting code submission for y'all? If so, I'd like to add
tests and make whatever changes/adjustments you think are necessary to
make this suitable for the project. I just figured I'd ask for some advice about
how to write bulletproof test cases in JClouds and what tests I should write so
that they wouldn't be brittle or mess with the existing suite in any way.
Thank you in advance for your kind consideration!
All the best, talk to you soon,
-Sunny
You can merge this Pull Request by running:
git pull https://github.com/sunnygleason/jclouds 7b111d55f09f3b6e209e44d3ad9d21658c867c2e
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/28
-- Commit Summary --
* initial implementation of dynect HTTP Redirect service
-- File Changes --
M providers/dynect/src/main/java/org/jclouds/dynect/v3/DynECTApi.java (7)
A providers/dynect/src/main/java/org/jclouds/dynect/v3/binders/CreateHttpRedirectBinder.java (51)
A providers/dynect/src/main/java/org/jclouds/dynect/v3/binders/HttpRedirectBinder.java (51)
A providers/dynect/src/main/java/org/jclouds/dynect/v3/domain/redirect/HttpRedirect.java (162)
A providers/dynect/src/main/java/org/jclouds/dynect/v3/features/HttpRedirectApi.java (144)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/28.patch
https://github.com/jclouds/jclouds/pull/28.diff
Re: [jclouds] implementation of DynECT HTTP Redirect service API
(#28)
Posted by Sunny Gleason <no...@github.com>.
Closed #28.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/28
Re: [jclouds] implementation of DynECT HTTP Redirect service API
(#28)
Posted by Sunny Gleason <no...@github.com>.
Excellent - thank you so much! I need to close this so I can add another commit... Stay tuned...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/28#issuecomment-19656845
Re: [jclouds] implementation of DynECT HTTP Redirect service API
(#28)
Posted by Adrian Cole <no...@github.com>.
real nice!
here's what to do, Sunny. https://issues.apache.org/jira/browse/JCLOUDS open a corresponding issue and note this pull request. Make a LiveTest and an offine test that can either be MockTest (mockwebserver) or ExpectTest (our own thing).
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/28#issuecomment-18952445