You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by lo...@apache.org on 2010/07/20 15:09:52 UTC

svn commit: r965835 - in /myfaces/tobago/branches/tobago-1.0.x/core/src/main/java/org/apache/myfaces/tobago: context/RenderersConfigImpl.java renderkit/html/StyleClasses.java

Author: lofwyr
Date: Tue Jul 20 13:09:52 2010
New Revision: 965835

URL: http://svn.apache.org/viewvc?rev=965835&view=rev
Log:
better and less logging

Modified:
    myfaces/tobago/branches/tobago-1.0.x/core/src/main/java/org/apache/myfaces/tobago/context/RenderersConfigImpl.java
    myfaces/tobago/branches/tobago-1.0.x/core/src/main/java/org/apache/myfaces/tobago/renderkit/html/StyleClasses.java

Modified: myfaces/tobago/branches/tobago-1.0.x/core/src/main/java/org/apache/myfaces/tobago/context/RenderersConfigImpl.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/branches/tobago-1.0.x/core/src/main/java/org/apache/myfaces/tobago/context/RenderersConfigImpl.java?rev=965835&r1=965834&r2=965835&view=diff
==============================================================================
--- myfaces/tobago/branches/tobago-1.0.x/core/src/main/java/org/apache/myfaces/tobago/context/RenderersConfigImpl.java (original)
+++ myfaces/tobago/branches/tobago-1.0.x/core/src/main/java/org/apache/myfaces/tobago/context/RenderersConfigImpl.java Tue Jul 20 13:09:52 2010
@@ -20,10 +20,10 @@ package org.apache.myfaces.tobago.contex
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
 
-import java.util.Map;
-import java.util.HashMap;
-import java.util.Collection;
 import java.io.Serializable;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.Map;
 
 /*
 * Date: Sep 24, 2006
@@ -62,14 +62,13 @@ public class RenderersConfigImpl impleme
   }
 
   public boolean isMarkupSupported(String rendererName, String markup) {
-    if (LOG.isDebugEnabled()) {
-      LOG.debug("calling isMarkupSupported " + rendererName + " " + markup);
-    }
     RendererConfig rendererConfig = renderer.get(rendererName);
     if (rendererConfig != null) {
       return rendererConfig.contains(markup);
     } else {
-      LOG.error("Calling isMarkupSupported " + rendererName + " " + markup + " but no configuration found.");
+      if (LOG.isDebugEnabled()) {
+        LOG.debug("No config found for renderer '" + rendererName + "'.");
+      }
       return false;
     }
   }

Modified: myfaces/tobago/branches/tobago-1.0.x/core/src/main/java/org/apache/myfaces/tobago/renderkit/html/StyleClasses.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/branches/tobago-1.0.x/core/src/main/java/org/apache/myfaces/tobago/renderkit/html/StyleClasses.java?rev=965835&r1=965834&r2=965835&view=diff
==============================================================================
--- myfaces/tobago/branches/tobago-1.0.x/core/src/main/java/org/apache/myfaces/tobago/renderkit/html/StyleClasses.java (original)
+++ myfaces/tobago/branches/tobago-1.0.x/core/src/main/java/org/apache/myfaces/tobago/renderkit/html/StyleClasses.java Tue Jul 20 13:09:52 2010
@@ -142,7 +142,7 @@ public class StyleClasses implements Ser
         if (theme.getRenderersConfig().isMarkupSupported(rendererName, markup)) {
           addMarkupClass(rendererName, sub, markup);
         } else if (!"none".equals(markup)) {
-          LOG.warn("Unknown markup='" + markup + "'");
+          LOG.warn("Ignoring unknown markup='" + markup + "' for rendererName='" + rendererName + "'");
         }
       }
     }