[GitHub] [spark] dongjoon-hyun commented on a change in pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #34818:
URL: https://github.com/apache/spark/pull/34818#discussion_r763155385



##########
File path: resource-managers/kubernetes/integration-tests/dev/dev-run-integration-tests.sh
##########
@@ -180,4 +190,4 @@ properties+=(
   -Dlog4j.logger.org.apache.spark=DEBUG
 )
 
-$TEST_ROOT_DIR/build/mvn install -f $TEST_ROOT_DIR/pom.xml -pl resource-managers/kubernetes/integration-tests $BUILD_DEPENDENCIES_MVN_FLAG -Pscala-$SCALA_VERSION -P$HADOOP_PROFILE -Pkubernetes -Pkubernetes-integration-tests ${properties[@]}
+(cd $TEST_ROOT_DIR; ./build/mvn install -pl resource-managers/kubernetes/integration-tests $BUILD_DEPENDENCIES_MVN_FLAG -Pscala-$SCALA_VERSION -P$HADOOP_PROFILE -Pkubernetes -Pkubernetes-integration-tests ${properties[@]})

Review comment:
       Does this work? I'm testing your PR and hit the following.
   ```
   $ cd resource-managers/kubernetes/integration-tests
   $ ./dev/dev-run-integration-tests.sh --docker-file ../docker/src/main/dockerfiles/spark/Dockerfile.java17
   ++ git rev-parse --show-toplevel
   + TEST_ROOT_DIR=/Users/dongjoon/APACHE/spark-merge
   + DEPLOY_MODE=minikube
   + IMAGE_REPO=docker.io/kubespark
   + SPARK_TGZ=N/A
   + IMAGE_TAG=N/A
   + JAVA_IMAGE_TAG=
   + BASE_IMAGE_NAME=
   + JVM_IMAGE_NAME=
   + PYTHON_IMAGE_NAME=
   + R_IMAGE_NAME=
   + DOCKER_FILE=
   + SPARK_MASTER=
   + NAMESPACE=
   + SERVICE_ACCOUNT=
   + CONTEXT=
   + INCLUDE_TAGS=k8s
   + EXCLUDE_TAGS=
   + JAVA_VERSION=8
   + BUILD_DEPENDENCIES_MVN_FLAG=-am
   + HADOOP_PROFILE=hadoop-3.2
   + MVN=/Users/dongjoon/APACHE/spark-merge/build/mvn
   ++ /Users/dongjoon/APACHE/spark-merge/build/mvn help:evaluate -Dexpression=scala.binary.version
   ++ grep -v INFO
   ++ grep -v WARNING
   ++ tail -n 1
   + SCALA_VERSION=2.12
   + export SCALA_VERSION
   + echo 2.12
   2.12
   + ((  2  ))
   + case $1 in
   + DOCKER_FILE=../docker/src/main/dockerfiles/spark/Dockerfile.java17
   + shift
   + shift
   + ((  0  ))
   + properties=(-Djava.version=$JAVA_VERSION -Dspark.kubernetes.test.sparkTgz=$SPARK_TGZ -Dspark.kubernetes.test.imageTag=$IMAGE_TAG -Dspark.kubernetes.test.imageRepo=$IMAGE_REPO -Dspark.kubernetes.test.deployMode=$DEPLOY_MODE -Dtest.include.tags=$INCLUDE_TAGS)
   + '[' -n '' ']'
   + '[' -n ../docker/src/main/dockerfiles/spark/Dockerfile.java17 ']'
   + properties=(${properties[@]} -Dspark.kubernetes.test.dockerFile=$(realpath $DOCKER_FILE))
   ++ realpath ../docker/src/main/dockerfiles/spark/Dockerfile.java17
   ./dev/dev-run-integration-tests.sh: line 153: realpath: command not found
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org