You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/11/22 13:29:27 UTC
[GitHub] [cloudstack] shwstppr opened a new pull request, #6916: server: fix domain shared public template check
shwstppr opened a new pull request, #6916:
URL: https://github.com/apache/cloudstack/pull/6916
### Description
Fixes #6885
Fixes the incorrect inverted check.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
Using API with two accounts in two different domains,
```
(local) π· > list domains filter=id,name,path,
{
"count": 3,
"domain": [
{
"id": "02c03550-6a40-11ed-adb6-645d8651f45a",
"name": "ROOT",
"path": "ROOT"
},
{
"id": "a6df78e8-d16f-4b75-b2a9-e7e21bf1458b",
"name": "d1",
"path": "ROOT/d1"
},
{
"id": "9d7e43a1-4055-4de7-886f-bcf7b75a6509",
"name": "d2",
"path": "ROOT/d2"
}
]
}
(local) π > list accounts id=c39c1bed-77a2-40e2-9574-3cc0099152d4 filter=id,name,roletype,domainid,domainpath,
{
"account": [
{
"domainid": "a6df78e8-d16f-4b75-b2a9-e7e21bf1458b",
"domainpath": "ROOT/d1",
"id": "c39c1bed-77a2-40e2-9574-3cc0099152d4",
"name": "d1user",
"roletype": "User"
}
],
"count": 1
}
(local) π > list accounts id=515fb210-1cdd-4545-afec-326c98d0a37e filter=id,name,roletype,domainid,domainpath,
{
"account": [
{
"domainid": "9d7e43a1-4055-4de7-886f-bcf7b75a6509",
"domainpath": "ROOT/d2",
"id": "515fb210-1cdd-4545-afec-326c98d0a37e",
"name": "d2user",
"roletype": "User"
}
],
"count": 1
}
(local) π¦ > list templates id=db68e383-c25d-4fe7-bbf6-aa5a03566e80 filter=id,name,accountid,account,domain,domainid templatefilter=all
{
"count": 1,
"template": [
{
"account": "d1user",
"domain": "d1",
"domainid": "a6df78e8-d16f-4b75-b2a9-e7e21bf1458b",
"id": "db68e383-c25d-4fe7-bbf6-aa5a03566e80",
"name": "publicma"
}
]
}
(local) π > list configurations domainid=a6df78e8-d16f-4b75-b2a9-e7e21bf1458b name=share.public.templates.with.other.domains
{
"configuration": [
{
"category": "Advanced",
"description": "If false, templates of this domain will not show up in the list templates of other domains.",
"isdynamic": true,
"name": "share.public.templates.with.other.domains",
"scope": "domain",
"value": "true"
}
],
"count": 1
}
(local) π > set username d2user
(local) π > set domain d2
(local) π£ > sync
Discovered 294 APIs
(local) π > list templates id=db68e383-c25d-4fe7-bbf6-aa5a03566e80 templatefilter=community
{
"count": 1,
"template": [
{
"account": "d1user",
"bits": 0,
"created": "2022-11-22T18:34:04+0530",
"crossZones": false,
"deployasis": false,
"details": {},
"directdownload": false,
"displaytext": "publicma",
"domain": "d1",
"domainid": "a6df78e8-d16f-4b75-b2a9-e7e21bf1458b",
"downloaddetails": [
{
"datastore": "nfs://10.147.28.6:/export/home/sandbox/secondary",
"downloadPercent": "100",
"downloadState": "DOWNLOADED"
}
],
"format": "VHD",
"hasannotations": false,
"hypervisor": "Simulator",
"id": "db68e383-c25d-4fe7-bbf6-aa5a03566e80",
"isdynamicallyscalable": false,
"isextractable": false,
"isfeatured": false,
"ispublic": true,
"isready": true,
"name": "publicma",
"ostypeid": "02af909e-6a40-11ed-adb6-645d8651f45a",
"ostypename": "Other Linux (64-bit)",
"passwordenabled": false,
"physicalsize": 5242880,
"requireshvm": true,
"size": 5242880,
"sshkeyenabled": false,
"tags": [],
"templatetype": "USER",
"zoneid": "7044a830-22e1-4671-8c61-0389b5e036ea",
"zonename": "Sandbox-simulator"
}
]
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6916: server: fix domain shared public template check
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6916:
URL: https://github.com/apache/cloudstack/pull/6916#issuecomment-1325186380
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4631
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6916: server: fix domain shared public template check
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6916:
URL: https://github.com/apache/cloudstack/pull/6916#issuecomment-1326371103
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #6916: server: fix domain shared public template check
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #6916:
URL: https://github.com/apache/cloudstack/pull/6916#issuecomment-1323835983
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6916?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6916](https://codecov.io/gh/apache/cloudstack/pull/6916?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (02bba6a) into [4.17](https://codecov.io/gh/apache/cloudstack/commit/296035d9a57caa62260a666da726ec45b6801c4b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (296035d) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## 4.17 #6916 +/- ##
============================================
- Coverage 10.34% 10.34% -0.01%
- Complexity 6610 6611 +1
============================================
Files 2451 2451
Lines 242340 242340
Branches 37924 37924
============================================
- Hits 25070 25065 -5
- Misses 214182 214187 +5
Partials 3088 3088
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/6916?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [...ver/src/main/java/com/cloud/acl/DomainChecker.java](https://codecov.io/gh/apache/cloudstack/pull/6916/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2FjbC9Eb21haW5DaGVja2VyLmphdmE=) | `0.42% <0.00%> (ΓΈ)` | |
| [...rg/apache/cloudstack/quota/QuotaStatementImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6916/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZnJhbWV3b3JrL3F1b3RhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3F1b3RhL1F1b3RhU3RhdGVtZW50SW1wbC5qYXZh) | `36.28% <0.00%> (-3.99%)` | :arrow_down: |
| [...dstack/network/contrail/model/ModelObjectBase.java](https://codecov.io/gh/apache/cloudstack/pull/6916/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9uZXR3b3JrLWVsZW1lbnRzL2p1bmlwZXItY29udHJhaWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svbmV0d29yay9jb250cmFpbC9tb2RlbC9Nb2RlbE9iamVjdEJhc2UuamF2YQ==) | `28.84% <0.00%> (+7.69%)` | :arrow_up: |
:mega: Weβre building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6916: server: fix domain shared public template check
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6916:
URL: https://github.com/apache/cloudstack/pull/6916#issuecomment-1326908383
<b>Trillian test result (tid-5258)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42174 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6916-t5258-kvm-centos7.zip
Smoke tests completed. 99 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 642.60 | test_kubernetes_clusters.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 456.11 | test_vpc_redundant.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6916: server: fix domain shared public template check
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6916:
URL: https://github.com/apache/cloudstack/pull/6916#issuecomment-1326371640
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6916: server: fix domain shared public template check
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6916:
URL: https://github.com/apache/cloudstack/pull/6916#issuecomment-1325214738
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud merged pull request #6916: server: fix domain shared public template check
Posted by GitBox <gi...@apache.org>.
rohityadavcloud merged PR #6916:
URL: https://github.com/apache/cloudstack/pull/6916
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6916: server: fix domain shared public template check
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6916:
URL: https://github.com/apache/cloudstack/pull/6916#issuecomment-1323682013
@soreana can you please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6916: server: fix domain shared public template check
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6916:
URL: https://github.com/apache/cloudstack/pull/6916#issuecomment-1323755702
Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6916)
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6916&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6916&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6916&resolved=false&types=BUG)
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6916&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6916&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6916&resolved=false&types=VULNERABILITY)
[![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6916&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6916&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6916&resolved=false&types=SECURITY_HOTSPOT)
[![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6916&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6916&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6916&resolved=false&types=CODE_SMELL)
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6916&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6916&metric=new_coverage&view=list)
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6916&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6916&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6916: server: fix domain shared public template check
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6916:
URL: https://github.com/apache/cloudstack/pull/6916#issuecomment-1325216062
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6916: server: fix domain shared public template check
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6916:
URL: https://github.com/apache/cloudstack/pull/6916#issuecomment-1325077836
@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6916: server: fix domain shared public template check
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6916:
URL: https://github.com/apache/cloudstack/pull/6916#issuecomment-1325077247
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org