[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #1266: [NETBEANS-2172] & [NETBEANS-2398] Fix for web.xml errors

[GitBox <gi...@apache.org>]

matthiasblaesing commented on a change in pull request #1266: [NETBEANS-2172] & [NETBEANS-2398] Fix for web.xml errors
URL: https://github.com/apache/netbeans/pull/1266#discussion_r289648195
 
 

 ##########
 File path: enterprise/j2ee.dd/licenseinfo.xml
 ##########
 @@ -24,6 +24,9 @@
 <licenseinfo>
     <fileset>
         <file>doc/dd_api_schema.jpg</file>
+        <file>src/org/netbeans/modules/j2ee/dd/impl/resources/batchXML_1_0.xsd</file>
+        <file>src/org/netbeans/modules/j2ee/dd/impl/resources/beans_1_0.xsd</file>
+        <file>src/org/netbeans/modules/j2ee/dd/impl/resources/beans_1_1.xsd</file>
         <license ref="Apache-2.0-ASF" />
 
 Review comment:
   This needs to be separated. `Apache-2.0-ASF` is used for files, that are copyrighted by the ASF. This is not the case for the new files. These files are ALv2 licensed, but not donated to the ASF, so `Apache-2.0` would apply. Please introduce a separated section for them.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists