[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3546: [FIX] Rethrow takeVMSnapshot() exception

[GitBox <gi...@apache.org>]

DaanHoogland commented on a change in pull request #3546: [FIX] Rethrow takeVMSnapshot() exception
URL: https://github.com/apache/cloudstack/pull/3546#discussion_r312396732
 
 

 ##########
 File path: server/src/main/java/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java
 ##########
 @@ -515,7 +515,7 @@ private VMSnapshot orchestrateCreateVMSnapshot(Long vmId, Long vmSnapshotId, Boo
             return snapshot;
         } catch (Exception e) {
             s_logger.debug("Failed to create vm snapshot: " + vmSnapshotId, e);
-            return null;
+            throw new CloudRuntimeException("Failed to create vm snapshot: " + vmSnapshotId, e);
 
 Review comment:
   I think setting the snapshot to a good state should happen here. not sure what it would be, but probably 'Error'.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services