You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/10/08 06:31:32 UTC

[GitHub] [iceberg] nastra opened a new issue #3246: Add table property to disable snapshot expiration

nastra opened a new issue #3246:
URL: https://github.com/apache/iceberg/issues/3246


   For tables tracked by the NessieCatalog it makes sense to always disable snapshot expiration and let Nessie itself take care of when to expire snapshots, thus a new property `history.expire.enabled` is required


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] RussellSpitzer edited a comment on issue #3246: Add table property to disable snapshot expiration

Posted by GitBox <gi...@apache.org>.
RussellSpitzer edited a comment on issue #3246:
URL: https://github.com/apache/iceberg/issues/3246#issuecomment-939596631


   Don't we also have a GC_ENABLED flag to prevent expire snapshots? I remember this was added so that a table which was created from a snapshot cannot be expired from.
   
   https://github.com/apache/iceberg/blob/90225d6c9413016d611e2ce5eff37db1bc1b4fc5/core/src/main/java/org/apache/iceberg/RemoveSnapshots.java#L100-L102


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] rdblue commented on issue #3246: Add table property to disable snapshot expiration

Posted by GitBox <gi...@apache.org>.
rdblue commented on issue #3246:
URL: https://github.com/apache/iceberg/issues/3246#issuecomment-978119415


   I'm closing this because `GC_ENABLED` already implements what we want.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] jackye1995 commented on issue #3246: Add table property to disable snapshot expiration

Posted by GitBox <gi...@apache.org>.
jackye1995 commented on issue #3246:
URL: https://github.com/apache/iceberg/issues/3246#issuecomment-939582731


   why not just set `history.expire.max-snapshot-age-ms` to `Long.MAX_VALUE`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] RussellSpitzer commented on issue #3246: Add table property to disable snapshot expiration

Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on issue #3246:
URL: https://github.com/apache/iceberg/issues/3246#issuecomment-939596631


   Don't we also have a GC_ENABLED flag to prevent expire snapshots?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] nastra commented on issue #3246: Add table property to disable snapshot expiration

Posted by GitBox <gi...@apache.org>.
nastra commented on issue #3246:
URL: https://github.com/apache/iceberg/issues/3246#issuecomment-945942719


   Using the `GC_ENABLED` flag makes probably sense.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] RussellSpitzer edited a comment on issue #3246: Add table property to disable snapshot expiration

Posted by GitBox <gi...@apache.org>.
RussellSpitzer edited a comment on issue #3246:
URL: https://github.com/apache/iceberg/issues/3246#issuecomment-939596631


   Don't we also have a GC_ENABLED flag to prevent expire snapshots? I remember this was added so that a table which was created from a snapshot cannot be expired from.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] rdblue closed issue #3246: Add table property to disable snapshot expiration

Posted by GitBox <gi...@apache.org>.
rdblue closed issue #3246:
URL: https://github.com/apache/iceberg/issues/3246


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org