You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/03 21:00:13 UTC
[GitHub] [incubator-superset] kgabryje opened a new pull request #11854: feat: Results table on Explore view
kgabryje opened a new pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854
### SUMMARY
This PR implements feature described in https://github.com/apache-superset/superset-roadmap/issues/61.
The goal was to move `View results` and `View samples` tables from `DisplayQueryButton` to main Explore view. Tables are placed in tabs, in a collapsible section.
The whole chart/table area is resizable, with tables section initially collapsed and with minimal height to show as much of the chart as possible. After "uncollapsing" it automatically resizes to 40% if container height, leaving 60% for the chart. The heights can be further adjusted with split handle. After collapsing, it shrinks back to its original height.
The implemented UI is a bit different compared to the one linked in the issue - changes were discussed with @junlincc and @rusackas.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
### TEST PLAN
1. Manually test the feature on various charts.
2. TODO: Write comprehensive E2E tests for the feature
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: https://github.com/apache-superset/superset-roadmap/issues/61
- [x] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [x] Introduces new feature or API
- [ ] Removes existing feature or API
CC: @junlincc @rusackas @villebro
@adam-stasiak @agatapst Could you please help with manual testing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (62bd8f4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `4.31%`.
> The diff coverage is `22.02%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
- Coverage 67.59% 63.28% -4.32%
==========================================
Files 928 934 +6
Lines 45053 45321 +268
Branches 4309 4345 +36
==========================================
- Hits 30455 28680 -1775
- Misses 14495 16464 +1969
- Partials 103 177 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.82% <22.02%> (-0.36%)` | :arrow_down: |
| python | `63.55% <ø> (-0.53%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `10.90% <ø> (-47.28%)` | :arrow_down: |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `13.63% <10.16%> (-61.37%)` | :arrow_down: |
| [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `22.85% <22.85%> (ø)` | |
| [...ontend/src/explore/components/DataTableControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVDb250cm9sLnRzeA==) | `37.83% <37.83%> (ø)` | |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `47.05% <50.00%> (-21.09%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [209 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...585844f](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-736128667
addressing below issues:
- Run query button absolute position
- collapsible `DATA` section that includes `View Results` and `View Samples`
- minimum height for chart area 300px
- include Search, Copy, and # of retrieved row in the data section
- minor cosmetic issues
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#discussion_r534678724
##########
File path: superset-frontend/src/explore/components/DataTableControl.jsx
##########
@@ -0,0 +1,91 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useMemo } from 'react';
+import { styled, t } from '@superset-ui/core';
+import { FormControl } from 'react-bootstrap';
+import Button from '../../components/Button';
+import RowCountLabel from './RowCountLabel';
+import {
+ applyFormattingToTabularData,
+ prepareCopyToClipboardTabularData,
+} from '../../utils/common';
+import CopyToClipboard from '../../components/CopyToClipboard';
+
+const CopyButton = styled(Button)`
+ padding: ${({ theme }) => theme.gridUnit / 2}px
Review comment:
Ideally we wouldn't divide. The gridUnit might become 5px one day, in which case we'd get into fractional-pixel-land, which will cause weird issues. The line below with `gridUnit * 2.5` would exhibit the same issues. How bad does this look with 1 gridunit on the top/bottom, 2 gridUnits on the sides?
Alternatively, the Button supports a `buttonSize` prop, and `xs` or `s` values might look alright without overriding the padding at all
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on a change in pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#discussion_r535009547
##########
File path: superset-frontend/src/explore/components/DataTableControl.jsx
##########
@@ -0,0 +1,91 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useMemo } from 'react';
+import { styled, t } from '@superset-ui/core';
+import { FormControl } from 'react-bootstrap';
+import Button from '../../components/Button';
+import RowCountLabel from './RowCountLabel';
+import {
+ applyFormattingToTabularData,
+ prepareCopyToClipboardTabularData,
+} from '../../utils/common';
+import CopyToClipboard from '../../components/CopyToClipboard';
+
+const CopyButton = styled(Button)`
+ padding: ${({ theme }) => theme.gridUnit / 2}px
Review comment:
Done. That's how it looks with `buttonSize="xs"` and 4px padding on icon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (127b259) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `4.03%`.
> The diff coverage is `25.65%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
- Coverage 67.59% 63.56% -4.04%
==========================================
Files 928 930 +2
Lines 45053 45157 +104
Branches 4309 4319 +10
==========================================
- Hits 30455 28702 -1753
- Misses 14495 16278 +1783
- Partials 103 177 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.91% <25.65%> (-0.27%)` | :arrow_down: |
| python | `63.94% <ø> (-0.14%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `10.90% <ø> (-47.28%)` | :arrow_down: |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `17.54% <14.00%> (-57.46%)` | :arrow_down: |
| [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `26.47% <26.47%> (ø)` | |
| [...ontend/src/explore/components/DataTableControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVDb250cm9sLnRzeA==) | `40.62% <40.62%> (ø)` | |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `47.05% <50.00%> (-21.09%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [183 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...c897e74](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#discussion_r534687553
##########
File path: superset-frontend/src/explore/components/ExploreChartPanel.jsx
##########
@@ -73,67 +178,89 @@ class ExploreChartPanel extends React.PureComponent {
height > 0 && (
<ChartContainer
width={Math.floor(width)}
- height={parseInt(this.props.height, 10) - headerHeight}
+ height={chartSectionHeight}
annotationData={chart.annotationData}
chartAlert={chart.chartAlert}
chartStackTrace={chart.chartStackTrace}
chartId={chart.id}
chartStatus={chart.chartStatus}
- triggerRender={this.props.triggerRender}
- datasource={this.props.datasource}
- errorMessage={this.props.errorMessage}
- formData={this.props.form_data}
- onQuery={this.props.onQuery}
- owners={this.props?.slice?.owners}
+ triggerRender={props.triggerRender}
+ datasource={props.datasource}
+ errorMessage={props.errorMessage}
+ formData={props.form_data}
+ onQuery={props.onQuery}
+ owners={props?.slice?.owners}
queryResponse={chart.queryResponse}
- refreshOverlayVisible={this.props.refreshOverlayVisible}
- setControlValue={this.props.actions.setControlValue}
- timeout={this.props.timeout}
+ refreshOverlayVisible={props.refreshOverlayVisible}
+ setControlValue={props.actions.setControlValue}
+ timeout={props.timeout}
triggerQuery={chart.triggerQuery}
- vizType={this.props.vizType}
+ vizType={props.vizType}
/>
)
}
</ParentSize>
);
- }
+ };
- render() {
- if (this.props.standalone) {
- // dom manipulation hack to get rid of the boostrap theme's body background
- const standaloneClass = 'background-transparent';
- const bodyClasses = document.body.className.split(' ');
- if (bodyClasses.indexOf(standaloneClass) === -1) {
- document.body.className += ` ${standaloneClass}`;
- }
- return this.renderChart();
+ if (props.standalone) {
+ // dom manipulation hack to get rid of the boostrap theme's body background
+ const standaloneClass = 'background-transparent';
+ const bodyClasses = document.body.className.split(' ');
+ if (bodyClasses.indexOf(standaloneClass) === -1) {
Review comment:
```suggestion
if (!bodyClasses.includes(standaloneClass)) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (227135d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `4.19%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
- Coverage 67.59% 63.39% -4.20%
==========================================
Files 928 462 -466
Lines 45053 28418 -16635
Branches 4309 0 -4309
==========================================
- Hits 30455 18017 -12438
+ Misses 14495 10401 -4094
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.39% <ø> (-0.68%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.08% <0.00%> (-29.97%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-11.88%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| ... and [467 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...227135d](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (15851b4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `4.06%`.
> The diff coverage is `22.83%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
- Coverage 67.59% 63.53% -4.07%
==========================================
Files 928 932 +4
Lines 45053 45276 +223
Branches 4309 4343 +34
==========================================
- Hits 30455 28767 -1688
- Misses 14495 16332 +1837
- Partials 103 177 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.86% <22.83%> (-0.32%)` | :arrow_down: |
| python | `63.93% <ø> (-0.15%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `10.90% <ø> (-47.28%)` | :arrow_down: |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `15.87% <12.50%> (-59.13%)` | :arrow_down: |
| [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `22.22% <22.22%> (ø)` | |
| [...ontend/src/explore/components/DataTableControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVDb250cm9sLnRzeA==) | `40.62% <40.62%> (ø)` | |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `47.05% <50.00%> (-21.09%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [208 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...62bd8f4](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (127b259) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `3.93%`.
> The diff coverage is `25.65%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
- Coverage 67.59% 63.66% -3.94%
==========================================
Files 928 930 +2
Lines 45053 45157 +104
Branches 4309 4319 +10
==========================================
- Hits 30455 28748 -1707
- Misses 14495 16232 +1737
- Partials 103 177 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.91% <25.65%> (-0.27%)` | :arrow_down: |
| python | `64.10% <ø> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `10.90% <ø> (-47.28%)` | :arrow_down: |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `17.54% <14.00%> (-57.46%)` | :arrow_down: |
| [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `26.47% <26.47%> (ø)` | |
| [...ontend/src/explore/components/DataTableControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVDb250cm9sLnRzeA==) | `40.62% <40.62%> (ø)` | |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `47.05% <50.00%> (-21.09%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [180 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...c897e74](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (127b259) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `4.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
- Coverage 67.59% 63.51% -4.09%
==========================================
Files 928 462 -466
Lines 45053 28417 -16636
Branches 4309 0 -4309
==========================================
- Hits 30455 18049 -12406
+ Misses 14495 10368 -4127
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.51% <ø> (-0.57%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.44%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-11.69%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.56% <0.00%> (-2.44%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.14% <0.00%> (-0.81%)` | :arrow_down: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.00% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.75% <0.00%> (-0.45%)` | :arrow_down: |
| ... and [471 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...c897e74](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#discussion_r534681691
##########
File path: superset-frontend/src/explore/components/ExploreChartPanel.jsx
##########
@@ -49,22 +52,124 @@ const propTypes = {
triggerRender: PropTypes.bool,
};
+export const EXPLORE_GUTTER_HEIGHT = 5;
Review comment:
I'd be tempted to see if we can live without these constants, and use `gridUnit` instead (which may require `useTheme` in some cases).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] adam-stasiak edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
adam-stasiak edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737894361
@junlincc I have a question related to searching in results:
Should X rows retrieved be showing proper value when we apply the search filter? Or just show as it is total number of rows.
During my tests it stil crashes when I set big amount of data but as it was said - it is not introduced by this PR.
@kgabryje Visual issue - while expanding data space there is a glitch. Maybe while expanding we can move also the bottom side?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (03c0c34) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `3.49%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
- Coverage 67.59% 64.10% -3.50%
==========================================
Files 928 462 -466
Lines 45053 28432 -16621
Branches 4309 0 -4309
==========================================
- Hits 30455 18226 -12229
+ Misses 14495 10206 -4289
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.10% <ø> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/setup/setupErrorMessages.ts](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRXJyb3JNZXNzYWdlcy50cw==) | | |
| [superset-frontend/src/explore/store.js](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvc3RvcmUuanM=) | | |
| [...t-frontend/src/SqlLab/components/ColumnElement.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0NvbHVtbkVsZW1lbnQudHN4) | | |
| [...-frontend/src/dashboard/actions/dashboardLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZExheW91dC5qcw==) | | |
| [...-frontend/src/components/Select/Select.stories.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC5zdG9yaWVzLnRzeA==) | | |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | | |
| [superset-frontend/src/components/Menu/Menu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51LnRzeA==) | | |
| [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | | |
| [...rc/explore/components/controls/ViewportControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaWV3cG9ydENvbnRyb2wuanN4) | | |
| [...end/src/SqlLab/components/RunQueryActionButton.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1J1blF1ZXJ5QWN0aW9uQnV0dG9uLnRzeA==) | | |
| ... and [458 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...c897e74](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on a change in pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#discussion_r535013187
##########
File path: superset-frontend/src/explore/components/DataTablesPane.jsx
##########
@@ -0,0 +1,201 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useState } from 'react';
+import PropTypes from 'prop-types';
+import { styled, t } from '@superset-ui/core';
+import {
+ CopyToClipboardButton,
+ FilterInput,
+ RowCount,
+ useFilteredTableData,
+ useTableColumns,
+} from './DataTableControl';
+import { Collapse } from '../../common/components';
+import Tabs from '../../common/components/Tabs';
+import Loading from '../../components/Loading';
+import TableView, { EmptyWrapperType } from '../../components/TableView';
+import { getChartDataRequest } from '../../chart/chartAction';
+import getClientErrorObject from '../../utils/getClientErrorObject';
+
+const RESULT_TYPES = {
+ results: 'results',
+ samples: 'samples',
+};
+const NULLISH_RESULTS_STATE = {
+ [RESULT_TYPES.results]: null,
+ [RESULT_TYPES.samples]: null,
+};
+
+const TableControlsWrapper = styled.div`
+ display: flex;
+ align-items: center;
+
+ span {
+ flex-shrink: 0;
+ }
+`;
+
+const SouthPane = styled.div`
+ background-color: ${({ theme }) => theme.colors.grayscale.light5};
+ z-index: 1;
+`;
+
+const TabsWrapper = styled.div`
+ height: ${({ contentHeight }) => contentHeight}px;
+ overflow: hidden;
+
+ .table-condensed {
+ height: 100%;
+ overflow: auto;
+ }
+`;
+
+export const DataTablesPane = ({
+ queryFormData,
+ tableSectionHeight,
+ onCollapseChange,
+}) => {
+ const [data, setData] = useState(NULLISH_RESULTS_STATE);
+ const [isLoading, setIsLoading] = useState(NULLISH_RESULTS_STATE);
+ const [error, setError] = useState(NULLISH_RESULTS_STATE);
+ const [filterText, setFilterText] = useState('');
+ const [activeTabKey, setActiveTabKey] = useState(RESULT_TYPES.results);
+
+ useEffect(() => {
+ const getData = resultType => {
+ setIsLoading(prevIsLoading => ({ ...prevIsLoading, [resultType]: true }));
+ return getChartDataRequest({
+ formData: queryFormData,
+ resultFormat: 'json',
+ resultType,
+ })
+ .then(response => {
+ // Currently displaying of only first query is supported
Review comment:
Oops, that's what I get for copy pasting without checking 🙂 I'll fix it in DisplayQueryButton too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (227135d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `3.56%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
- Coverage 67.59% 64.03% -3.57%
==========================================
Files 928 462 -466
Lines 45053 28418 -16635
Branches 4309 0 -4309
==========================================
- Hits 30455 18197 -12258
+ Misses 14495 10221 -4274
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.03% <ø> (-0.05%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.14% <0.00%> (-0.81%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.22% <0.00%> (-0.47%)` | :arrow_down: |
| [...ontend/src/views/CRUD/data/dataset/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0RhdGFzZXRMaXN0LnRzeA==) | | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | | |
| [...oard/components/gridComponents/new/NewMarkdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL25ldy9OZXdNYXJrZG93bi5qc3g=) | | |
| [...plore/components/controls/FilterBoxItemControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC5qc3g=) | | |
| [...end/src/dashboard/components/dnd/DragDroppable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9EcmFnRHJvcHBhYmxlLmpzeA==) | | |
| [...nd/src/dashboard/components/gridComponents/Row.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL1Jvdy5qc3g=) | | |
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | | |
| ... and [457 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...227135d](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737561985
> 5\. BUT, if a result set has many columns, we should scroll horizontally to make sure you can see every column (each with that max-width applied).
currently, when there are tooooo many columns, clicking View Samples just crash. also happening in this PR.
so 2,3,5 really are not new problems. we can merge this PR without them being addressed, but we should create separate PRs to fix those soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-736128667
addressing below issues:
- Run query button absolute position
- collapsible `DATA` section that includes `View Results` and `View Samples`
- minimum height for chart area 300px
- include Search, Copy, and # of retrieved row in the data section
- minor cosmetic issues
@villebro @evans @mihir14
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (15851b4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `0.08%`.
> The diff coverage is `66.87%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
- Coverage 67.59% 67.51% -0.09%
==========================================
Files 928 932 +4
Lines 45053 45285 +232
Branches 4309 4343 +34
==========================================
+ Hits 30455 30572 +117
- Misses 14495 14610 +115
Partials 103 103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.96% <63.69%> (+0.05%)` | :arrow_up: |
| javascript | `62.86% <22.83%> (-0.32%)` | :arrow_down: |
| python | `63.94% <ø> (-0.14%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `58.18% <ø> (ø)` | |
| [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `61.11% <61.11%> (ø)` | |
| [...ontend/src/explore/components/DataTableControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVDb250cm9sLnRzeA==) | `66.66% <66.66%> (ø)` | |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `76.19% <73.21%> (+1.19%)` | :arrow_up: |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `75.00% <100.00%> (+6.85%)` | :arrow_up: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.51% <0.00%> (-3.73%)` | :arrow_down: |
| ... and [39 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...62bd8f4](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
mistercrunch edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-738606061
I haven't looked at the code but wanted to make sure that we don't fetch samples unless/until the tab is selected.
I think that the "View Samples" use case is fairly uncommon. Also note that it only needs to be reprocess when the filters are altered, changing metrics and other query parameters don't require re-fetching/re-rendering.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on a change in pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#discussion_r536381853
##########
File path: superset-frontend/src/explore/components/DataTableControl.tsx
##########
@@ -0,0 +1,98 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useMemo } from 'react';
+import { styled, t } from '@superset-ui/core';
+import { FormControl } from 'react-bootstrap';
+import debounce from 'lodash/debounce';
+import Button from 'src/components/Button';
+import {
+ applyFormattingToTabularData,
+ prepareCopyToClipboardTabularData,
+} from 'src/utils/common';
+import CopyToClipboard from 'src/components/CopyToClipboard';
+import RowCountLabel from './RowCountLabel';
+
+export const CopyButton = styled(Button)`
+ font-size: ${({ theme }) => theme.typography.sizes.s}px;
+
+ // needed to override button's first-of-type margin: 0
+ && {
+ margin: 0 ${({ theme }) => theme.gridUnit * 2}px;
+ }
+
+ i {
+ padding: 0 ${({ theme }) => theme.gridUnit}px;
+ }
+`;
+
+export const CopyToClipboardButton = ({ data }: { data: object }) => (
+ <CopyToClipboard
+ text={data ? prepareCopyToClipboardTabularData(data) : ''}
Review comment:
It actually can be undefined, I changed `data: object` to `data?: Record<string, any>`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (585844f) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `3.58%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
- Coverage 67.59% 64.01% -3.59%
==========================================
Files 928 464 -464
Lines 45053 28525 -16528
Branches 4309 0 -4309
==========================================
- Hits 30455 18260 -12195
+ Misses 14495 10265 -4230
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.01% <ø> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.81% <0.00%> (-7.83%)` | :arrow_down: |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `80.00% <0.00%> (-3.24%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `79.62% <0.00%> (-0.67%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.58% <0.00%> (-0.37%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.64% <0.00%> (-0.13%)` | :arrow_down: |
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `40.53% <0.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.43% <0.00%> (ø)` | |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <0.00%> (ø)` | |
| ... and [475 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...585844f](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on a change in pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#discussion_r535174216
##########
File path: superset-frontend/src/explore/components/ExploreChartPanel.jsx
##########
@@ -73,67 +178,89 @@ class ExploreChartPanel extends React.PureComponent {
height > 0 && (
<ChartContainer
width={Math.floor(width)}
- height={parseInt(this.props.height, 10) - headerHeight}
+ height={chartSectionHeight}
annotationData={chart.annotationData}
chartAlert={chart.chartAlert}
chartStackTrace={chart.chartStackTrace}
chartId={chart.id}
chartStatus={chart.chartStatus}
- triggerRender={this.props.triggerRender}
- datasource={this.props.datasource}
- errorMessage={this.props.errorMessage}
- formData={this.props.form_data}
- onQuery={this.props.onQuery}
- owners={this.props?.slice?.owners}
+ triggerRender={props.triggerRender}
+ datasource={props.datasource}
+ errorMessage={props.errorMessage}
+ formData={props.form_data}
+ onQuery={props.onQuery}
+ owners={props?.slice?.owners}
queryResponse={chart.queryResponse}
- refreshOverlayVisible={this.props.refreshOverlayVisible}
- setControlValue={this.props.actions.setControlValue}
- timeout={this.props.timeout}
+ refreshOverlayVisible={props.refreshOverlayVisible}
+ setControlValue={props.actions.setControlValue}
+ timeout={props.timeout}
triggerQuery={chart.triggerQuery}
- vizType={this.props.vizType}
+ vizType={props.vizType}
/>
)
}
</ParentSize>
);
- }
+ };
- render() {
- if (this.props.standalone) {
- // dom manipulation hack to get rid of the boostrap theme's body background
- const standaloneClass = 'background-transparent';
- const bodyClasses = document.body.className.split(' ');
- if (bodyClasses.indexOf(standaloneClass) === -1) {
- document.body.className += ` ${standaloneClass}`;
- }
- return this.renderChart();
+ if (props.standalone) {
+ // dom manipulation hack to get rid of the boostrap theme's body background
+ const standaloneClass = 'background-transparent';
+ const bodyClasses = document.body.className.split(' ');
+ if (bodyClasses.indexOf(standaloneClass) === -1) {
Review comment:
I changed `indexOf` to `includes`. As for getting rid of this "hackiness" - like you said, let's do it in a separate PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] adam-stasiak commented on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
adam-stasiak commented on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737894361
@junlincc I have a question related to searching in results:
Should X rows retrieved be showing proper value when we apply the search filter? Or just show as it is total number of rows.
During my tests it stil crashes when I set big amount of data but as it was said - it is not introduced by this PR.
@kgabryje Visual issue - while expanding data space there is a glitch. Maybe while expanding we can move also the bottom side?
![Uploading Hnet.com-image.gif…]()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (62bd8f4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `3.92%`.
> The diff coverage is `22.02%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
- Coverage 67.59% 63.67% -3.93%
==========================================
Files 928 934 +6
Lines 45053 45321 +268
Branches 4309 4345 +36
==========================================
- Hits 30455 28858 -1597
- Misses 14495 16286 +1791
- Partials 103 177 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.82% <22.02%> (-0.36%)` | :arrow_down: |
| python | `64.17% <ø> (+0.09%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `10.90% <ø> (-47.28%)` | :arrow_down: |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `13.63% <10.16%> (-61.37%)` | :arrow_down: |
| [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `22.85% <22.85%> (ø)` | |
| [...ontend/src/explore/components/DataTableControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVDb250cm9sLnRzeA==) | `37.83% <37.83%> (ø)` | |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `47.05% <50.00%> (-21.09%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [202 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...585844f](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (585844f) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `4.35%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
- Coverage 67.59% 63.24% -4.36%
==========================================
Files 928 464 -464
Lines 45053 28510 -16543
Branches 4309 0 -4309
==========================================
- Hits 30455 18032 -12423
+ Misses 14495 10478 -4017
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.24% <ø> (-0.83%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.44%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-11.69%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `83.67% <0.00%> (-5.31%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| ... and [496 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...585844f](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (7ad3415) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `7.03%`.
> The diff coverage is `64.78%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
- Coverage 67.59% 60.55% -7.04%
==========================================
Files 928 885 -43
Lines 45053 43329 -1724
Branches 4309 3825 -484
==========================================
- Hits 30455 26240 -4215
- Misses 14495 17089 +2594
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.37% <64.78%> (-0.53%)` | :arrow_down: |
| javascript | `?` | |
| python | `63.79% <ø> (-0.28%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `58.18% <ø> (ø)` | |
| [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `57.62% <57.62%> (ø)` | |
| [...ontend/src/explore/components/DataTableControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVDb250cm9sLnRzeA==) | `60.00% <60.00%> (ø)` | |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `76.19% <73.21%> (+1.19%)` | :arrow_up: |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `75.00% <100.00%> (+6.85%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| ... and [342 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...7ad3415](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (227135d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `3.92%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
- Coverage 67.59% 63.67% -3.93%
==========================================
Files 928 462 -466
Lines 45053 28418 -16635
Branches 4309 0 -4309
==========================================
- Hits 30455 18094 -12361
+ Misses 14495 10324 -4171
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.67% <ø> (-0.41%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.08% <0.00%> (-29.97%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.87% <0.00%> (-1.08%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.22% <0.00%> (-0.47%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.62% <0.00%> (-0.14%)` | :arrow_down: |
| [...et-frontend/src/explore/controlPanels/Separator.js](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9TZXBhcmF0b3IuanM=) | | |
| [...et-frontend/src/SqlLab/components/QueryHistory.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5SGlzdG9yeS5qc3g=) | | |
| [superset-frontend/src/components/FaveStar.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmF2ZVN0YXIudHN4) | | |
| [...rset-frontend/src/common/components/DatePicker.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0RhdGVQaWNrZXIudHN4) | | |
| ... and [460 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...227135d](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737561985
> 5\. BUT, if a result set has many columns, we should scroll horizontally to make sure you can see every column (each with that max-width applied).
currently, when there are tooooo many columns, clicking View Samples just crash the explore view. also happening in this PR.
so 2,3,5 really are not new problems. we can merge this PR without them being addressed, but we should create separate PRs to fix those soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (7ad3415) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `6.83%`.
> The diff coverage is `64.78%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
- Coverage 67.59% 60.76% -6.84%
==========================================
Files 928 885 -43
Lines 45053 43329 -1724
Branches 4309 3825 -484
==========================================
- Hits 30455 26327 -4128
- Misses 14495 17002 +2507
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.96% <64.78%> (+0.05%)` | :arrow_up: |
| javascript | `?` | |
| python | `63.79% <ø> (-0.28%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `58.18% <ø> (ø)` | |
| [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `57.62% <57.62%> (ø)` | |
| [...ontend/src/explore/components/DataTableControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVDb250cm9sLnRzeA==) | `60.00% <60.00%> (ø)` | |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `76.19% <73.21%> (+1.19%)` | :arrow_up: |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `75.00% <100.00%> (+6.85%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| ... and [341 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...7ad3415](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (227135d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `3.95%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
- Coverage 67.59% 63.63% -3.96%
==========================================
Files 928 462 -466
Lines 45053 28418 -16635
Branches 4309 0 -4309
==========================================
- Hits 30455 18085 -12370
+ Misses 14495 10333 -4162
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.63% <ø> (-0.44%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.08% <0.00%> (-29.97%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.87% <0.00%> (-1.08%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.22% <0.00%> (-0.47%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.36% <0.00%> (-0.41%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.20% <0.00%> (-0.27%)` | :arrow_down: |
| ... and [464 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...227135d](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (7ad3415) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `4.26%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
- Coverage 67.59% 63.32% -4.27%
==========================================
Files 928 462 -466
Lines 45053 28437 -16616
Branches 4309 0 -4309
==========================================
- Hits 30455 18009 -12446
+ Misses 14495 10428 -4067
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.32% <ø> (-0.75%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.30% <0.00%> (-25.14%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.81% <0.00%> (-7.83%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `80.73% <0.00%> (-6.73%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `83.33% <0.00%> (-5.56%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.96% <0.00%> (-3.73%)` | :arrow_down: |
| ... and [478 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...7ad3415](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (62bd8f4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `4.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
- Coverage 67.59% 63.53% -4.07%
==========================================
Files 928 464 -464
Lines 45053 28510 -16543
Branches 4309 0 -4309
==========================================
- Hits 30455 18114 -12341
+ Misses 14495 10396 -4099
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.53% <ø> (-0.54%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.44%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-11.69%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `80.00% <0.00%> (-3.24%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.56% <0.00%> (-2.44%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| ... and [488 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...585844f](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-738853449
tested in Mozilla today.
- previous cosmetic issues are addressed ✅
- white background added to the table ✅
- empty state ✅
- show key only ✅
remaining issues:
1. typing text in search seems there's delay, see gif - should address separately, confirmed that it's happening currently in master, not related to this PR
2. glitch when resizing - users will not likely resize too fast, not critical, should merge and address later
3. big data sample crash - already assigned separate issue, and prioritized, it should be fixed soon.
@etr2460 @rusackas any objections?
> @mistercrunch I noticed that on current master, we send a request for samples not only when chart data changes, but every time we open a modal. Should we consider refetching samples only when filters change as a separate feature?
if this behavior is not new, we should address it separately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-738609694
> I haven't looked at the code but wanted to make sure that we don't fetch samples unless/until the tab is selected.
>
> I think that the "View Samples" use case is fairly uncommon. Also note that it only needs to be reprocess when the filters are altered, changing metrics and other query parameters don't require re-fetching/re-rendering.
Currently both results and samples are fetched when user expands Data panel. They are refetched when query params change. I'll try to optimize that so that Samples are fetched only when needed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (03c0c34) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `4.42%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
- Coverage 67.59% 63.17% -4.43%
==========================================
Files 928 462 -466
Lines 45053 28417 -16636
Branches 4309 0 -4309
==========================================
- Hits 30455 17952 -12503
+ Misses 14495 10465 -4030
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.17% <ø> (-0.91%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.44%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-11.69%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `83.67% <0.00%> (-5.31%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| ... and [483 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...c897e74](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-738944514
@mistercrunch Shall we create a separate task for that?
@junlincc I fixed the delay in filter input. Now it waits for 300ms after user stops typing to rerender the table.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (127b259) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `4.30%`.
> The diff coverage is `25.65%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
- Coverage 67.59% 63.29% -4.31%
==========================================
Files 928 930 +2
Lines 45053 45142 +89
Branches 4309 4319 +10
==========================================
- Hits 30455 28571 -1884
- Misses 14495 16394 +1899
- Partials 103 177 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.91% <25.65%> (-0.27%)` | :arrow_down: |
| python | `63.51% <ø> (-0.57%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `10.90% <ø> (-47.28%)` | :arrow_down: |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `17.54% <14.00%> (-57.46%)` | :arrow_down: |
| [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `26.47% <26.47%> (ø)` | |
| [...ontend/src/explore/components/DataTableControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVDb250cm9sLnRzeA==) | `40.62% <40.62%> (ø)` | |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `47.05% <50.00%> (-21.09%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [193 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...c897e74](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#discussion_r534680192
##########
File path: superset-frontend/src/explore/components/DataTablesPane.jsx
##########
@@ -0,0 +1,201 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useState } from 'react';
+import PropTypes from 'prop-types';
+import { styled, t } from '@superset-ui/core';
+import {
+ CopyToClipboardButton,
+ FilterInput,
+ RowCount,
+ useFilteredTableData,
+ useTableColumns,
+} from './DataTableControl';
+import { Collapse } from '../../common/components';
Review comment:
`src` based paths would be preferred here too (just a nit)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737626332
to confirm, this PR does offer horizontal scroll to show all columns(when it's not tooooo many like over 300 columns)
page does crashes when i tried to view a large sample
these are all old behaviors, not introduced by this PR.
so scratch what i said in point 5. apologies for the confusion! @kgabryje
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (127b259) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `4.03%`.
> The diff coverage is `25.65%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
- Coverage 67.59% 63.55% -4.04%
==========================================
Files 928 930 +2
Lines 45053 45157 +104
Branches 4309 4319 +10
==========================================
- Hits 30455 28701 -1754
- Misses 14495 16279 +1784
- Partials 103 177 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.91% <25.65%> (-0.27%)` | :arrow_down: |
| python | `63.93% <ø> (-0.14%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `10.90% <ø> (-47.28%)` | :arrow_down: |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `17.54% <14.00%> (-57.46%)` | :arrow_down: |
| [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `26.47% <26.47%> (ø)` | |
| [...ontend/src/explore/components/DataTableControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVDb250cm9sLnRzeA==) | `40.62% <40.62%> (ø)` | |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `47.05% <50.00%> (-21.09%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [184 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...c897e74](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (227135d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `4.19%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
- Coverage 67.59% 63.40% -4.20%
==========================================
Files 928 462 -466
Lines 45053 28416 -16637
Branches 4309 0 -4309
==========================================
- Hits 30455 18016 -12439
+ Misses 14495 10400 -4095
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.40% <ø> (-0.68%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.08% <0.00%> (-29.97%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-11.88%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| ... and [468 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...227135d](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (03c0c34) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `3.70%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
- Coverage 67.59% 63.88% -3.71%
==========================================
Files 928 462 -466
Lines 45053 28432 -16621
Branches 4309 0 -4309
==========================================
- Hits 30455 18165 -12290
+ Misses 14495 10267 -4228
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.88% <ø> (-0.19%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.81% <0.00%> (-7.83%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.87% <0.00%> (-1.08%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.22% <0.00%> (-0.47%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.64% <0.00%> (-0.13%)` | :arrow_down: |
| [superset-frontend/src/profile/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvaW5kZXgudHN4) | | |
| [...frontend/src/dashboard/util/newEntitiesFromDrop.js](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0VudGl0aWVzRnJvbURyb3AuanM=) | | |
| [...d/src/dashboard/util/logging/childChartsDidLoad.js](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2xvZ2dpbmcvY2hpbGRDaGFydHNEaWRMb2FkLmpz) | | |
| ... and [463 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...c897e74](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (127b259) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `4.42%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
- Coverage 67.59% 63.17% -4.43%
==========================================
Files 928 462 -466
Lines 45053 28417 -16636
Branches 4309 0 -4309
==========================================
- Hits 30455 17952 -12503
+ Misses 14495 10465 -4030
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.17% <ø> (-0.91%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.44%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-11.69%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `83.67% <0.00%> (-5.31%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| ... and [483 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...c897e74](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (03c0c34) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **increase** coverage by `0.02%`.
> The diff coverage is `69.53%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
+ Coverage 67.59% 67.62% +0.02%
==========================================
Files 928 930 +2
Lines 45053 45164 +111
Branches 4309 4319 +10
==========================================
+ Hits 30455 30542 +87
- Misses 14495 14519 +24
Partials 103 103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.94% <66.16%> (+0.03%)` | :arrow_up: |
| javascript | `62.91% <25.33%> (-0.27%)` | :arrow_down: |
| python | `64.10% <ø> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `58.18% <ø> (ø)` | |
| [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `65.15% <65.15%> (ø)` | |
| [...ontend/src/explore/components/DataTableControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVDb250cm9sLnRzeA==) | `66.66% <66.66%> (ø)` | |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `78.94% <76.00%> (+3.94%)` | :arrow_up: |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `75.00% <100.00%> (+6.85%)` | :arrow_up: |
| [...ponents/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyU2ltcGxlVGFiQ29udGVudC5qc3g=) | `81.81% <0.00%> (-1.82%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `92.06% <0.00%> (-1.59%)` | :arrow_down: |
| [superset-frontend/src/utils/downloadAsImage.ts](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2Rvd25sb2FkQXNJbWFnZS50cw==) | `33.33% <0.00%> (ø)` | |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `73.59% <0.00%> (ø)` | |
| [...t-frontend/src/views/CRUD/welcome/SavedQueries.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9TYXZlZFF1ZXJpZXMudHN4) | `62.24% <0.00%> (ø)` | |
| ... and [10 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...c897e74](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (585844f) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `4.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
- Coverage 67.59% 63.53% -4.07%
==========================================
Files 928 464 -464
Lines 45053 28525 -16528
Branches 4309 0 -4309
==========================================
- Hits 30455 18122 -12333
+ Misses 14495 10403 -4092
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.53% <ø> (-0.55%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.44%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-11.69%)` | :arrow_down: |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `80.00% <0.00%> (-3.24%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.22% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `79.62% <0.00%> (-0.67%)` | :arrow_down: |
| ... and [479 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...585844f](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-738138322
> Should X rows retrieved be showing proper value when we apply the search filter?
i thought about that, let's keep showing the #row retrieved, because the search filter result is temporary for this PR, I will get some user feedback later, if change is needed, we can address later.
> During my tests it stil crashes when I set big amount of data but as it was said - it is not introduced by this PR.
i assigned this issue to another external team member, no need to worry
> Unfortunately, the result is that a chart is visible under the Data button. @junlincc Do you think that's acceptable?
this is not ideal of course, if it takes less than a day to fix, let's fix. if more, let's open a separate issue later. there are way too many small cosmetic issues in this product, if it's not a deal breaker, we can always address separately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (03c0c34) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `3.93%`.
> The diff coverage is `25.33%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
- Coverage 67.59% 63.66% -3.94%
==========================================
Files 928 930 +2
Lines 45053 45155 +102
Branches 4309 4319 +10
==========================================
- Hits 30455 28747 -1708
- Misses 14495 16231 +1736
- Partials 103 177 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.91% <25.33%> (-0.27%)` | :arrow_down: |
| python | `64.10% <ø> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `10.90% <ø> (-47.28%)` | :arrow_down: |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `17.54% <14.00%> (-57.46%)` | :arrow_down: |
| [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `25.75% <25.75%> (ø)` | |
| [...ontend/src/explore/components/DataTableControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVDb250cm9sLnRzeA==) | `40.62% <40.62%> (ø)` | |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `47.05% <50.00%> (-21.09%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [180 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...c897e74](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on a change in pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#discussion_r536323528
##########
File path: superset-frontend/src/explore/components/ExploreChartPanel.jsx
##########
@@ -49,22 +52,124 @@ const propTypes = {
triggerRender: PropTypes.bool,
};
+export const EXPLORE_GUTTER_HEIGHT = 5;
Review comment:
I like this idea... but in this case 1px really does make a difference.
Here's a gutter height 4px:
And here's 5px:
Maybe the screenshots don't really show it, but in my opinion 5px looks much much better. Which raises a question, do we want do play around with 1.25 multiplier for gridUnit?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (62bd8f4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `4.04%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
- Coverage 67.59% 63.55% -4.05%
==========================================
Files 928 464 -464
Lines 45053 28525 -16528
Branches 4309 0 -4309
==========================================
- Hits 30455 18128 -12327
+ Misses 14495 10397 -4098
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.55% <ø> (-0.53%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.44%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-11.69%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `80.00% <0.00%> (-3.24%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| ... and [480 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...585844f](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737550813
Adding on to @junlincc 's numbering system:
1) Agreed, let's fix that
2) Let's fix that *IF* it works in the current implementation. If not, let's file an issue and tackle that separately, so we can merge this one.
3) This is an enhancement, not addressed in the current solution. Let's file an issue and tackle that in a separate PR.
4) Easy fix, let's fix.
5) Just to clarify the scrolling business. I _do not_ think we should un-truncate that cell. JSON can be huuuuuuuuge, so we should set a reasonable max-width on any given cell, and truncate with ellipsis. BUT, if a result set has many columns, we should scroll horizontally to make sure you can see every column (each with that max-width applied).
This is looking AWESOME, btw, super excited about this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on a change in pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#discussion_r535170802
##########
File path: superset-frontend/src/explore/components/DataTableControl.jsx
##########
@@ -0,0 +1,91 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useMemo } from 'react';
+import { styled, t } from '@superset-ui/core';
+import { FormControl } from 'react-bootstrap';
+import Button from '../../components/Button';
+import RowCountLabel from './RowCountLabel';
+import {
+ applyFormattingToTabularData,
+ prepareCopyToClipboardTabularData,
+} from '../../utils/common';
+import CopyToClipboard from '../../components/CopyToClipboard';
+
+const CopyButton = styled(Button)`
+ padding: ${({ theme }) => theme.gridUnit / 2}px
+ ${({ theme }) => theme.gridUnit * 2.5}px;
+ font-size: ${({ theme }) => theme.typography.sizes.s}px;
+
+ // needed to override button's first-of-type margin: 0
+ && {
+ margin: 0 ${({ theme }) => theme.gridUnit * 2}px;
+ }
+
+ i {
+ padding: 0;
+ }
+`;
+
+export const CopyToClipboardButton = ({ data }) => (
+ <CopyToClipboard
+ text={data ? prepareCopyToClipboardTabularData(data) : ''}
+ wrapped={false}
+ copyNode={
+ <CopyButton>
+ <i className="fa fa-clipboard" />
+ </CopyButton>
+ }
+ />
+);
+
+export const FilterInput = ({ filterText, onChangeHandler }) => (
+ <FormControl
+ placeholder={t('Search')}
+ bsSize="sm"
+ value={filterText}
+ onChange={onChangeHandler}
+ style={{ paddingBottom: '5px' }}
Review comment:
I removed this padding, it wasn't needed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737561985
> 5\. BUT, if a result set has many columns, we should scroll horizontally to make sure you can see every column (each with that max-width applied).
currently, when there are tooooo many columns, clicking View Samples just crash the explore view. also happening in this PR.
so 2,3,5 really are not new problems. we can merge this PR without them being addressed, but we should create separate PRs to fix those soon. no necessary by @kgabryje though. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-738218449
1 more change - I delayed sending requests for results and samples until the collapse panel is opened.
CC: @rusackas @etr2460
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#discussion_r534684644
##########
File path: superset-frontend/src/explore/components/ExploreChartPanel.jsx
##########
@@ -49,22 +52,124 @@ const propTypes = {
triggerRender: PropTypes.bool,
};
+export const EXPLORE_GUTTER_HEIGHT = 5;
+export const EXPLORE_GUTTER_MARGIN = 3;
+export const CHART_PANEL_PADDING = 30;
+
+const INITIAL_SIZES = [90, 10];
+const MIN_SIZES = [300, 50];
+
const Styles = styled.div`
background-color: ${({ theme }) => theme.colors.grayscale.light5};
height: 100%;
display: flex;
flex-direction: column;
align-items: stretch;
align-content: stretch;
+ overflow: hidden;
+
& > div:last-of-type {
flex-basis: 100%;
}
+
+ .gutter {
+ border-top: 1px solid ${({ theme }) => theme.colors.grayscale.light2};
+ border-bottom: 1px solid ${({ theme }) => theme.colors.grayscale.light2};
+ width: 3%;
Review comment:
`gridUnit` FTW! :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (62bd8f4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `0.07%`.
> The diff coverage is `66.27%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
- Coverage 67.59% 67.51% -0.08%
==========================================
Files 928 934 +6
Lines 45053 45330 +277
Branches 4309 4345 +36
==========================================
+ Hits 30455 30606 +151
- Misses 14495 14617 +122
- Partials 103 107 +4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.30% <62.91%> (-0.61%)` | :arrow_down: |
| javascript | `62.82% <22.02%> (-0.36%)` | :arrow_down: |
| python | `64.17% <ø> (+0.09%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `58.18% <ø> (ø)` | |
| [...ontend/src/explore/components/DataTableControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVDb250cm9sLnRzeA==) | `60.52% <60.52%> (ø)` | |
| [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `61.42% <61.42%> (ø)` | |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `77.27% <74.57%> (+2.27%)` | :arrow_up: |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `75.00% <100.00%> (+6.85%)` | :arrow_up: |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `70.88% <0.00%> (-8.87%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `76.12% <0.00%> (-5.17%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `60.25% <0.00%> (-4.28%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `49.01% <0.00%> (-3.93%)` | :arrow_down: |
| ... and [43 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...585844f](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on a change in pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#discussion_r535009547
##########
File path: superset-frontend/src/explore/components/DataTableControl.jsx
##########
@@ -0,0 +1,91 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useMemo } from 'react';
+import { styled, t } from '@superset-ui/core';
+import { FormControl } from 'react-bootstrap';
+import Button from '../../components/Button';
+import RowCountLabel from './RowCountLabel';
+import {
+ applyFormattingToTabularData,
+ prepareCopyToClipboardTabularData,
+} from '../../utils/common';
+import CopyToClipboard from '../../components/CopyToClipboard';
+
+const CopyButton = styled(Button)`
+ padding: ${({ theme }) => theme.gridUnit / 2}px
Review comment:
That's how it looks with `buttonSize="xs"`. Paddings with full gridUnits looked a bit awkward in my opinion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (585844f) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `4.02%`.
> The diff coverage is `22.02%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
- Coverage 67.59% 63.57% -4.03%
==========================================
Files 928 934 +6
Lines 45053 45321 +268
Branches 4309 4345 +36
==========================================
- Hits 30455 28812 -1643
- Misses 14495 16332 +1837
- Partials 103 177 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.82% <22.02%> (-0.36%)` | :arrow_down: |
| python | `64.01% <ø> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `10.90% <ø> (-47.28%)` | :arrow_down: |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `13.63% <10.16%> (-61.37%)` | :arrow_down: |
| [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `22.85% <22.85%> (ø)` | |
| [...ontend/src/explore/components/DataTableControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVDb250cm9sLnRzeA==) | `37.83% <37.83%> (ø)` | |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `47.05% <50.00%> (-21.09%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [204 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...585844f](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#discussion_r534692789
##########
File path: superset-frontend/src/explore/components/ExploreChartPanel.jsx
##########
@@ -73,67 +178,89 @@ class ExploreChartPanel extends React.PureComponent {
height > 0 && (
<ChartContainer
width={Math.floor(width)}
- height={parseInt(this.props.height, 10) - headerHeight}
+ height={chartSectionHeight}
annotationData={chart.annotationData}
chartAlert={chart.chartAlert}
chartStackTrace={chart.chartStackTrace}
chartId={chart.id}
chartStatus={chart.chartStatus}
- triggerRender={this.props.triggerRender}
- datasource={this.props.datasource}
- errorMessage={this.props.errorMessage}
- formData={this.props.form_data}
- onQuery={this.props.onQuery}
- owners={this.props?.slice?.owners}
+ triggerRender={props.triggerRender}
+ datasource={props.datasource}
+ errorMessage={props.errorMessage}
+ formData={props.form_data}
+ onQuery={props.onQuery}
+ owners={props?.slice?.owners}
queryResponse={chart.queryResponse}
- refreshOverlayVisible={this.props.refreshOverlayVisible}
- setControlValue={this.props.actions.setControlValue}
- timeout={this.props.timeout}
+ refreshOverlayVisible={props.refreshOverlayVisible}
+ setControlValue={props.actions.setControlValue}
+ timeout={props.timeout}
triggerQuery={chart.triggerQuery}
- vizType={this.props.vizType}
+ vizType={props.vizType}
/>
)
}
</ParentSize>
);
- }
+ };
- render() {
- if (this.props.standalone) {
- // dom manipulation hack to get rid of the boostrap theme's body background
- const standaloneClass = 'background-transparent';
- const bodyClasses = document.body.className.split(' ');
- if (bodyClasses.indexOf(standaloneClass) === -1) {
- document.body.className += ` ${standaloneClass}`;
- }
- return this.renderChart();
+ if (props.standalone) {
+ // dom manipulation hack to get rid of the boostrap theme's body background
+ const standaloneClass = 'background-transparent';
+ const bodyClasses = document.body.className.split(' ');
+ if (bodyClasses.indexOf(standaloneClass) === -1) {
Review comment:
OK, I admit the above suggestion, and this one, are kind of out of scope for this PR, but I'll just mention this anyway. We can potentially skip all this gross DOM and class manipulation jazz, and just use the prop to control some Emotion styles applied to the body tag with Emotion's `Global` component.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (15851b4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `4.05%`.
> The diff coverage is `22.83%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
- Coverage 67.59% 63.54% -4.06%
==========================================
Files 928 932 +4
Lines 45053 45276 +223
Branches 4309 4343 +34
==========================================
- Hits 30455 28770 -1685
- Misses 14495 16329 +1834
- Partials 103 177 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.86% <22.83%> (-0.32%)` | :arrow_down: |
| python | `63.94% <ø> (-0.14%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `10.90% <ø> (-47.28%)` | :arrow_down: |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `15.87% <12.50%> (-59.13%)` | :arrow_down: |
| [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `22.22% <22.22%> (ø)` | |
| [...ontend/src/explore/components/DataTableControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVDb250cm9sLnRzeA==) | `40.62% <40.62%> (ø)` | |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `47.05% <50.00%> (-21.09%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [208 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...62bd8f4](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (62bd8f4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **increase** coverage by `0.04%`.
> The diff coverage is `66.27%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
+ Coverage 67.59% 67.64% +0.04%
==========================================
Files 928 934 +6
Lines 45053 45330 +277
Branches 4309 4345 +36
==========================================
+ Hits 30455 30662 +207
- Misses 14495 14565 +70
Partials 103 103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.88% <62.91%> (-0.02%)` | :arrow_down: |
| javascript | `62.82% <22.02%> (-0.36%)` | :arrow_down: |
| python | `64.17% <ø> (+0.09%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `58.18% <ø> (ø)` | |
| [...ontend/src/explore/components/DataTableControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVDb250cm9sLnRzeA==) | `60.52% <60.52%> (ø)` | |
| [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `61.42% <61.42%> (ø)` | |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `77.27% <74.57%> (+2.27%)` | :arrow_up: |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `75.00% <100.00%> (+6.85%)` | :arrow_up: |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `80.00% <0.00%> (-3.24%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `51.76% <0.00%> (-1.90%)` | :arrow_down: |
| [...ponents/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyU2ltcGxlVGFiQ29udGVudC5qc3g=) | `81.81% <0.00%> (-1.82%)` | :arrow_down: |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `79.62% <0.00%> (-0.67%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.85% <0.00%> (-0.10%)` | :arrow_down: |
| ... and [34 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...585844f](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on a change in pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#discussion_r535009547
##########
File path: superset-frontend/src/explore/components/DataTableControl.jsx
##########
@@ -0,0 +1,91 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useMemo } from 'react';
+import { styled, t } from '@superset-ui/core';
+import { FormControl } from 'react-bootstrap';
+import Button from '../../components/Button';
+import RowCountLabel from './RowCountLabel';
+import {
+ applyFormattingToTabularData,
+ prepareCopyToClipboardTabularData,
+} from '../../utils/common';
+import CopyToClipboard from '../../components/CopyToClipboard';
+
+const CopyButton = styled(Button)`
+ padding: ${({ theme }) => theme.gridUnit / 2}px
Review comment:
That's how it looks with `buttonSize="xs"`. Paddings witht full gridUnits looked a bit awkward in my opinion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737673926
> > page does crashes when i tried to view a large sample
>
> @junlincc is that actually current behavior in master? Is there an issue tracking it? it looks pretty serious to me
100%positive this is currently happening~ i agree this is serious, after this change, View Samples will be more accessible to the users,, which means crashes will more likely to happen as users poke around this new feature. https://github.com/apache/incubator-superset/issues/11908
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (15851b4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `0.21%`.
> The diff coverage is `66.87%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
- Coverage 67.59% 67.38% -0.22%
==========================================
Files 928 932 +4
Lines 45053 45285 +232
Branches 4309 4343 +34
==========================================
+ Hits 30455 30516 +61
- Misses 14495 14662 +167
- Partials 103 107 +4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.37% <63.69%> (-0.54%)` | :arrow_down: |
| javascript | `62.86% <22.83%> (-0.32%)` | :arrow_down: |
| python | `63.94% <ø> (-0.14%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `58.18% <ø> (ø)` | |
| [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `61.11% <61.11%> (ø)` | |
| [...ontend/src/explore/components/DataTableControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVDb250cm9sLnRzeA==) | `66.66% <66.66%> (ø)` | |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `76.19% <73.21%> (+1.19%)` | :arrow_up: |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `75.00% <100.00%> (+6.85%)` | :arrow_up: |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `70.88% <0.00%> (-8.87%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| ... and [49 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...62bd8f4](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (227135d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `3.51%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
- Coverage 67.59% 64.08% -3.52%
==========================================
Files 928 462 -466
Lines 45053 28418 -16635
Branches 4309 0 -4309
==========================================
- Hits 30455 18212 -12243
+ Misses 14495 10206 -4289
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.08% <ø> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...perset-frontend/src/components/Menu/MenuObject.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51T2JqZWN0LnRzeA==) | | |
| [...t-frontend/src/dashboard/components/SliceAdder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlQWRkZXIuanN4) | | |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | | |
| [...dashboard/components/ColorSchemeControlWrapper.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0NvbG9yU2NoZW1lQ29udHJvbFdyYXBwZXIuanN4) | | |
| [superset-frontend/src/components/AsyncSelect.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNTZWxlY3QuanN4) | | |
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | | |
| [.../dashboard/util/logging/findNonTabChildChartIds.js](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2xvZ2dpbmcvZmluZE5vblRhYkNoaWxkQ2hhcnRJZHMuanM=) | | |
| [superset-frontend/src/views/CRUD/data/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9ob29rcy50cw==) | | |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | | |
| [superset-frontend/src/common/components/Switch.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1N3aXRjaC50c3g=) | | |
| ... and [454 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...227135d](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737673926
> > page does crashes when i tried to view a large sample
>
> @junlincc is that actually current behavior in master? Is there an issue tracking it? it looks pretty serious to me
100%positive~https://github.com/apache/incubator-superset/issues/11908
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (585844f) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `3.58%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
- Coverage 67.59% 64.01% -3.59%
==========================================
Files 928 464 -464
Lines 45053 28525 -16528
Branches 4309 0 -4309
==========================================
- Hits 30455 18259 -12196
+ Misses 14495 10266 -4229
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.01% <ø> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.81% <0.00%> (-7.83%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `80.00% <0.00%> (-3.24%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `79.62% <0.00%> (-0.67%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.58% <0.00%> (-0.37%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.64% <0.00%> (-0.13%)` | :arrow_down: |
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `40.53% <0.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.43% <0.00%> (ø)` | |
| ... and [476 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...585844f](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (585844f) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `3.92%`.
> The diff coverage is `22.02%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
- Coverage 67.59% 63.67% -3.93%
==========================================
Files 928 934 +6
Lines 45053 45321 +268
Branches 4309 4345 +36
==========================================
- Hits 30455 28858 -1597
- Misses 14495 16286 +1791
- Partials 103 177 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.82% <22.02%> (-0.36%)` | :arrow_down: |
| python | `64.17% <ø> (+0.09%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `10.90% <ø> (-47.28%)` | :arrow_down: |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `13.63% <10.16%> (-61.37%)` | :arrow_down: |
| [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `22.85% <22.85%> (ø)` | |
| [...ontend/src/explore/components/DataTableControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVDb250cm9sLnRzeA==) | `37.83% <37.83%> (ø)` | |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `47.05% <50.00%> (-21.09%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [202 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...585844f](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-738628112
@mistercrunch I noticed that on current master, we send a request for samples not only when chart data changes, but every time we open a modal. Should we consider refetching samples only when filters change as a separate feature?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-738238801
@junlincc @adam-stasiak I added a white background that makes the table area not transparent during resizing. Could you check it out?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (2869377) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `12.56%`.
> The diff coverage is `64.78%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
===========================================
- Coverage 67.59% 55.03% -12.57%
===========================================
Files 928 422 -506
Lines 45053 14886 -30167
Branches 4309 3822 -487
===========================================
- Hits 30455 8192 -22263
+ Misses 14495 6694 -7801
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `55.03% <64.78%> (+0.12%)` | :arrow_up: |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `58.18% <ø> (ø)` | |
| [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `57.62% <57.62%> (ø)` | |
| [...ontend/src/explore/components/DataTableControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVDb250cm9sLnRzeA==) | `60.00% <60.00%> (ø)` | |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `76.19% <73.21%> (+1.19%)` | :arrow_up: |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `75.00% <100.00%> (+6.85%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| ... and [781 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...7ad3415](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-738606061
I haven't looked at the code but wanted to make sure that we don't fetch samples unless/until the tab is selected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-736128667
addressing below issues:
- Run query button absolute position
- collapsible `DATA` section that includes `View Results` and `View Samples`
- minimum height for chart area 300px
- include Search, Copy, and # of retrieved row in the data section
- minor cosmetic issues
@villebro @rusackas @mihir14
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737775608
@junlincc Arrow centered and text bolded
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on a change in pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#discussion_r535170506
##########
File path: superset-frontend/src/explore/components/DataTableControl.jsx
##########
@@ -0,0 +1,91 @@
+/**
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#discussion_r534657770
##########
File path: superset-frontend/src/explore/components/DataTableControl.jsx
##########
@@ -0,0 +1,91 @@
+/**
Review comment:
this is a new file, can you please use TypeScript?
##########
File path: superset-frontend/src/explore/components/DataTableControl.jsx
##########
@@ -0,0 +1,91 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useMemo } from 'react';
+import { styled, t } from '@superset-ui/core';
+import { FormControl } from 'react-bootstrap';
+import Button from '../../components/Button';
+import RowCountLabel from './RowCountLabel';
+import {
+ applyFormattingToTabularData,
+ prepareCopyToClipboardTabularData,
+} from '../../utils/common';
+import CopyToClipboard from '../../components/CopyToClipboard';
+
+const CopyButton = styled(Button)`
+ padding: ${({ theme }) => theme.gridUnit / 2}px
Review comment:
@rusackas do you think we should be doing division on `gridUnit`? I thought the intention was for this to be the smallest unit of sizing in the app
##########
File path: superset-frontend/src/explore/components/ExploreChartPanel.jsx
##########
@@ -49,22 +52,124 @@ const propTypes = {
triggerRender: PropTypes.bool,
};
+export const EXPLORE_GUTTER_HEIGHT = 5;
+export const EXPLORE_GUTTER_MARGIN = 3;
+export const CHART_PANEL_PADDING = 30;
+
+const INITIAL_SIZES = [90, 10];
+const MIN_SIZES = [300, 50];
+
const Styles = styled.div`
background-color: ${({ theme }) => theme.colors.grayscale.light5};
height: 100%;
display: flex;
flex-direction: column;
align-items: stretch;
align-content: stretch;
+ overflow: hidden;
+
& > div:last-of-type {
flex-basis: 100%;
}
+
+ .gutter {
+ border-top: 1px solid ${({ theme }) => theme.colors.grayscale.light2};
+ border-bottom: 1px solid ${({ theme }) => theme.colors.grayscale.light2};
+ width: 3%;
Review comment:
should the gutter be a % of the total width? Seems like a constant size would be better (both for folks with small and large width monitors)
##########
File path: superset-frontend/src/explore/components/DataTablesPane.jsx
##########
@@ -0,0 +1,201 @@
+/**
Review comment:
Since this is a new file, can you use TypeScript?
##########
File path: superset-frontend/src/explore/components/DataTableControl.jsx
##########
@@ -0,0 +1,91 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useMemo } from 'react';
+import { styled, t } from '@superset-ui/core';
+import { FormControl } from 'react-bootstrap';
+import Button from '../../components/Button';
+import RowCountLabel from './RowCountLabel';
+import {
+ applyFormattingToTabularData,
+ prepareCopyToClipboardTabularData,
+} from '../../utils/common';
+import CopyToClipboard from '../../components/CopyToClipboard';
+
+const CopyButton = styled(Button)`
+ padding: ${({ theme }) => theme.gridUnit / 2}px
+ ${({ theme }) => theme.gridUnit * 2.5}px;
+ font-size: ${({ theme }) => theme.typography.sizes.s}px;
+
+ // needed to override button's first-of-type margin: 0
+ && {
+ margin: 0 ${({ theme }) => theme.gridUnit * 2}px;
+ }
+
+ i {
+ padding: 0;
+ }
+`;
+
+export const CopyToClipboardButton = ({ data }) => (
+ <CopyToClipboard
+ text={data ? prepareCopyToClipboardTabularData(data) : ''}
+ wrapped={false}
+ copyNode={
+ <CopyButton>
+ <i className="fa fa-clipboard" />
+ </CopyButton>
+ }
+ />
+);
+
+export const FilterInput = ({ filterText, onChangeHandler }) => (
+ <FormControl
+ placeholder={t('Search')}
+ bsSize="sm"
+ value={filterText}
+ onChange={onChangeHandler}
+ style={{ paddingBottom: '5px' }}
Review comment:
can we use `styled` to apply the css here (or at least get the constant padding from the superset theme)?
##########
File path: superset-frontend/src/explore/components/DataTablesPane.jsx
##########
@@ -0,0 +1,201 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useState } from 'react';
+import PropTypes from 'prop-types';
+import { styled, t } from '@superset-ui/core';
+import {
+ CopyToClipboardButton,
+ FilterInput,
+ RowCount,
+ useFilteredTableData,
+ useTableColumns,
+} from './DataTableControl';
+import { Collapse } from '../../common/components';
+import Tabs from '../../common/components/Tabs';
+import Loading from '../../components/Loading';
+import TableView, { EmptyWrapperType } from '../../components/TableView';
+import { getChartDataRequest } from '../../chart/chartAction';
+import getClientErrorObject from '../../utils/getClientErrorObject';
+
+const RESULT_TYPES = {
+ results: 'results',
+ samples: 'samples',
+};
+const NULLISH_RESULTS_STATE = {
+ [RESULT_TYPES.results]: null,
+ [RESULT_TYPES.samples]: null,
+};
+
+const TableControlsWrapper = styled.div`
+ display: flex;
+ align-items: center;
+
+ span {
+ flex-shrink: 0;
+ }
+`;
+
+const SouthPane = styled.div`
+ background-color: ${({ theme }) => theme.colors.grayscale.light5};
+ z-index: 1;
+`;
+
+const TabsWrapper = styled.div`
+ height: ${({ contentHeight }) => contentHeight}px;
+ overflow: hidden;
+
+ .table-condensed {
+ height: 100%;
+ overflow: auto;
+ }
+`;
+
+export const DataTablesPane = ({
+ queryFormData,
+ tableSectionHeight,
+ onCollapseChange,
+}) => {
+ const [data, setData] = useState(NULLISH_RESULTS_STATE);
+ const [isLoading, setIsLoading] = useState(NULLISH_RESULTS_STATE);
+ const [error, setError] = useState(NULLISH_RESULTS_STATE);
+ const [filterText, setFilterText] = useState('');
+ const [activeTabKey, setActiveTabKey] = useState(RESULT_TYPES.results);
+
+ useEffect(() => {
+ const getData = resultType => {
+ setIsLoading(prevIsLoading => ({ ...prevIsLoading, [resultType]: true }));
+ return getChartDataRequest({
+ formData: queryFormData,
+ resultFormat: 'json',
+ resultType,
+ })
+ .then(response => {
+ // Currently displaying of only first query is supported
Review comment:
grammar nit: `Only displaying the first query is currently supported`
##########
File path: superset-frontend/src/explore/components/ExploreChartPanel.jsx
##########
@@ -49,22 +52,124 @@ const propTypes = {
triggerRender: PropTypes.bool,
};
+export const EXPLORE_GUTTER_HEIGHT = 5;
+export const EXPLORE_GUTTER_MARGIN = 3;
+export const CHART_PANEL_PADDING = 30;
+
+const INITIAL_SIZES = [90, 10];
+const MIN_SIZES = [300, 50];
+
const Styles = styled.div`
background-color: ${({ theme }) => theme.colors.grayscale.light5};
height: 100%;
display: flex;
flex-direction: column;
align-items: stretch;
align-content: stretch;
+ overflow: hidden;
+
& > div:last-of-type {
flex-basis: 100%;
}
+
+ .gutter {
+ border-top: 1px solid ${({ theme }) => theme.colors.grayscale.light2};
+ border-bottom: 1px solid ${({ theme }) => theme.colors.grayscale.light2};
+ width: 3%;
+ margin: ${EXPLORE_GUTTER_MARGIN}px 47%;
+ }
+
+ .gutter.gutter-vertical {
+ cursor: row-resize;
+ }
+
+ .ant-collapse {
+ height: 100%;
+ background-color: ${({ theme }) => theme.colors.grayscale.light5};
+ .ant-collapse-item {
+ height: 100%;
+ border: 0;
+ }
+ .ant-collapse-content,
+ .ant-collapse-content-box {
+ height: 100%;
+ }
+ .ant-collapse-header {
+ padding-top: 0;
+ padding-bottom: 0;
+ }
+ .ant-tabs {
+ height: 100%;
+ .ant-tabs-nav {
+ padding-left: ${({ theme }) => theme.gridUnit * 5}px;
+ margin: 0;
+ background-color: ${({ theme }) => theme.colors.grayscale.light5};
+ }
+ .ant-tabs-content-holder {
+ overflow: hidden;
+ .ant-tabs-content {
+ height: 100%;
+ }
+ }
+ }
+ }
`;
-class ExploreChartPanel extends React.PureComponent {
- renderChart() {
- const { chart } = this.props;
- const headerHeight = this.props.standalone ? 0 : 80;
+const ExploreChartPanel = props => {
+ const panelHeadingRef = useRef(null);
+ const [headerHeight, setHeaderHeight] = useState(props.standalone ? 0 : 50);
+ const [splitSizes, setSplitSizes] = useState(INITIAL_SIZES);
+
+ const calcSectionHeight = percent => {
+ const containerHeight = parseInt(props.height, 10) - headerHeight - 30;
+ return (
+ (containerHeight * percent) / 100 -
+ (EXPLORE_GUTTER_HEIGHT / 2 + EXPLORE_GUTTER_MARGIN)
+ );
+ };
+
+ const [chartSectionHeight, setChartSectionHeight] = useState(
+ calcSectionHeight(INITIAL_SIZES[0]) - CHART_PANEL_PADDING,
+ );
+ const [tableSectionHeight, setTableSectionHeight] = useState(
+ calcSectionHeight(INITIAL_SIZES[1]),
+ );
+
+ useEffect(() => {
+ const calcHeaderSize = debounce(() => {
+ setHeaderHeight(
+ props.standalone ? 0 : panelHeadingRef?.current?.offsetHeight,
+ );
+ }, 100);
+ calcHeaderSize();
+ document.addEventListener('resize', calcHeaderSize);
+ return () => document.removeEventListener('resize', calcHeaderSize);
+ }, [props.standalone]);
+
+ const recalcPanelSizes = ([northPercent, southPercent]) => {
+ setChartSectionHeight(
+ calcSectionHeight(northPercent) - CHART_PANEL_PADDING,
+ );
+ setTableSectionHeight(calcSectionHeight(southPercent));
+ };
+
+ const onCollapseChange = openPanelName => {
+ const defaultSouthPaneOpenHeightPercent = 40;
Review comment:
maybe make this a constant outside of the component?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (227135d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `3.51%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
- Coverage 67.59% 64.08% -3.52%
==========================================
Files 928 462 -466
Lines 45053 28418 -16635
Branches 4309 0 -4309
==========================================
- Hits 30455 18212 -12243
+ Misses 14495 10206 -4289
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.08% <ø> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ontend/src/views/CRUD/data/dataset/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0RhdGFzZXRMaXN0LnRzeA==) | | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | | |
| [...oard/components/gridComponents/new/NewMarkdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL25ldy9OZXdNYXJrZG93bi5qc3g=) | | |
| [...plore/components/controls/FilterBoxItemControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC5qc3g=) | | |
| [...end/src/dashboard/components/dnd/DragDroppable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9EcmFnRHJvcHBhYmxlLmpzeA==) | | |
| [...nd/src/dashboard/components/gridComponents/Row.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL1Jvdy5qc3g=) | | |
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | | |
| [...uperset-frontend/src/components/Checkbox/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3gvaW5kZXgudHN4) | | |
| [superset-frontend/src/setup/setupErrorMessages.ts](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRXJyb3JNZXNzYWdlcy50cw==) | | |
| [...nents/gridComponents/new/DraggableNewComponent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL25ldy9EcmFnZ2FibGVOZXdDb21wb25lbnQuanN4) | | |
| ... and [454 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...227135d](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-738881756
@kgabryje it's probably ok to only fetch samples when "View Samples" is first selected OR user hit run `Run`.
But logically I think it's only necessary to fetch the samples if the filtering has changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-738848093
> @junlincc @adam-stasiak I added a white background that makes the table area not transparent during resizing. Could you check it out?
white background is much better, thanks for adding it!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (03c0c34) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `4.13%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
- Coverage 67.59% 63.46% -4.14%
==========================================
Files 928 462 -466
Lines 45053 28417 -16636
Branches 4309 0 -4309
==========================================
- Hits 30455 18035 -12420
+ Misses 14495 10382 -4113
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.46% <ø> (-0.62%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.44%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-11.69%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.33% <0.00%> (-1.62%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.22% <0.00%> (-0.47%)` | :arrow_down: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.00% <0.00%> (-0.46%)` | :arrow_down: |
| ... and [471 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...c897e74](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje closed pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
kgabryje closed pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (03c0c34) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `4.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
- Coverage 67.59% 63.45% -4.15%
==========================================
Files 928 462 -466
Lines 45053 28432 -16621
Branches 4309 0 -4309
==========================================
- Hits 30455 18042 -12413
+ Misses 14495 10390 -4105
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.45% <ø> (-0.62%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.44%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-11.69%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.33% <0.00%> (-1.62%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.22% <0.00%> (-0.47%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.50% <0.00%> (-0.26%)` | :arrow_down: |
| ... and [465 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...c897e74](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737673926
> > page does crashes when i tried to view a large sample
>
> @junlincc is that actually current behavior in master? Is there an issue tracking it? it looks pretty serious to me
100%positive this is currently happening~ i agree this is serious, after this change, View Samples will be more accessible to the users,, which means crashes will more likely to happen as users poke around this new feature. https://github.com/apache/incubator-superset/issues/11908
thanks for reviewing btw! @etr2460
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (7ad3415) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `3.80%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
- Coverage 67.59% 63.79% -3.81%
==========================================
Files 928 462 -466
Lines 45053 28437 -16616
Branches 4309 0 -4309
==========================================
- Hits 30455 18142 -12313
+ Misses 14495 10295 -4200
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.79% <ø> (-0.28%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.98% <0.00%> (-2.97%)` | :arrow_down: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `89.25% <0.00%> (-2.81%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `72.12% <0.00%> (-2.57%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.75% <0.00%> (-1.72%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| ... and [473 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...7ad3415](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] adam-stasiak edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
adam-stasiak edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737894361
@junlincc I have a question related to searching in results:
Should X rows retrieved be showing proper value when we apply the search filter? Or just show as it is total number of rows.
During my tests it stil crashes when I set big amount of data but as it was said - it is not introduced by this PR.
@kgabryje Visual issue - while expanding data space there is a glitch. Maybe while expanding we can move also the bottom side?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-738138322
> Should X rows retrieved be showing proper value when we apply the search filter?
i thought about that, let's keep showing the #row retrieved, because the search filter result is temporary for this PR, I will get some user feedback later, if change is needed, we can address later.
> During my tests it stil crashes when I set big amount of data but as it was said - it is not introduced by this PR.
i assigned this issue to another external team member, no need to worry
> Unfortunately, the result is that a chart is visible under the Data button. @junlincc Do you think that's acceptable?
this is not ideal of course, if it takes less than a day to fix, let's fix. if more, let's open a separate issue later. there are way too many small cosmetic issues in this product, if it's not a deal breaker, we can always address separately.
@adam-stasiak @kgabryje
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (03c0c34) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `3.70%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
- Coverage 67.59% 63.88% -3.71%
==========================================
Files 928 462 -466
Lines 45053 28432 -16621
Branches 4309 0 -4309
==========================================
- Hits 30455 18165 -12290
+ Misses 14495 10267 -4228
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.88% <ø> (-0.19%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.81% <0.00%> (-7.83%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.87% <0.00%> (-1.08%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.22% <0.00%> (-0.47%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.64% <0.00%> (-0.13%)` | :arrow_down: |
| [...ntend/src/dashboard/components/PropertiesModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC5qc3g=) | | |
| [...-frontend/src/components/Select/Select.stories.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC5zdG9yaWVzLnRzeA==) | | |
| [superset-frontend/src/dashboard/util/constants.ts](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NvbnN0YW50cy50cw==) | | |
| ... and [463 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...c897e74](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (15851b4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `4.34%`.
> The diff coverage is `22.83%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
- Coverage 67.59% 63.25% -4.35%
==========================================
Files 928 932 +4
Lines 45053 45261 +208
Branches 4309 4343 +34
==========================================
- Hits 30455 28630 -1825
- Misses 14495 16454 +1959
- Partials 103 177 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.86% <22.83%> (-0.32%)` | :arrow_down: |
| python | `63.48% <ø> (-0.60%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `10.90% <ø> (-47.28%)` | :arrow_down: |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `15.87% <12.50%> (-59.13%)` | :arrow_down: |
| [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `22.22% <22.22%> (ø)` | |
| [...ontend/src/explore/components/DataTableControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVDb250cm9sLnRzeA==) | `40.62% <40.62%> (ø)` | |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `47.05% <50.00%> (-21.09%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [219 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...62bd8f4](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (4e4da81) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `13.28%`.
> The diff coverage is `62.16%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
===========================================
- Coverage 67.59% 54.31% -13.29%
===========================================
Files 928 423 -505
Lines 45053 14903 -30150
Branches 4309 3830 -479
===========================================
- Hits 30455 8095 -22360
+ Misses 14495 6808 -7687
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.31% <62.16%> (-0.59%)` | :arrow_down: |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `58.18% <ø> (ø)` | |
| [...ontend/src/explore/components/DataTableControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVDb250cm9sLnRzeA==) | `51.72% <51.72%> (ø)` | |
| [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `55.73% <55.73%> (ø)` | |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `76.19% <73.21%> (+1.19%)` | :arrow_up: |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `75.00% <100.00%> (+6.85%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| ... and [784 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...585844f](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737556135
> 2\. Let's fix that _IF_ it works in the current implementation. If not, let's file an issue and tackle that separately, so we can merge this one.
it did not work before, i agree this should not be a blocker
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (585844f) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `4.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
- Coverage 67.59% 63.58% -4.02%
==========================================
Files 928 464 -464
Lines 45053 28525 -16528
Branches 4309 0 -4309
==========================================
- Hits 30455 18138 -12317
+ Misses 14495 10387 -4108
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.58% <ø> (-0.49%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.44%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-11.69%)` | :arrow_down: |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `80.00% <0.00%> (-3.24%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.91%)` | :arrow_down: |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `79.62% <0.00%> (-0.67%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.64% <0.00%> (-0.13%)` | :arrow_down: |
| ... and [477 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...585844f](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737556135
> 2\. Let's fix that _IF_ it works in the current implementation. If not, let's file an issue and tackle that separately, so we can merge this one.
it did not work before, i agree this should not be a bloker
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#discussion_r536331077
##########
File path: superset-frontend/src/explore/components/DataTableControl.tsx
##########
@@ -0,0 +1,98 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useMemo } from 'react';
+import { styled, t } from '@superset-ui/core';
+import { FormControl } from 'react-bootstrap';
+import debounce from 'lodash/debounce';
+import Button from 'src/components/Button';
+import {
+ applyFormattingToTabularData,
+ prepareCopyToClipboardTabularData,
+} from 'src/utils/common';
+import CopyToClipboard from 'src/components/CopyToClipboard';
+import RowCountLabel from './RowCountLabel';
+
+export const CopyButton = styled(Button)`
+ font-size: ${({ theme }) => theme.typography.sizes.s}px;
+
+ // needed to override button's first-of-type margin: 0
+ && {
+ margin: 0 ${({ theme }) => theme.gridUnit * 2}px;
+ }
+
+ i {
+ padding: 0 ${({ theme }) => theme.gridUnit}px;
+ }
+`;
+
+export const CopyToClipboardButton = ({ data }: { data: object }) => (
Review comment:
I think we prefer `Record<string, any>` to object for typescript
##########
File path: superset-frontend/src/explore/components/DataTableControl.tsx
##########
@@ -0,0 +1,98 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useMemo } from 'react';
+import { styled, t } from '@superset-ui/core';
+import { FormControl } from 'react-bootstrap';
+import debounce from 'lodash/debounce';
+import Button from 'src/components/Button';
+import {
+ applyFormattingToTabularData,
+ prepareCopyToClipboardTabularData,
+} from 'src/utils/common';
+import CopyToClipboard from 'src/components/CopyToClipboard';
+import RowCountLabel from './RowCountLabel';
+
+export const CopyButton = styled(Button)`
+ font-size: ${({ theme }) => theme.typography.sizes.s}px;
+
+ // needed to override button's first-of-type margin: 0
+ && {
+ margin: 0 ${({ theme }) => theme.gridUnit * 2}px;
+ }
+
+ i {
+ padding: 0 ${({ theme }) => theme.gridUnit}px;
+ }
+`;
+
+export const CopyToClipboardButton = ({ data }: { data: object }) => (
+ <CopyToClipboard
+ text={data ? prepareCopyToClipboardTabularData(data) : ''}
+ wrapped={false}
+ copyNode={
+ <CopyButton buttonSize="xs">
+ <i className="fa fa-clipboard" />
+ </CopyButton>
+ }
+ />
+);
+
+export const FilterInput = ({
+ onChangeHandler,
+}: {
+ onChangeHandler(filterText: string): void;
+}) => {
+ const debouncedChangeHandler = debounce(onChangeHandler, 500);
+ return (
+ <FormControl
+ placeholder={t('Search')}
+ bsSize="sm"
+ onChange={(event: any) => {
+ const filterText = event.target.value;
+ debouncedChangeHandler(filterText);
+ }}
+ />
+ );
+};
+
+export const RowCount = ({ data }: { data: object[] }) => (
+ <RowCountLabel rowcount={data?.length ?? 0} suffix={t('rows retrieved')} />
+);
+
+export const useFilteredTableData = (filterText: string, data?: object[]) =>
Review comment:
same comment here about the typing of object
##########
File path: superset-frontend/src/explore/components/DataTableControl.tsx
##########
@@ -0,0 +1,98 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useMemo } from 'react';
+import { styled, t } from '@superset-ui/core';
+import { FormControl } from 'react-bootstrap';
+import debounce from 'lodash/debounce';
+import Button from 'src/components/Button';
+import {
+ applyFormattingToTabularData,
+ prepareCopyToClipboardTabularData,
+} from 'src/utils/common';
+import CopyToClipboard from 'src/components/CopyToClipboard';
+import RowCountLabel from './RowCountLabel';
+
+export const CopyButton = styled(Button)`
+ font-size: ${({ theme }) => theme.typography.sizes.s}px;
+
+ // needed to override button's first-of-type margin: 0
+ && {
+ margin: 0 ${({ theme }) => theme.gridUnit * 2}px;
+ }
+
+ i {
+ padding: 0 ${({ theme }) => theme.gridUnit}px;
+ }
+`;
+
+export const CopyToClipboardButton = ({ data }: { data: object }) => (
+ <CopyToClipboard
+ text={data ? prepareCopyToClipboardTabularData(data) : ''}
Review comment:
if data is always an object, then this check shouldn't be needed
##########
File path: superset-frontend/src/explore/components/DataTableControl.tsx
##########
@@ -0,0 +1,98 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useMemo } from 'react';
+import { styled, t } from '@superset-ui/core';
+import { FormControl } from 'react-bootstrap';
+import debounce from 'lodash/debounce';
+import Button from 'src/components/Button';
+import {
+ applyFormattingToTabularData,
+ prepareCopyToClipboardTabularData,
+} from 'src/utils/common';
+import CopyToClipboard from 'src/components/CopyToClipboard';
+import RowCountLabel from './RowCountLabel';
+
+export const CopyButton = styled(Button)`
+ font-size: ${({ theme }) => theme.typography.sizes.s}px;
+
+ // needed to override button's first-of-type margin: 0
+ && {
+ margin: 0 ${({ theme }) => theme.gridUnit * 2}px;
+ }
+
+ i {
+ padding: 0 ${({ theme }) => theme.gridUnit}px;
+ }
+`;
+
+export const CopyToClipboardButton = ({ data }: { data: object }) => (
+ <CopyToClipboard
+ text={data ? prepareCopyToClipboardTabularData(data) : ''}
+ wrapped={false}
+ copyNode={
+ <CopyButton buttonSize="xs">
+ <i className="fa fa-clipboard" />
+ </CopyButton>
+ }
+ />
+);
+
+export const FilterInput = ({
+ onChangeHandler,
+}: {
+ onChangeHandler(filterText: string): void;
+}) => {
+ const debouncedChangeHandler = debounce(onChangeHandler, 500);
+ return (
+ <FormControl
+ placeholder={t('Search')}
+ bsSize="sm"
+ onChange={(event: any) => {
+ const filterText = event.target.value;
+ debouncedChangeHandler(filterText);
+ }}
+ />
+ );
+};
+
+export const RowCount = ({ data }: { data: object[] }) => (
+ <RowCountLabel rowcount={data?.length ?? 0} suffix={t('rows retrieved')} />
+);
+
+export const useFilteredTableData = (filterText: string, data?: object[]) =>
+ useMemo(() => {
+ if (!data?.length) {
+ return [];
+ }
+ const formattedData = applyFormattingToTabularData(data);
+ return formattedData.filter((row: object) =>
Review comment:
same comment here about the typing of object
##########
File path: superset-frontend/src/explore/components/DataTableControl.tsx
##########
@@ -0,0 +1,98 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useMemo } from 'react';
+import { styled, t } from '@superset-ui/core';
+import { FormControl } from 'react-bootstrap';
+import debounce from 'lodash/debounce';
+import Button from 'src/components/Button';
+import {
+ applyFormattingToTabularData,
+ prepareCopyToClipboardTabularData,
+} from 'src/utils/common';
+import CopyToClipboard from 'src/components/CopyToClipboard';
+import RowCountLabel from './RowCountLabel';
+
+export const CopyButton = styled(Button)`
+ font-size: ${({ theme }) => theme.typography.sizes.s}px;
+
+ // needed to override button's first-of-type margin: 0
+ && {
+ margin: 0 ${({ theme }) => theme.gridUnit * 2}px;
+ }
+
+ i {
+ padding: 0 ${({ theme }) => theme.gridUnit}px;
+ }
+`;
+
+export const CopyToClipboardButton = ({ data }: { data: object }) => (
+ <CopyToClipboard
+ text={data ? prepareCopyToClipboardTabularData(data) : ''}
+ wrapped={false}
+ copyNode={
+ <CopyButton buttonSize="xs">
+ <i className="fa fa-clipboard" />
+ </CopyButton>
+ }
+ />
+);
+
+export const FilterInput = ({
+ onChangeHandler,
+}: {
+ onChangeHandler(filterText: string): void;
+}) => {
+ const debouncedChangeHandler = debounce(onChangeHandler, 500);
+ return (
+ <FormControl
+ placeholder={t('Search')}
+ bsSize="sm"
+ onChange={(event: any) => {
+ const filterText = event.target.value;
+ debouncedChangeHandler(filterText);
+ }}
+ />
+ );
+};
+
+export const RowCount = ({ data }: { data: object[] }) => (
Review comment:
same comment here about the typing of object
##########
File path: superset-frontend/src/explore/components/DataTableControl.tsx
##########
@@ -0,0 +1,98 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useMemo } from 'react';
+import { styled, t } from '@superset-ui/core';
+import { FormControl } from 'react-bootstrap';
+import debounce from 'lodash/debounce';
+import Button from 'src/components/Button';
+import {
+ applyFormattingToTabularData,
+ prepareCopyToClipboardTabularData,
+} from 'src/utils/common';
+import CopyToClipboard from 'src/components/CopyToClipboard';
+import RowCountLabel from './RowCountLabel';
+
+export const CopyButton = styled(Button)`
+ font-size: ${({ theme }) => theme.typography.sizes.s}px;
+
+ // needed to override button's first-of-type margin: 0
+ && {
+ margin: 0 ${({ theme }) => theme.gridUnit * 2}px;
+ }
+
+ i {
+ padding: 0 ${({ theme }) => theme.gridUnit}px;
+ }
+`;
+
+export const CopyToClipboardButton = ({ data }: { data: object }) => (
+ <CopyToClipboard
+ text={data ? prepareCopyToClipboardTabularData(data) : ''}
+ wrapped={false}
+ copyNode={
+ <CopyButton buttonSize="xs">
+ <i className="fa fa-clipboard" />
+ </CopyButton>
+ }
+ />
+);
+
+export const FilterInput = ({
+ onChangeHandler,
+}: {
+ onChangeHandler(filterText: string): void;
+}) => {
+ const debouncedChangeHandler = debounce(onChangeHandler, 500);
+ return (
+ <FormControl
+ placeholder={t('Search')}
+ bsSize="sm"
+ onChange={(event: any) => {
+ const filterText = event.target.value;
+ debouncedChangeHandler(filterText);
+ }}
+ />
+ );
+};
+
+export const RowCount = ({ data }: { data: object[] }) => (
+ <RowCountLabel rowcount={data?.length ?? 0} suffix={t('rows retrieved')} />
+);
+
+export const useFilteredTableData = (filterText: string, data?: object[]) =>
+ useMemo(() => {
+ if (!data?.length) {
+ return [];
+ }
+ const formattedData = applyFormattingToTabularData(data);
+ return formattedData.filter((row: object) =>
+ Object.values(row).some(value =>
+ value.toString().toLowerCase().includes(filterText.toLowerCase()),
+ ),
+ );
+ }, [data, filterText]);
+
+export const useTableColumns = (data?: object[]) =>
Review comment:
same comment here about the typing of object (i'm going to stop making these, but please clean up the rest, thanks!)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#discussion_r536301029
##########
File path: superset-frontend/src/explore/components/ExploreChartPanel.jsx
##########
@@ -49,22 +52,124 @@ const propTypes = {
triggerRender: PropTypes.bool,
};
+export const EXPLORE_GUTTER_HEIGHT = 5;
Review comment:
Maybe there's a compromise, setting the `EXPLORE_GUTTER_HEIGHT` and `EXPLORE_GUTTER_MARGIN` constants to the number of gridUnits, and then using that as the multiplier - in this case they'd both be set to `1`, I suppose. Which then raises the question of whether we need two consts or just use one unified gutter size const.
If this is all too much trouble or ruins the readability, maybe we can just change them both to `4` so they at least match the current world layout grid?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on a change in pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#discussion_r535171984
##########
File path: superset-frontend/src/explore/components/ExploreChartPanel.jsx
##########
@@ -49,22 +52,124 @@ const propTypes = {
triggerRender: PropTypes.bool,
};
+export const EXPLORE_GUTTER_HEIGHT = 5;
+export const EXPLORE_GUTTER_MARGIN = 3;
+export const CHART_PANEL_PADDING = 30;
+
+const INITIAL_SIZES = [90, 10];
+const MIN_SIZES = [300, 50];
+
const Styles = styled.div`
background-color: ${({ theme }) => theme.colors.grayscale.light5};
height: 100%;
display: flex;
flex-direction: column;
align-items: stretch;
align-content: stretch;
+ overflow: hidden;
+
& > div:last-of-type {
flex-basis: 100%;
}
+
+ .gutter {
+ border-top: 1px solid ${({ theme }) => theme.colors.grayscale.light2};
+ border-bottom: 1px solid ${({ theme }) => theme.colors.grayscale.light2};
+ width: 3%;
Review comment:
Done. I set it to gridUnit * 9, which is give or take a width that we used on full hd screens
##########
File path: superset-frontend/src/explore/components/DataTableControl.jsx
##########
@@ -0,0 +1,91 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useMemo } from 'react';
+import { styled, t } from '@superset-ui/core';
+import { FormControl } from 'react-bootstrap';
+import Button from '../../components/Button';
Review comment:
Done
##########
File path: superset-frontend/src/explore/components/DataTablesPane.jsx
##########
@@ -0,0 +1,201 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useState } from 'react';
+import PropTypes from 'prop-types';
+import { styled, t } from '@superset-ui/core';
+import {
+ CopyToClipboardButton,
+ FilterInput,
+ RowCount,
+ useFilteredTableData,
+ useTableColumns,
+} from './DataTableControl';
+import { Collapse } from '../../common/components';
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on a change in pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#discussion_r535179400
##########
File path: superset-frontend/src/explore/components/ExploreChartPanel.jsx
##########
@@ -49,22 +52,124 @@ const propTypes = {
triggerRender: PropTypes.bool,
};
+export const EXPLORE_GUTTER_HEIGHT = 5;
Review comment:
I'm not sure about that. We use `EXPLORE_GUTTER_MARGIN` both in component logic and in a styled component. In case we wanted to change its value, we'd have to remember to modify 2 places instead of 1. Unless I passed that margin value as a prop to styled component? We'd benefit from using a theme variable, but I think we'd lose some readability. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-738853449
tested in Mozilla today.
- previous cosmetic issues are addressed ✅
- white background added to the table ✅
- empty state ✅
remaining issues:
1. typing text in search seems there's delay, see gif - should address separately, confirmed that it's happening currently in master, not related to this PR
2. glitch when resizing - users will not likely resize too fast, not critical, should merge and address later
3. big data sample crash - already assigned separate issue, and prioritized, it should be fixed soon.
@etr2460 @rusackas any objections?
> @mistercrunch I noticed that on current master, we send a request for samples not only when chart data changes, but every time we open a modal. Should we consider refetching samples only when filters change as a separate feature?
if this behavior is not new, we should address it separately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (2869377) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `13.15%`.
> The diff coverage is `64.78%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
===========================================
- Coverage 67.59% 54.44% -13.16%
===========================================
Files 928 422 -506
Lines 45053 14886 -30167
Branches 4309 3822 -487
===========================================
- Hits 30455 8105 -22350
+ Misses 14495 6781 -7714
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.44% <64.78%> (-0.46%)` | :arrow_down: |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `58.18% <ø> (ø)` | |
| [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `57.62% <57.62%> (ø)` | |
| [...ontend/src/explore/components/DataTableControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVDb250cm9sLnRzeA==) | `60.00% <60.00%> (ø)` | |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `76.19% <73.21%> (+1.19%)` | :arrow_up: |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `75.00% <100.00%> (+6.85%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| ... and [782 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...7ad3415](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (4e4da81) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `12.69%`.
> The diff coverage is `62.16%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
===========================================
- Coverage 67.59% 54.90% -12.70%
===========================================
Files 928 423 -505
Lines 45053 14903 -30150
Branches 4309 3830 -479
===========================================
- Hits 30455 8182 -22273
+ Misses 14495 6721 -7774
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.90% <62.16%> (-0.01%)` | :arrow_down: |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `58.18% <ø> (ø)` | |
| [...ontend/src/explore/components/DataTableControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVDb250cm9sLnRzeA==) | `51.72% <51.72%> (ø)` | |
| [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `55.73% <55.73%> (ø)` | |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `76.19% <73.21%> (+1.19%)` | :arrow_up: |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `75.00% <100.00%> (+6.85%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| ... and [783 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...585844f](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on a change in pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#discussion_r536323528
##########
File path: superset-frontend/src/explore/components/ExploreChartPanel.jsx
##########
@@ -49,22 +52,124 @@ const propTypes = {
triggerRender: PropTypes.bool,
};
+export const EXPLORE_GUTTER_HEIGHT = 5;
Review comment:
I like this idea... but in this case 1px really does make a difference.
Here's a gutter height 4px:
And here's 5px:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (03c0c34) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `0.09%`.
> The diff coverage is `69.53%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
- Coverage 67.59% 67.50% -0.10%
==========================================
Files 928 930 +2
Lines 45053 45164 +111
Branches 4309 4319 +10
==========================================
+ Hits 30455 30486 +31
- Misses 14495 14571 +76
- Partials 103 107 +4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.35% <66.16%> (-0.55%)` | :arrow_down: |
| javascript | `62.91% <25.33%> (-0.27%)` | :arrow_down: |
| python | `64.10% <ø> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `58.18% <ø> (ø)` | |
| [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `65.15% <65.15%> (ø)` | |
| [...ontend/src/explore/components/DataTableControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVDb250cm9sLnRzeA==) | `66.66% <66.66%> (ø)` | |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `78.94% <76.00%> (+3.94%)` | :arrow_up: |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `75.00% <100.00%> (+6.85%)` | :arrow_up: |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `70.88% <0.00%> (-8.87%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `76.12% <0.00%> (-5.17%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `60.25% <0.00%> (-4.28%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `49.01% <0.00%> (-3.93%)` | :arrow_down: |
| ... and [20 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...c897e74](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
kgabryje edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737775608
@junlincc Arrow centered and text bolded
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas merged pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#discussion_r534692789
##########
File path: superset-frontend/src/explore/components/ExploreChartPanel.jsx
##########
@@ -73,67 +178,89 @@ class ExploreChartPanel extends React.PureComponent {
height > 0 && (
<ChartContainer
width={Math.floor(width)}
- height={parseInt(this.props.height, 10) - headerHeight}
+ height={chartSectionHeight}
annotationData={chart.annotationData}
chartAlert={chart.chartAlert}
chartStackTrace={chart.chartStackTrace}
chartId={chart.id}
chartStatus={chart.chartStatus}
- triggerRender={this.props.triggerRender}
- datasource={this.props.datasource}
- errorMessage={this.props.errorMessage}
- formData={this.props.form_data}
- onQuery={this.props.onQuery}
- owners={this.props?.slice?.owners}
+ triggerRender={props.triggerRender}
+ datasource={props.datasource}
+ errorMessage={props.errorMessage}
+ formData={props.form_data}
+ onQuery={props.onQuery}
+ owners={props?.slice?.owners}
queryResponse={chart.queryResponse}
- refreshOverlayVisible={this.props.refreshOverlayVisible}
- setControlValue={this.props.actions.setControlValue}
- timeout={this.props.timeout}
+ refreshOverlayVisible={props.refreshOverlayVisible}
+ setControlValue={props.actions.setControlValue}
+ timeout={props.timeout}
triggerQuery={chart.triggerQuery}
- vizType={this.props.vizType}
+ vizType={props.vizType}
/>
)
}
</ParentSize>
);
- }
+ };
- render() {
- if (this.props.standalone) {
- // dom manipulation hack to get rid of the boostrap theme's body background
- const standaloneClass = 'background-transparent';
- const bodyClasses = document.body.className.split(' ');
- if (bodyClasses.indexOf(standaloneClass) === -1) {
- document.body.className += ` ${standaloneClass}`;
- }
- return this.renderChart();
+ if (props.standalone) {
+ // dom manipulation hack to get rid of the boostrap theme's body background
+ const standaloneClass = 'background-transparent';
+ const bodyClasses = document.body.className.split(' ');
+ if (bodyClasses.indexOf(standaloneClass) === -1) {
Review comment:
OK, I admit the above suggestion, and this one, are kind of out of scope for this PR, but I'll just mention this anyway. We can potentially skip all this gross DOM and class manipulation jazz, and just use the prop to control some Emotion styles applied to the body tag with Emotions `Global` component.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on a change in pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#discussion_r535170981
##########
File path: superset-frontend/src/explore/components/DataTablesPane.jsx
##########
@@ -0,0 +1,201 @@
+/**
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
etr2460 commented on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737656285
>page does crashes when i tried to view a large sample
@junlincc is that actually current behavior in master? Is there an issue tracking it? it looks pretty serious to me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-738853449
tested in Mozilla today.
- previous cosmetic issues are addressed ✅
- white background added to the table ✅
- empty state ✅
remaining issues:
1. typing text in search seems there's delay, see gif - should address separately, may not related to this PR
2. glitch when resizing - users will not likely resize too fast, not critical, should merge and address later
3. big data sample crash - already assigned separate issue, and prioritized, it should be fixed soon.
@etr2460 @rusackas any objections?
> @mistercrunch I noticed that on current master, we send a request for samples not only when chart data changes, but every time we open a modal. Should we consider refetching samples only when filters change as a separate feature?
if this behavior is not new, we should address it separately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
kgabryje edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-738944514
@mistercrunch Shall we create a separate task for that?
@junlincc I fixed the delay in filter input. Now it waits for 500ms after user stops typing to rerender the table.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (127b259) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `4.03%`.
> The diff coverage is `25.65%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
- Coverage 67.59% 63.56% -4.04%
==========================================
Files 928 930 +2
Lines 45053 45142 +89
Branches 4309 4319 +10
==========================================
- Hits 30455 28694 -1761
- Misses 14495 16271 +1776
- Partials 103 177 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.91% <25.65%> (-0.27%)` | :arrow_down: |
| python | `63.94% <ø> (-0.13%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `10.90% <ø> (-47.28%)` | :arrow_down: |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `17.54% <14.00%> (-57.46%)` | :arrow_down: |
| [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `26.47% <26.47%> (ø)` | |
| [...ontend/src/explore/components/DataTableControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVDb250cm9sLnRzeA==) | `40.62% <40.62%> (ø)` | |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `47.05% <50.00%> (-21.09%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [190 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...c897e74](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#discussion_r534674112
##########
File path: superset-frontend/src/explore/components/DataTableControl.jsx
##########
@@ -0,0 +1,91 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useMemo } from 'react';
+import { styled, t } from '@superset-ui/core';
+import { FormControl } from 'react-bootstrap';
+import Button from '../../components/Button';
Review comment:
NIT: using `src/____/____` paths for imports (src is a webpack alias) makes it easier to shuffle these files around
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on a change in pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#discussion_r536327149
##########
File path: superset-frontend/src/explore/components/ExploreChartPanel.jsx
##########
@@ -49,22 +52,124 @@ const propTypes = {
triggerRender: PropTypes.bool,
};
+export const EXPLORE_GUTTER_HEIGHT = 5;
Review comment:
I pushed a change with `GUTTER_SIZE_FACTOR = 1.25`. Let me know what you think 🙂
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-738072989
@adam-stasiak For performance reasons, I do not update the panels's heights until dragging stops. Unfortunately, the result is that a chart is visible under the Data button. @junlincc Do you think that's acceptable?
On a side note, I removed `forceRender` from Data collapsible component. Originally I used it there so that the table renders faster after we expand, but it seems to have slowed down page rendering, which resulted in failed cypress tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on a change in pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#discussion_r535171145
##########
File path: superset-frontend/src/explore/components/ExploreChartPanel.jsx
##########
@@ -49,22 +52,124 @@ const propTypes = {
triggerRender: PropTypes.bool,
};
+export const EXPLORE_GUTTER_HEIGHT = 5;
+export const EXPLORE_GUTTER_MARGIN = 3;
+export const CHART_PANEL_PADDING = 30;
+
+const INITIAL_SIZES = [90, 10];
+const MIN_SIZES = [300, 50];
+
const Styles = styled.div`
background-color: ${({ theme }) => theme.colors.grayscale.light5};
height: 100%;
display: flex;
flex-direction: column;
align-items: stretch;
align-content: stretch;
+ overflow: hidden;
+
& > div:last-of-type {
flex-basis: 100%;
}
+
+ .gutter {
+ border-top: 1px solid ${({ theme }) => theme.colors.grayscale.light2};
+ border-bottom: 1px solid ${({ theme }) => theme.colors.grayscale.light2};
+ width: 3%;
+ margin: ${EXPLORE_GUTTER_MARGIN}px 47%;
+ }
+
+ .gutter.gutter-vertical {
+ cursor: row-resize;
+ }
+
+ .ant-collapse {
+ height: 100%;
+ background-color: ${({ theme }) => theme.colors.grayscale.light5};
+ .ant-collapse-item {
+ height: 100%;
+ border: 0;
+ }
+ .ant-collapse-content,
+ .ant-collapse-content-box {
+ height: 100%;
+ }
+ .ant-collapse-header {
+ padding-top: 0;
+ padding-bottom: 0;
+ }
+ .ant-tabs {
+ height: 100%;
+ .ant-tabs-nav {
+ padding-left: ${({ theme }) => theme.gridUnit * 5}px;
+ margin: 0;
+ background-color: ${({ theme }) => theme.colors.grayscale.light5};
+ }
+ .ant-tabs-content-holder {
+ overflow: hidden;
+ .ant-tabs-content {
+ height: 100%;
+ }
+ }
+ }
+ }
`;
-class ExploreChartPanel extends React.PureComponent {
- renderChart() {
- const { chart } = this.props;
- const headerHeight = this.props.standalone ? 0 : 80;
+const ExploreChartPanel = props => {
+ const panelHeadingRef = useRef(null);
+ const [headerHeight, setHeaderHeight] = useState(props.standalone ? 0 : 50);
+ const [splitSizes, setSplitSizes] = useState(INITIAL_SIZES);
+
+ const calcSectionHeight = percent => {
+ const containerHeight = parseInt(props.height, 10) - headerHeight - 30;
+ return (
+ (containerHeight * percent) / 100 -
+ (EXPLORE_GUTTER_HEIGHT / 2 + EXPLORE_GUTTER_MARGIN)
+ );
+ };
+
+ const [chartSectionHeight, setChartSectionHeight] = useState(
+ calcSectionHeight(INITIAL_SIZES[0]) - CHART_PANEL_PADDING,
+ );
+ const [tableSectionHeight, setTableSectionHeight] = useState(
+ calcSectionHeight(INITIAL_SIZES[1]),
+ );
+
+ useEffect(() => {
+ const calcHeaderSize = debounce(() => {
+ setHeaderHeight(
+ props.standalone ? 0 : panelHeadingRef?.current?.offsetHeight,
+ );
+ }, 100);
+ calcHeaderSize();
+ document.addEventListener('resize', calcHeaderSize);
+ return () => document.removeEventListener('resize', calcHeaderSize);
+ }, [props.standalone]);
+
+ const recalcPanelSizes = ([northPercent, southPercent]) => {
+ setChartSectionHeight(
+ calcSectionHeight(northPercent) - CHART_PANEL_PADDING,
+ );
+ setTableSectionHeight(calcSectionHeight(southPercent));
+ };
+
+ const onCollapseChange = openPanelName => {
+ const defaultSouthPaneOpenHeightPercent = 40;
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on a change in pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#discussion_r536381475
##########
File path: superset-frontend/src/explore/components/DataTableControl.tsx
##########
@@ -0,0 +1,98 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useMemo } from 'react';
+import { styled, t } from '@superset-ui/core';
+import { FormControl } from 'react-bootstrap';
+import debounce from 'lodash/debounce';
+import Button from 'src/components/Button';
+import {
+ applyFormattingToTabularData,
+ prepareCopyToClipboardTabularData,
+} from 'src/utils/common';
+import CopyToClipboard from 'src/components/CopyToClipboard';
+import RowCountLabel from './RowCountLabel';
+
+export const CopyButton = styled(Button)`
+ font-size: ${({ theme }) => theme.typography.sizes.s}px;
+
+ // needed to override button's first-of-type margin: 0
+ && {
+ margin: 0 ${({ theme }) => theme.gridUnit * 2}px;
+ }
+
+ i {
+ padding: 0 ${({ theme }) => theme.gridUnit}px;
+ }
+`;
+
+export const CopyToClipboardButton = ({ data }: { data: object }) => (
+ <CopyToClipboard
+ text={data ? prepareCopyToClipboardTabularData(data) : ''}
+ wrapped={false}
+ copyNode={
+ <CopyButton buttonSize="xs">
+ <i className="fa fa-clipboard" />
+ </CopyButton>
+ }
+ />
+);
+
+export const FilterInput = ({
+ onChangeHandler,
+}: {
+ onChangeHandler(filterText: string): void;
+}) => {
+ const debouncedChangeHandler = debounce(onChangeHandler, 500);
+ return (
+ <FormControl
+ placeholder={t('Search')}
+ bsSize="sm"
+ onChange={(event: any) => {
+ const filterText = event.target.value;
+ debouncedChangeHandler(filterText);
+ }}
+ />
+ );
+};
+
+export const RowCount = ({ data }: { data: object[] }) => (
+ <RowCountLabel rowcount={data?.length ?? 0} suffix={t('rows retrieved')} />
+);
+
+export const useFilteredTableData = (filterText: string, data?: object[]) =>
+ useMemo(() => {
+ if (!data?.length) {
+ return [];
+ }
+ const formattedData = applyFormattingToTabularData(data);
+ return formattedData.filter((row: object) =>
+ Object.values(row).some(value =>
+ value.toString().toLowerCase().includes(filterText.toLowerCase()),
+ ),
+ );
+ }, [data, filterText]);
+
+export const useTableColumns = (data?: object[]) =>
Review comment:
Got it! Thanks for pointing that out. Fixed here and in other types
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-738853449
tested in Mozilla today.
- previous cosmetic issues are addressed ✅
- white background added to the table ✅
- empty state ✅
remaining issues:
1. typing text in search seems there's delay, see gif - should address separately, may not related to this PR
2. glitch when resizing - users will not likely resize too fast, not critical, should merge and address later
3. big data sample crash - already assigned separate issue, and prioritized, it should be fixed soon.
@etr2460 any objections?
> @mistercrunch I noticed that on current master, we send a request for samples not only when chart data changes, but every time we open a modal. Should we consider refetching samples only when filters change as a separate feature?
if this behavior is not new, we should address it separately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-738853449
tested in Mozilla today.
- previous cosmetic issues are addressed ✅
- white background added to the table ✅
- empty state ✅
remaining issues:
1. typing text in search seems there's delay, see gif - should address separately, confirmed that it's happening currently in master, not related to this PR
2. glitch when resizing - users will not likely resize too fast, not critical, should merge and address later
3. big data sample crash - already assigned separate issue, and prioritized, it should be fixed soon.
@etr2460 @rusackas any objections?
> @mistercrunch I noticed that on current master, we send a request for samples not only when chart data changes, but every time we open a modal. Should we consider refetching samples only when filters change as a separate feature?
if this behavior is not new, we should address it separately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (15851b4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `4.73%`.
> The diff coverage is `22.83%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
- Coverage 67.59% 62.86% -4.74%
==========================================
Files 928 470 -458
Lines 45053 16780 -28273
Branches 4309 4343 +34
==========================================
- Hits 30455 10549 -19906
+ Misses 14495 6054 -8441
- Partials 103 177 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.86% <22.83%> (-0.32%)` | :arrow_down: |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `10.90% <ø> (-47.28%)` | :arrow_down: |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `15.87% <12.50%> (-59.13%)` | :arrow_down: |
| [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `22.22% <22.22%> (ø)` | |
| [...ontend/src/explore/components/DataTableControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVDb250cm9sLnRzeA==) | `40.62% <40.62%> (ø)` | |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `47.05% <50.00%> (-21.09%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [643 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...62bd8f4](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (62bd8f4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `4.29%`.
> The diff coverage is `22.02%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
- Coverage 67.59% 63.30% -4.30%
==========================================
Files 928 934 +6
Lines 45053 45321 +268
Branches 4309 4345 +36
==========================================
- Hits 30455 28690 -1765
- Misses 14495 16454 +1959
- Partials 103 177 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.82% <22.02%> (-0.36%)` | :arrow_down: |
| python | `63.58% <ø> (-0.49%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `10.90% <ø> (-47.28%)` | :arrow_down: |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `13.63% <10.16%> (-61.37%)` | :arrow_down: |
| [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `22.85% <22.85%> (ø)` | |
| [...ontend/src/explore/components/DataTableControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVDb250cm9sLnRzeA==) | `37.83% <37.83%> (ø)` | |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `47.05% <50.00%> (-21.09%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [206 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...585844f](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11854: feat: Results table on Explore view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11854:
URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737953446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=h1) Report
> Merging [#11854](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=desc) (62bd8f4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `4.02%`.
> The diff coverage is `22.02%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11854 +/- ##
==========================================
- Coverage 67.59% 63.57% -4.03%
==========================================
Files 928 934 +6
Lines 45053 45321 +268
Branches 4309 4345 +36
==========================================
- Hits 30455 28812 -1643
- Misses 14495 16332 +1837
- Partials 103 177 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.82% <22.02%> (-0.36%)` | :arrow_down: |
| python | `64.01% <ø> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `10.90% <ø> (-47.28%)` | :arrow_down: |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `13.63% <10.16%> (-61.37%)` | :arrow_down: |
| [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `22.85% <22.85%> (ø)` | |
| [...ontend/src/explore/components/DataTableControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVDb250cm9sLnRzeA==) | `37.83% <37.83%> (ø)` | |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `47.05% <50.00%> (-21.09%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [204 more](https://codecov.io/gh/apache/incubator-superset/pull/11854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=footer). Last update [8c063ef...585844f](https://codecov.io/gh/apache/incubator-superset/pull/11854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org