[GitHub] [pulsar] eolivelli commented on a change in pull request #9532: [Broker] Async read entries with max size bytes

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #9532:
URL: https://github.com/apache/pulsar/pull/9532#discussion_r573071408



##########
File path: managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedCursorTest.java
##########
@@ -463,6 +463,42 @@ public void readEntriesFailed(ManagedLedgerException exception, Object ctx) {
         counter.await();
     }
 
+    @Test(timeOut = 20000)
+    void testAsyncReadWithMaxSizeByte() throws Exception {
+        ManagedLedger ledger = factory.open("testAsyncReadWithMaxSizeByte");
+        ManagedCursor cursor = ledger.openCursor("c1");

Review comment:
       we aren't closing this resources.
   Do you think we can add @Cleanup annotations in this file in all of the tests ?
   
   (not blocker for me)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org