You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/06/02 11:38:17 UTC

[GitHub] [kafka] feyman2016 commented on pull request #10593: KAFKA-10800 Validate the snapshot id when the state machine creates a snapshot

feyman2016 commented on pull request #10593:
URL: https://github.com/apache/kafka/pull/10593#issuecomment-852954180


   > > Are there any concerns with multi-threading here? I think the answer is "no". Any thoughts @feyman2016 or @jsancio?
   > 
   > Good point. There may be some concurrency issue with `createSnapshot`. How about moving the validation to `onSnapshotFrozen`?
   > 
   > This conversation also reminded me to create this issue: https://issues.apache.org/jira/browse/KAFKA-12873. It is slightly related to this point.
   
   @jsancio Can you share more details about the possible concurrency scenario with `createSnapshot `? BTW, will moving  the validation to `onSnapshotFrozen` imply that before creating the snapshot, there's no validation? I think maybe we can keep the validation here and add some additional check before `freeze()` which makes the snapshot visible? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org