You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by Philippe Mouawad <ph...@gmail.com> on 2015/01/24 16:30:24 UTC
Release 2.13 ?
Hello,
It appears 2.12 suffers from an OOM in GUI mode :
- https://issues.apache.org/bugzilla/show_bug.cgi?id=57440
This OOM seems to be due to RSyntaxTexarea bug:
- https://github.com/bobbylight/RSyntaxTextArea/issues/99
It appeared after the rework of LoggerPanel#processEvent way of appending
event.
Now that it receivs log event even when closed this OOM has more chances to
appear.
I reverted to 2.11 way of appending events to fix OOM waiting for answer
from rsyntaxtarea project.
There was also a bug in the way limit=0 was set that had no effect, I fixed
it as part of the bug.
There is a workaround which is to set:
- jmeter.loggerpanel.enable_when_closed=false
But if user opens panel, OOM will occur if lot of logs occur (specially if
stacktraces).
If we release, it cannot be named 2.12.1 because we have some "big?"
features in this versions so it would not be a minor one.
Regarding the frequency and impact of this bug, in our company I had 2
reports in 5 days of this OOM so I think it is not to be ignored.
Thoughts ?
--
Regards.
Philippe
@philmdot
Re: Release 2.13 ?
Posted by Andrey Pokhilko <ap...@ya.ru>.
+1
I see no reasons not to do it.
--
Andrey Pokhilko
On 01/24/2015 06:30 PM, Philippe Mouawad wrote:
> Hello,
> It appears 2.12 suffers from an OOM in GUI mode :
>
> - https://issues.apache.org/bugzilla/show_bug.cgi?id=57440
>
> This OOM seems to be due to RSyntaxTexarea bug:
>
> - https://github.com/bobbylight/RSyntaxTextArea/issues/99
>
> It appeared after the rework of LoggerPanel#processEvent way of appending
> event.
>
> Now that it receivs log event even when closed this OOM has more chances to
> appear.
>
> I reverted to 2.11 way of appending events to fix OOM waiting for answer
> from rsyntaxtarea project.
>
> There was also a bug in the way limit=0 was set that had no effect, I fixed
> it as part of the bug.
>
> There is a workaround which is to set:
>
> - jmeter.loggerpanel.enable_when_closed=false
>
> But if user opens panel, OOM will occur if lot of logs occur (specially if
> stacktraces).
>
> If we release, it cannot be named 2.12.1 because we have some "big?"
> features in this versions so it would not be a minor one.
>
> Regarding the frequency and impact of this bug, in our company I had 2
> reports in 5 days of this OOM so I think it is not to be ignored.
>
>
> Thoughts ?
>
Re: Release 2.13 ?
Posted by Milamber <mi...@apache.org>.
On 01/03/2015 19:13, Philippe Mouawad wrote:
> Hi,
> I am writing a doc on Graphite Backend listener. I have nearly finished it.
> I may make some changes to implementation to add a small feature or change
> slightly some behaviour like:
> - We don't compute response time metrics for KO samplers but it may be
> interesting to have it
> - we don't compute threads per thread group
>
> I will try to add it this evening unless you absolutely want to release
> this evening.
No, I will delay the release for next Tuesday (3rd, evening). (That also
suits me :-))
Milamber
>
> Regards
> On Thursday, February 26, 2015, Milamber <mi...@apache.org> wrote:
>
>> It is not necessary to vote to start a new release. Just start a
>> discussion for make a new release, and if nobody put a veto (missing
>> fixes, wait for a new behavior to commit, etc.) the release process can
>> be start.
>>
>> Thus if everybody are ok, I can start the release process, as the RM,
>> next Sunday (1st march).
>>
>> The re-ordering of the contents in changes page seems a good thing too.
>>
>> Milamber
>>
>>
>> On 26/02/2015 07:58, Похилько Андрей wrote:
>>> +1
>>>
>>> I also have fixed connect time measurements, it was not operational, now
>> it works.
>>> 26.02.2015, 09:24, "Felix Schumacher" <felix.schumacher@internetallee.de
>> <javascript:;>>:
>>>> Am 19. Februar 2015 23:53:28 MEZ, schrieb Philippe Mouawad <
>> philippe.mouawad@gmail.com <javascript:;>>:
>>>>> Hi,
>>>>> I fixed what seemed urgent, remaining work (html report) will require
>>>>> much
>>>>> more time.
>>>>> So if we want to release we could start.
>>>> +1
>>>>> Regarding changes.xml I suggest to change order:
>>>>> - New and noteworthy
>>>>> - Improvements
>>>>> - Bugs
>>>>> - Thanks
>>>>> - Known issues
>>>>>
>>>>> As when you read them today, you see bugs before while enhancement are
>>>>> usually what makes a product nice.
>>>>> Known bugs are at the begining, I find personnaly that it may give a
>>>>> bad
>>>>> idea of jmeter while almost all of them are due to jdk bugs on some
>>>>> systems.
>>>> +1
>>>>
>>>> Regards
>>>> Felix
>>>>> Regards
>>>>>
>>>>> On Friday, January 30, 2015, Philippe Mouawad
>>>>> <philippe.mouawad@gmail.com <javascript:;>>
>>>>> wrote:
>>>>>> Thanks Andrey,
>>>>>> If possible we should fix this one before:
>>>>>> - https://issues.apache.org/bugzilla/show_bug.cgi?id=57514
>>>>>>
>>>>>> And I intend to commit a BackendListener client implementation
>>>>> related to
>>>>>> reporting.
>>>>>> See a thread I will start.
>>>>>>
>>>>>> Regards
>>>>>>
>>>>>> On Fri, Jan 30, 2015 at 12:10 PM, Andrey Pokhilko <apc4@ya.ru
>> <javascript:;>
>>>>>> <javascript:_e(%7B%7D,'cvml','apc4@ya.ru <javascript:;>');>> wrote:
>>>>>>> I have committed remote retry feature into trunk. Now I have no more
>>>>>>> reasons to delay 2.13 release. Instead, I support it to be out as
>>>>> soon
>>>>>>> as it is possible.
>>>>>>>
>>>>>>> Andrey Pokhilko
>>>>>>>
>>>>>>> On 01/25/2015 07:02 PM, Philippe Mouawad wrote:
>>>>>>>> +1 for inclusion (will reconsider once PR is available :-) )
>>>>>>>> Regards
>>>>>>>>
>>>>>>>> On Sunday, January 25, 2015, Andrey Pokhilko <apc4@ya.ru
>> <javascript:;>
>>>>>>> <javascript:_e(%7B%7D,'cvml','apc4@ya.ru <javascript:;>');>> wrote:
>>>>>>>>> Ah, I forgot one thing that I wanted to commit in 2.13: remote
>>>>> retry
>>>>>>>>> feature.
>>>>>>>>>
>>>>>>>>> It is needed when you run distributed test with tens of slaves
>>>>> and some
>>>>>>>>> of them fail because of network glitches or other reasons.
>>>>>>>>>
>>>>>>>>> May I do that before starting release process for 2.13? As usual,
>>>>> I'll
>>>>>>>>> show it as GitHub PR first for easy review, and there will be
>>>>> bugzilla
>>>>>>>>> with explanation.
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Andrey Pokhilko
>>>>>>>>>
>>>>>>>>> On 01/25/2015 05:11 PM, Milamber wrote:
>>>>>>>>>> Hello,
>>>>>>>>>>
>>>>>>>>>> +1 for me to release a 2.13 version. (I can act as RM)
>>>>>>>>>> +1 too for a new property to disable RSTA on Logger panel before
>>>>> the
>>>>>>> new
>>>>>>>>>> release.
>>>>>>>>>>
>>>>>>>>>> Milamber
>>>>>>>>>>
>>>>>>>>>> On 25/01/2015 00:20, sebb wrote:
>>>>>>>>>>> OK to name it 2.13 and to release it.
>>>>>>>>>>>
>>>>>>>>>>> Given that there have been some issues with using
>>>>> RSyntaxTextArea, I
>>>>>>>>>>> wonder whether what it provides for the LoggerPanel is worth
>>>>> the
>>>>>>>>>>> potential disadvantages.
>>>>>>>>>>>
>>>>>>>>>>> I have just had a look at the display, and I'm not sure it
>>>>> provides
>>>>>>>>>>> much apart from line numbering..
>>>>>>>>>>>
>>>>>>>>>>> I can see that RSTA is beneficial for the GUI fields, but these
>>>>> are
>>>>>>>>>>> generally quite small, whereas the logging panel can grow
>>>>> without
>>>>>>>>>>> bound.
>>>>>>>>>>>
>>>>>>>>>>> At the moment the user has no choice as to whether to use it.
>>>>>>>>>>>
>>>>>>>>>>> Rather than release 2.13 and hope that the issues have been
>>>>> solved, I
>>>>>>>>>>> think it would be better to at least provide the option to
>>>>> disable
>>>>>>>>>>> RSTA for the LoggerPanel. This could be done with a property.
>>>>>>>>>>>
>>>>>>>>>>> At least then there would be a work round if RSTA proves
>>>>> problematic.
>>>>>>>>>>> On 24 January 2015 at 19:56, Felix Schumacher
>>>>>>>>>>> <felix.schumacher@internetallee.de <javascript:;>
>>>>>>> <javascript:_e(%7B%7D,'cvml','felix.schumacher@internetallee.de
>> <javascript:;>');>
>>>>>>> <javascript:;>> wrote:
>>>>>>>>>>>> Am 24.01.2015 um 16:30 schrieb Philippe Mouawad:
>>>>>>>>>>>>> Hello,
>>>>>>>>>>>>> It appears 2.12 suffers from an OOM in GUI mode :
>>>>>>>>>>>>>
>>>>>>>>>>>>> -
>>>>> https://issues.apache.org/bugzilla/show_bug.cgi?id=57440
>>>>>>>>>>>>> This OOM seems to be due to RSyntaxTexarea bug:
>>>>>>>>>>>>>
>>>>>>>>>>>>> - https://github.com/bobbylight/RSyntaxTextArea/issues/99
>>>>>>>>>>>>>
>>>>>>>>>>>>> It appeared after the rework of LoggerPanel#processEvent way
>>>>> of
>>>>>>>>> appending
>>>>>>>>>>>>> event.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Now that it receivs log event even when closed this OOM has
>>>>> more
>>>>>>>>> chances
>>>>>>>>>>>>> to
>>>>>>>>>>>>> appear.
>>>>>>>>>>>>>
>>>>>>>>>>>>> I reverted to 2.11 way of appending events to fix OOM waiting
>>>>> for
>>>>>>>>> answer
>>>>>>>>>>>>> from rsyntaxtarea project.
>>>>>>>>>>>>>
>>>>>>>>>>>>> There was also a bug in the way limit=0 was set that had no
>>>>>>> effect, I
>>>>>>>>>>>>> fixed
>>>>>>>>>>>>> it as part of the bug.
>>>>>>>>>>>>>
>>>>>>>>>>>>> There is a workaround which is to set:
>>>>>>>>>>>>>
>>>>>>>>>>>>> - jmeter.loggerpanel.enable_when_closed=false
>>>>>>>>>>>>>
>>>>>>>>>>>>> But if user opens panel, OOM will occur if lot of logs occur
>>>>>>>>> (specially if
>>>>>>>>>>>>> stacktraces).
>>>>>>>>>>>>>
>>>>>>>>>>>>> If we release, it cannot be named 2.12.1 because we have some
>>>>>>> "big?"
>>>>>>>>>>>>> features in this versions so it would not be a minor one.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Regarding the frequency and impact of this bug, in our
>>>>> company I
>>>>>>> had 2
>>>>>>>>>>>>> reports in 5 days of this OOM so I think it is not to be
>>>>> ignored.
>>>>>>>>>>>>> Thoughts ?
>>>>>>>>>>>> +1 to release 2.13. I don't think a we should go for 2.x.y.
>>>>>>>>>>>>
>>>>>>>>>>>> Regards
>>>>>>>>>>>> Felix
>>>>>> --
>>>>>> Cordialement.
>>>>>> Philippe Mouawad.
>>
Re: Release 2.13 ?
Posted by Philippe Mouawad <ph...@gmail.com>.
Hi,
I am writing a doc on Graphite Backend listener. I have nearly finished it.
I may make some changes to implementation to add a small feature or change
slightly some behaviour like:
- We don't compute response time metrics for KO samplers but it may be
interesting to have it
- we don't compute threads per thread group
I will try to add it this evening unless you absolutely want to release
this evening.
Regards
On Thursday, February 26, 2015, Milamber <mi...@apache.org> wrote:
>
> It is not necessary to vote to start a new release. Just start a
> discussion for make a new release, and if nobody put a veto (missing
> fixes, wait for a new behavior to commit, etc.) the release process can
> be start.
>
> Thus if everybody are ok, I can start the release process, as the RM,
> next Sunday (1st march).
>
> The re-ordering of the contents in changes page seems a good thing too.
>
> Milamber
>
>
> On 26/02/2015 07:58, Похилько Андрей wrote:
> > +1
> >
> > I also have fixed connect time measurements, it was not operational, now
> it works.
> >
> > 26.02.2015, 09:24, "Felix Schumacher" <felix.schumacher@internetallee.de
> <javascript:;>>:
> >> Am 19. Februar 2015 23:53:28 MEZ, schrieb Philippe Mouawad <
> philippe.mouawad@gmail.com <javascript:;>>:
> >>> Hi,
> >>> I fixed what seemed urgent, remaining work (html report) will require
> >>> much
> >>> more time.
> >>> So if we want to release we could start.
> >> +1
> >>> Regarding changes.xml I suggest to change order:
> >>> - New and noteworthy
> >>> - Improvements
> >>> - Bugs
> >>> - Thanks
> >>> - Known issues
> >>>
> >>> As when you read them today, you see bugs before while enhancement are
> >>> usually what makes a product nice.
> >>> Known bugs are at the begining, I find personnaly that it may give a
> >>> bad
> >>> idea of jmeter while almost all of them are due to jdk bugs on some
> >>> systems.
> >> +1
> >>
> >> Regards
> >> Felix
> >>> Regards
> >>>
> >>> On Friday, January 30, 2015, Philippe Mouawad
> >>> <philippe.mouawad@gmail.com <javascript:;>>
> >>> wrote:
> >>>> Thanks Andrey,
> >>>> If possible we should fix this one before:
> >>>> - https://issues.apache.org/bugzilla/show_bug.cgi?id=57514
> >>>>
> >>>> And I intend to commit a BackendListener client implementation
> >>> related to
> >>>> reporting.
> >>>> See a thread I will start.
> >>>>
> >>>> Regards
> >>>>
> >>>> On Fri, Jan 30, 2015 at 12:10 PM, Andrey Pokhilko <apc4@ya.ru
> <javascript:;>
> >>>> <javascript:_e(%7B%7D,'cvml','apc4@ya.ru <javascript:;>');>> wrote:
> >>>>> I have committed remote retry feature into trunk. Now I have no more
> >>>>> reasons to delay 2.13 release. Instead, I support it to be out as
> >>> soon
> >>>>> as it is possible.
> >>>>>
> >>>>> Andrey Pokhilko
> >>>>>
> >>>>> On 01/25/2015 07:02 PM, Philippe Mouawad wrote:
> >>>>>> +1 for inclusion (will reconsider once PR is available :-) )
> >>>>>> Regards
> >>>>>>
> >>>>>> On Sunday, January 25, 2015, Andrey Pokhilko <apc4@ya.ru
> <javascript:;>
> >>>>> <javascript:_e(%7B%7D,'cvml','apc4@ya.ru <javascript:;>');>> wrote:
> >>>>>>> Ah, I forgot one thing that I wanted to commit in 2.13: remote
> >>> retry
> >>>>>>> feature.
> >>>>>>>
> >>>>>>> It is needed when you run distributed test with tens of slaves
> >>> and some
> >>>>>>> of them fail because of network glitches or other reasons.
> >>>>>>>
> >>>>>>> May I do that before starting release process for 2.13? As usual,
> >>> I'll
> >>>>>>> show it as GitHub PR first for easy review, and there will be
> >>> bugzilla
> >>>>>>> with explanation.
> >>>>>>>
> >>>>>>> --
> >>>>>>> Andrey Pokhilko
> >>>>>>>
> >>>>>>> On 01/25/2015 05:11 PM, Milamber wrote:
> >>>>>>>> Hello,
> >>>>>>>>
> >>>>>>>> +1 for me to release a 2.13 version. (I can act as RM)
> >>>>>>>> +1 too for a new property to disable RSTA on Logger panel before
> >>> the
> >>>>> new
> >>>>>>>> release.
> >>>>>>>>
> >>>>>>>> Milamber
> >>>>>>>>
> >>>>>>>> On 25/01/2015 00:20, sebb wrote:
> >>>>>>>>> OK to name it 2.13 and to release it.
> >>>>>>>>>
> >>>>>>>>> Given that there have been some issues with using
> >>> RSyntaxTextArea, I
> >>>>>>>>> wonder whether what it provides for the LoggerPanel is worth
> >>> the
> >>>>>>>>> potential disadvantages.
> >>>>>>>>>
> >>>>>>>>> I have just had a look at the display, and I'm not sure it
> >>> provides
> >>>>>>>>> much apart from line numbering..
> >>>>>>>>>
> >>>>>>>>> I can see that RSTA is beneficial for the GUI fields, but these
> >>> are
> >>>>>>>>> generally quite small, whereas the logging panel can grow
> >>> without
> >>>>>>>>> bound.
> >>>>>>>>>
> >>>>>>>>> At the moment the user has no choice as to whether to use it.
> >>>>>>>>>
> >>>>>>>>> Rather than release 2.13 and hope that the issues have been
> >>> solved, I
> >>>>>>>>> think it would be better to at least provide the option to
> >>> disable
> >>>>>>>>> RSTA for the LoggerPanel. This could be done with a property.
> >>>>>>>>>
> >>>>>>>>> At least then there would be a work round if RSTA proves
> >>> problematic.
> >>>>>>>>> On 24 January 2015 at 19:56, Felix Schumacher
> >>>>>>>>> <felix.schumacher@internetallee.de <javascript:;>
> >>>>> <javascript:_e(%7B%7D,'cvml','felix.schumacher@internetallee.de
> <javascript:;>');>
> >>>>> <javascript:;>> wrote:
> >>>>>>>>>> Am 24.01.2015 um 16:30 schrieb Philippe Mouawad:
> >>>>>>>>>>> Hello,
> >>>>>>>>>>> It appears 2.12 suffers from an OOM in GUI mode :
> >>>>>>>>>>>
> >>>>>>>>>>> -
> >>> https://issues.apache.org/bugzilla/show_bug.cgi?id=57440
> >>>>>>>>>>> This OOM seems to be due to RSyntaxTexarea bug:
> >>>>>>>>>>>
> >>>>>>>>>>> - https://github.com/bobbylight/RSyntaxTextArea/issues/99
> >>>>>>>>>>>
> >>>>>>>>>>> It appeared after the rework of LoggerPanel#processEvent way
> >>> of
> >>>>>>> appending
> >>>>>>>>>>> event.
> >>>>>>>>>>>
> >>>>>>>>>>> Now that it receivs log event even when closed this OOM has
> >>> more
> >>>>>>> chances
> >>>>>>>>>>> to
> >>>>>>>>>>> appear.
> >>>>>>>>>>>
> >>>>>>>>>>> I reverted to 2.11 way of appending events to fix OOM waiting
> >>> for
> >>>>>>> answer
> >>>>>>>>>>> from rsyntaxtarea project.
> >>>>>>>>>>>
> >>>>>>>>>>> There was also a bug in the way limit=0 was set that had no
> >>>>> effect, I
> >>>>>>>>>>> fixed
> >>>>>>>>>>> it as part of the bug.
> >>>>>>>>>>>
> >>>>>>>>>>> There is a workaround which is to set:
> >>>>>>>>>>>
> >>>>>>>>>>> - jmeter.loggerpanel.enable_when_closed=false
> >>>>>>>>>>>
> >>>>>>>>>>> But if user opens panel, OOM will occur if lot of logs occur
> >>>>>>> (specially if
> >>>>>>>>>>> stacktraces).
> >>>>>>>>>>>
> >>>>>>>>>>> If we release, it cannot be named 2.12.1 because we have some
> >>>>> "big?"
> >>>>>>>>>>> features in this versions so it would not be a minor one.
> >>>>>>>>>>>
> >>>>>>>>>>> Regarding the frequency and impact of this bug, in our
> >>> company I
> >>>>> had 2
> >>>>>>>>>>> reports in 5 days of this OOM so I think it is not to be
> >>> ignored.
> >>>>>>>>>>> Thoughts ?
> >>>>>>>>>> +1 to release 2.13. I don't think a we should go for 2.x.y.
> >>>>>>>>>>
> >>>>>>>>>> Regards
> >>>>>>>>>> Felix
> >>>> --
> >>>> Cordialement.
> >>>> Philippe Mouawad.
>
>
--
Cordialement.
Philippe Mouawad.
Re: Release 2.13 ?
Posted by Milamber <mi...@apache.org>.
It is not necessary to vote to start a new release. Just start a
discussion for make a new release, and if nobody put a veto (missing
fixes, wait for a new behavior to commit, etc.) the release process can
be start.
Thus if everybody are ok, I can start the release process, as the RM,
next Sunday (1st march).
The re-ordering of the contents in changes page seems a good thing too.
Milamber
On 26/02/2015 07:58, Похилько Андрей wrote:
> +1
>
> I also have fixed connect time measurements, it was not operational, now it works.
>
> 26.02.2015, 09:24, "Felix Schumacher" <fe...@internetallee.de>:
>> Am 19. Februar 2015 23:53:28 MEZ, schrieb Philippe Mouawad <ph...@gmail.com>:
>>> Hi,
>>> I fixed what seemed urgent, remaining work (html report) will require
>>> much
>>> more time.
>>> So if we want to release we could start.
>> +1
>>> Regarding changes.xml I suggest to change order:
>>> - New and noteworthy
>>> - Improvements
>>> - Bugs
>>> - Thanks
>>> - Known issues
>>>
>>> As when you read them today, you see bugs before while enhancement are
>>> usually what makes a product nice.
>>> Known bugs are at the begining, I find personnaly that it may give a
>>> bad
>>> idea of jmeter while almost all of them are due to jdk bugs on some
>>> systems.
>> +1
>>
>> Regards
>> Felix
>>> Regards
>>>
>>> On Friday, January 30, 2015, Philippe Mouawad
>>> <ph...@gmail.com>
>>> wrote:
>>>> Thanks Andrey,
>>>> If possible we should fix this one before:
>>>> - https://issues.apache.org/bugzilla/show_bug.cgi?id=57514
>>>>
>>>> And I intend to commit a BackendListener client implementation
>>> related to
>>>> reporting.
>>>> See a thread I will start.
>>>>
>>>> Regards
>>>>
>>>> On Fri, Jan 30, 2015 at 12:10 PM, Andrey Pokhilko <apc4@ya.ru
>>>> <javascript:_e(%7B%7D,'cvml','apc4@ya.ru');>> wrote:
>>>>> I have committed remote retry feature into trunk. Now I have no more
>>>>> reasons to delay 2.13 release. Instead, I support it to be out as
>>> soon
>>>>> as it is possible.
>>>>>
>>>>> Andrey Pokhilko
>>>>>
>>>>> On 01/25/2015 07:02 PM, Philippe Mouawad wrote:
>>>>>> +1 for inclusion (will reconsider once PR is available :-) )
>>>>>> Regards
>>>>>>
>>>>>> On Sunday, January 25, 2015, Andrey Pokhilko <apc4@ya.ru
>>>>> <javascript:_e(%7B%7D,'cvml','apc4@ya.ru');>> wrote:
>>>>>>> Ah, I forgot one thing that I wanted to commit in 2.13: remote
>>> retry
>>>>>>> feature.
>>>>>>>
>>>>>>> It is needed when you run distributed test with tens of slaves
>>> and some
>>>>>>> of them fail because of network glitches or other reasons.
>>>>>>>
>>>>>>> May I do that before starting release process for 2.13? As usual,
>>> I'll
>>>>>>> show it as GitHub PR first for easy review, and there will be
>>> bugzilla
>>>>>>> with explanation.
>>>>>>>
>>>>>>> --
>>>>>>> Andrey Pokhilko
>>>>>>>
>>>>>>> On 01/25/2015 05:11 PM, Milamber wrote:
>>>>>>>> Hello,
>>>>>>>>
>>>>>>>> +1 for me to release a 2.13 version. (I can act as RM)
>>>>>>>> +1 too for a new property to disable RSTA on Logger panel before
>>> the
>>>>> new
>>>>>>>> release.
>>>>>>>>
>>>>>>>> Milamber
>>>>>>>>
>>>>>>>> On 25/01/2015 00:20, sebb wrote:
>>>>>>>>> OK to name it 2.13 and to release it.
>>>>>>>>>
>>>>>>>>> Given that there have been some issues with using
>>> RSyntaxTextArea, I
>>>>>>>>> wonder whether what it provides for the LoggerPanel is worth
>>> the
>>>>>>>>> potential disadvantages.
>>>>>>>>>
>>>>>>>>> I have just had a look at the display, and I'm not sure it
>>> provides
>>>>>>>>> much apart from line numbering..
>>>>>>>>>
>>>>>>>>> I can see that RSTA is beneficial for the GUI fields, but these
>>> are
>>>>>>>>> generally quite small, whereas the logging panel can grow
>>> without
>>>>>>>>> bound.
>>>>>>>>>
>>>>>>>>> At the moment the user has no choice as to whether to use it.
>>>>>>>>>
>>>>>>>>> Rather than release 2.13 and hope that the issues have been
>>> solved, I
>>>>>>>>> think it would be better to at least provide the option to
>>> disable
>>>>>>>>> RSTA for the LoggerPanel. This could be done with a property.
>>>>>>>>>
>>>>>>>>> At least then there would be a work round if RSTA proves
>>> problematic.
>>>>>>>>> On 24 January 2015 at 19:56, Felix Schumacher
>>>>>>>>> <felix.schumacher@internetallee.de
>>>>> <javascript:_e(%7B%7D,'cvml','felix.schumacher@internetallee.de');>
>>>>> <javascript:;>> wrote:
>>>>>>>>>> Am 24.01.2015 um 16:30 schrieb Philippe Mouawad:
>>>>>>>>>>> Hello,
>>>>>>>>>>> It appears 2.12 suffers from an OOM in GUI mode :
>>>>>>>>>>>
>>>>>>>>>>> -
>>> https://issues.apache.org/bugzilla/show_bug.cgi?id=57440
>>>>>>>>>>> This OOM seems to be due to RSyntaxTexarea bug:
>>>>>>>>>>>
>>>>>>>>>>> - https://github.com/bobbylight/RSyntaxTextArea/issues/99
>>>>>>>>>>>
>>>>>>>>>>> It appeared after the rework of LoggerPanel#processEvent way
>>> of
>>>>>>> appending
>>>>>>>>>>> event.
>>>>>>>>>>>
>>>>>>>>>>> Now that it receivs log event even when closed this OOM has
>>> more
>>>>>>> chances
>>>>>>>>>>> to
>>>>>>>>>>> appear.
>>>>>>>>>>>
>>>>>>>>>>> I reverted to 2.11 way of appending events to fix OOM waiting
>>> for
>>>>>>> answer
>>>>>>>>>>> from rsyntaxtarea project.
>>>>>>>>>>>
>>>>>>>>>>> There was also a bug in the way limit=0 was set that had no
>>>>> effect, I
>>>>>>>>>>> fixed
>>>>>>>>>>> it as part of the bug.
>>>>>>>>>>>
>>>>>>>>>>> There is a workaround which is to set:
>>>>>>>>>>>
>>>>>>>>>>> - jmeter.loggerpanel.enable_when_closed=false
>>>>>>>>>>>
>>>>>>>>>>> But if user opens panel, OOM will occur if lot of logs occur
>>>>>>> (specially if
>>>>>>>>>>> stacktraces).
>>>>>>>>>>>
>>>>>>>>>>> If we release, it cannot be named 2.12.1 because we have some
>>>>> "big?"
>>>>>>>>>>> features in this versions so it would not be a minor one.
>>>>>>>>>>>
>>>>>>>>>>> Regarding the frequency and impact of this bug, in our
>>> company I
>>>>> had 2
>>>>>>>>>>> reports in 5 days of this OOM so I think it is not to be
>>> ignored.
>>>>>>>>>>> Thoughts ?
>>>>>>>>>> +1 to release 2.13. I don't think a we should go for 2.x.y.
>>>>>>>>>>
>>>>>>>>>> Regards
>>>>>>>>>> Felix
>>>> --
>>>> Cordialement.
>>>> Philippe Mouawad.
Re: Release 2.13 ?
Posted by Похилько Андрей <ap...@ya.ru>.
+1
I also have fixed connect time measurements, it was not operational, now it works.
26.02.2015, 09:24, "Felix Schumacher" <fe...@internetallee.de>:
> Am 19. Februar 2015 23:53:28 MEZ, schrieb Philippe Mouawad <ph...@gmail.com>:
>> Hi,
>> I fixed what seemed urgent, remaining work (html report) will require
>> much
>> more time.
>> So if we want to release we could start.
>
> +1
>> Regarding changes.xml I suggest to change order:
>> - New and noteworthy
>> - Improvements
>> - Bugs
>> - Thanks
>> - Known issues
>>
>> As when you read them today, you see bugs before while enhancement are
>> usually what makes a product nice.
>> Known bugs are at the begining, I find personnaly that it may give a
>> bad
>> idea of jmeter while almost all of them are due to jdk bugs on some
>> systems.
>
> +1
>
> Regards
> Felix
>> Regards
>>
>> On Friday, January 30, 2015, Philippe Mouawad
>> <ph...@gmail.com>
>> wrote:
>>> Thanks Andrey,
>>> If possible we should fix this one before:
>>> - https://issues.apache.org/bugzilla/show_bug.cgi?id=57514
>>>
>>> And I intend to commit a BackendListener client implementation
>> related to
>>> reporting.
>>> See a thread I will start.
>>>
>>> Regards
>>>
>>> On Fri, Jan 30, 2015 at 12:10 PM, Andrey Pokhilko <apc4@ya.ru
>>> <javascript:_e(%7B%7D,'cvml','apc4@ya.ru');>> wrote:
>>>> I have committed remote retry feature into trunk. Now I have no more
>>>> reasons to delay 2.13 release. Instead, I support it to be out as
>> soon
>>>> as it is possible.
>>>>
>>>> Andrey Pokhilko
>>>>
>>>> On 01/25/2015 07:02 PM, Philippe Mouawad wrote:
>>>>> +1 for inclusion (will reconsider once PR is available :-) )
>>>>> Regards
>>>>>
>>>>> On Sunday, January 25, 2015, Andrey Pokhilko <apc4@ya.ru
>>>> <javascript:_e(%7B%7D,'cvml','apc4@ya.ru');>> wrote:
>>>>>> Ah, I forgot one thing that I wanted to commit in 2.13: remote
>> retry
>>>>>> feature.
>>>>>>
>>>>>> It is needed when you run distributed test with tens of slaves
>> and some
>>>>>> of them fail because of network glitches or other reasons.
>>>>>>
>>>>>> May I do that before starting release process for 2.13? As usual,
>> I'll
>>>>>> show it as GitHub PR first for easy review, and there will be
>> bugzilla
>>>>>> with explanation.
>>>>>>
>>>>>> --
>>>>>> Andrey Pokhilko
>>>>>>
>>>>>> On 01/25/2015 05:11 PM, Milamber wrote:
>>>>>>> Hello,
>>>>>>>
>>>>>>> +1 for me to release a 2.13 version. (I can act as RM)
>>>>>>> +1 too for a new property to disable RSTA on Logger panel before
>> the
>>>> new
>>>>>>> release.
>>>>>>>
>>>>>>> Milamber
>>>>>>>
>>>>>>> On 25/01/2015 00:20, sebb wrote:
>>>>>>>> OK to name it 2.13 and to release it.
>>>>>>>>
>>>>>>>> Given that there have been some issues with using
>> RSyntaxTextArea, I
>>>>>>>> wonder whether what it provides for the LoggerPanel is worth
>> the
>>>>>>>> potential disadvantages.
>>>>>>>>
>>>>>>>> I have just had a look at the display, and I'm not sure it
>> provides
>>>>>>>> much apart from line numbering..
>>>>>>>>
>>>>>>>> I can see that RSTA is beneficial for the GUI fields, but these
>> are
>>>>>>>> generally quite small, whereas the logging panel can grow
>> without
>>>>>>>> bound.
>>>>>>>>
>>>>>>>> At the moment the user has no choice as to whether to use it.
>>>>>>>>
>>>>>>>> Rather than release 2.13 and hope that the issues have been
>> solved, I
>>>>>>>> think it would be better to at least provide the option to
>> disable
>>>>>>>> RSTA for the LoggerPanel. This could be done with a property.
>>>>>>>>
>>>>>>>> At least then there would be a work round if RSTA proves
>> problematic.
>>>>>>>> On 24 January 2015 at 19:56, Felix Schumacher
>>>>>>>> <felix.schumacher@internetallee.de
>>>> <javascript:_e(%7B%7D,'cvml','felix.schumacher@internetallee.de');>
>>>> <javascript:;>> wrote:
>>>>>>>>> Am 24.01.2015 um 16:30 schrieb Philippe Mouawad:
>>>>>>>>>> Hello,
>>>>>>>>>> It appears 2.12 suffers from an OOM in GUI mode :
>>>>>>>>>>
>>>>>>>>>> -
>> https://issues.apache.org/bugzilla/show_bug.cgi?id=57440
>>>>>>>>>> This OOM seems to be due to RSyntaxTexarea bug:
>>>>>>>>>>
>>>>>>>>>> - https://github.com/bobbylight/RSyntaxTextArea/issues/99
>>>>>>>>>>
>>>>>>>>>> It appeared after the rework of LoggerPanel#processEvent way
>> of
>>>>>> appending
>>>>>>>>>> event.
>>>>>>>>>>
>>>>>>>>>> Now that it receivs log event even when closed this OOM has
>> more
>>>>>> chances
>>>>>>>>>> to
>>>>>>>>>> appear.
>>>>>>>>>>
>>>>>>>>>> I reverted to 2.11 way of appending events to fix OOM waiting
>> for
>>>>>> answer
>>>>>>>>>> from rsyntaxtarea project.
>>>>>>>>>>
>>>>>>>>>> There was also a bug in the way limit=0 was set that had no
>>>> effect, I
>>>>>>>>>> fixed
>>>>>>>>>> it as part of the bug.
>>>>>>>>>>
>>>>>>>>>> There is a workaround which is to set:
>>>>>>>>>>
>>>>>>>>>> - jmeter.loggerpanel.enable_when_closed=false
>>>>>>>>>>
>>>>>>>>>> But if user opens panel, OOM will occur if lot of logs occur
>>>>>> (specially if
>>>>>>>>>> stacktraces).
>>>>>>>>>>
>>>>>>>>>> If we release, it cannot be named 2.12.1 because we have some
>>>> "big?"
>>>>>>>>>> features in this versions so it would not be a minor one.
>>>>>>>>>>
>>>>>>>>>> Regarding the frequency and impact of this bug, in our
>> company I
>>>> had 2
>>>>>>>>>> reports in 5 days of this OOM so I think it is not to be
>> ignored.
>>>>>>>>>> Thoughts ?
>>>>>>>>> +1 to release 2.13. I don't think a we should go for 2.x.y.
>>>>>>>>>
>>>>>>>>> Regards
>>>>>>>>> Felix
>>> --
>>> Cordialement.
>>> Philippe Mouawad.
Re: Release 2.13 ?
Posted by Felix Schumacher <fe...@internetallee.de>.
Am 19. Februar 2015 23:53:28 MEZ, schrieb Philippe Mouawad <ph...@gmail.com>:
>Hi,
>I fixed what seemed urgent, remaining work (html report) will require
>much
>more time.
>So if we want to release we could start.
+1
>
>Regarding changes.xml I suggest to change order:
>- New and noteworthy
>- Improvements
>- Bugs
>- Thanks
>- Known issues
>
>As when you read them today, you see bugs before while enhancement are
>usually what makes a product nice.
>Known bugs are at the begining, I find personnaly that it may give a
>bad
>idea of jmeter while almost all of them are due to jdk bugs on some
>systems.
+1
Regards
Felix
>
>Regards
>
>
>
>On Friday, January 30, 2015, Philippe Mouawad
><ph...@gmail.com>
>wrote:
>
>> Thanks Andrey,
>> If possible we should fix this one before:
>> - https://issues.apache.org/bugzilla/show_bug.cgi?id=57514
>>
>> And I intend to commit a BackendListener client implementation
>related to
>> reporting.
>> See a thread I will start.
>>
>> Regards
>>
>> On Fri, Jan 30, 2015 at 12:10 PM, Andrey Pokhilko <apc4@ya.ru
>> <javascript:_e(%7B%7D,'cvml','apc4@ya.ru');>> wrote:
>>
>>> I have committed remote retry feature into trunk. Now I have no more
>>> reasons to delay 2.13 release. Instead, I support it to be out as
>soon
>>> as it is possible.
>>>
>>> Andrey Pokhilko
>>>
>>> On 01/25/2015 07:02 PM, Philippe Mouawad wrote:
>>> > +1 for inclusion (will reconsider once PR is available :-) )
>>> > Regards
>>> >
>>> > On Sunday, January 25, 2015, Andrey Pokhilko <apc4@ya.ru
>>> <javascript:_e(%7B%7D,'cvml','apc4@ya.ru');>> wrote:
>>> >
>>> >> Ah, I forgot one thing that I wanted to commit in 2.13: remote
>retry
>>> >> feature.
>>> >>
>>> >> It is needed when you run distributed test with tens of slaves
>and some
>>> >> of them fail because of network glitches or other reasons.
>>> >>
>>> >> May I do that before starting release process for 2.13? As usual,
>I'll
>>> >> show it as GitHub PR first for easy review, and there will be
>bugzilla
>>> >> with explanation.
>>> >>
>>> >> --
>>> >> Andrey Pokhilko
>>> >>
>>> >> On 01/25/2015 05:11 PM, Milamber wrote:
>>> >>> Hello,
>>> >>>
>>> >>> +1 for me to release a 2.13 version. (I can act as RM)
>>> >>> +1 too for a new property to disable RSTA on Logger panel before
>the
>>> new
>>> >>> release.
>>> >>>
>>> >>> Milamber
>>> >>>
>>> >>> On 25/01/2015 00:20, sebb wrote:
>>> >>>> OK to name it 2.13 and to release it.
>>> >>>>
>>> >>>> Given that there have been some issues with using
>RSyntaxTextArea, I
>>> >>>> wonder whether what it provides for the LoggerPanel is worth
>the
>>> >>>> potential disadvantages.
>>> >>>>
>>> >>>> I have just had a look at the display, and I'm not sure it
>provides
>>> >>>> much apart from line numbering..
>>> >>>>
>>> >>>> I can see that RSTA is beneficial for the GUI fields, but these
>are
>>> >>>> generally quite small, whereas the logging panel can grow
>without
>>> >>>> bound.
>>> >>>>
>>> >>>> At the moment the user has no choice as to whether to use it.
>>> >>>>
>>> >>>> Rather than release 2.13 and hope that the issues have been
>solved, I
>>> >>>> think it would be better to at least provide the option to
>disable
>>> >>>> RSTA for the LoggerPanel. This could be done with a property.
>>> >>>>
>>> >>>> At least then there would be a work round if RSTA proves
>problematic.
>>> >>>>
>>> >>>> On 24 January 2015 at 19:56, Felix Schumacher
>>> >>>> <felix.schumacher@internetallee.de
>>> <javascript:_e(%7B%7D,'cvml','felix.schumacher@internetallee.de');>
>>> <javascript:;>> wrote:
>>> >>>>> Am 24.01.2015 um 16:30 schrieb Philippe Mouawad:
>>> >>>>>
>>> >>>>>> Hello,
>>> >>>>>> It appears 2.12 suffers from an OOM in GUI mode :
>>> >>>>>>
>>> >>>>>> -
>https://issues.apache.org/bugzilla/show_bug.cgi?id=57440
>>> >>>>>>
>>> >>>>>> This OOM seems to be due to RSyntaxTexarea bug:
>>> >>>>>>
>>> >>>>>> - https://github.com/bobbylight/RSyntaxTextArea/issues/99
>>> >>>>>>
>>> >>>>>> It appeared after the rework of LoggerPanel#processEvent way
>of
>>> >> appending
>>> >>>>>> event.
>>> >>>>>>
>>> >>>>>> Now that it receivs log event even when closed this OOM has
>more
>>> >> chances
>>> >>>>>> to
>>> >>>>>> appear.
>>> >>>>>>
>>> >>>>>> I reverted to 2.11 way of appending events to fix OOM waiting
>for
>>> >> answer
>>> >>>>>> from rsyntaxtarea project.
>>> >>>>>>
>>> >>>>>> There was also a bug in the way limit=0 was set that had no
>>> effect, I
>>> >>>>>> fixed
>>> >>>>>> it as part of the bug.
>>> >>>>>>
>>> >>>>>> There is a workaround which is to set:
>>> >>>>>>
>>> >>>>>> - jmeter.loggerpanel.enable_when_closed=false
>>> >>>>>>
>>> >>>>>> But if user opens panel, OOM will occur if lot of logs occur
>>> >> (specially if
>>> >>>>>> stacktraces).
>>> >>>>>>
>>> >>>>>> If we release, it cannot be named 2.12.1 because we have some
>>> "big?"
>>> >>>>>> features in this versions so it would not be a minor one.
>>> >>>>>>
>>> >>>>>> Regarding the frequency and impact of this bug, in our
>company I
>>> had 2
>>> >>>>>> reports in 5 days of this OOM so I think it is not to be
>ignored.
>>> >>>>>>
>>> >>>>>>
>>> >>>>>> Thoughts ?
>>> >>>>>>
>>> >>>>> +1 to release 2.13. I don't think a we should go for 2.x.y.
>>> >>>>>
>>> >>>>> Regards
>>> >>>>> Felix
>>> >>
>>>
>>>
>>
>>
>> --
>> Cordialement.
>> Philippe Mouawad.
>>
>>
>>
Re: Release 2.13 ?
Posted by Philippe Mouawad <ph...@gmail.com>.
Hi,
I fixed what seemed urgent, remaining work (html report) will require much
more time.
So if we want to release we could start.
Regarding changes.xml I suggest to change order:
- New and noteworthy
- Improvements
- Bugs
- Thanks
- Known issues
As when you read them today, you see bugs before while enhancement are
usually what makes a product nice.
Known bugs are at the begining, I find personnaly that it may give a bad
idea of jmeter while almost all of them are due to jdk bugs on some systems.
Regards
On Friday, January 30, 2015, Philippe Mouawad <ph...@gmail.com>
wrote:
> Thanks Andrey,
> If possible we should fix this one before:
> - https://issues.apache.org/bugzilla/show_bug.cgi?id=57514
>
> And I intend to commit a BackendListener client implementation related to
> reporting.
> See a thread I will start.
>
> Regards
>
> On Fri, Jan 30, 2015 at 12:10 PM, Andrey Pokhilko <apc4@ya.ru
> <javascript:_e(%7B%7D,'cvml','apc4@ya.ru');>> wrote:
>
>> I have committed remote retry feature into trunk. Now I have no more
>> reasons to delay 2.13 release. Instead, I support it to be out as soon
>> as it is possible.
>>
>> Andrey Pokhilko
>>
>> On 01/25/2015 07:02 PM, Philippe Mouawad wrote:
>> > +1 for inclusion (will reconsider once PR is available :-) )
>> > Regards
>> >
>> > On Sunday, January 25, 2015, Andrey Pokhilko <apc4@ya.ru
>> <javascript:_e(%7B%7D,'cvml','apc4@ya.ru');>> wrote:
>> >
>> >> Ah, I forgot one thing that I wanted to commit in 2.13: remote retry
>> >> feature.
>> >>
>> >> It is needed when you run distributed test with tens of slaves and some
>> >> of them fail because of network glitches or other reasons.
>> >>
>> >> May I do that before starting release process for 2.13? As usual, I'll
>> >> show it as GitHub PR first for easy review, and there will be bugzilla
>> >> with explanation.
>> >>
>> >> --
>> >> Andrey Pokhilko
>> >>
>> >> On 01/25/2015 05:11 PM, Milamber wrote:
>> >>> Hello,
>> >>>
>> >>> +1 for me to release a 2.13 version. (I can act as RM)
>> >>> +1 too for a new property to disable RSTA on Logger panel before the
>> new
>> >>> release.
>> >>>
>> >>> Milamber
>> >>>
>> >>> On 25/01/2015 00:20, sebb wrote:
>> >>>> OK to name it 2.13 and to release it.
>> >>>>
>> >>>> Given that there have been some issues with using RSyntaxTextArea, I
>> >>>> wonder whether what it provides for the LoggerPanel is worth the
>> >>>> potential disadvantages.
>> >>>>
>> >>>> I have just had a look at the display, and I'm not sure it provides
>> >>>> much apart from line numbering..
>> >>>>
>> >>>> I can see that RSTA is beneficial for the GUI fields, but these are
>> >>>> generally quite small, whereas the logging panel can grow without
>> >>>> bound.
>> >>>>
>> >>>> At the moment the user has no choice as to whether to use it.
>> >>>>
>> >>>> Rather than release 2.13 and hope that the issues have been solved, I
>> >>>> think it would be better to at least provide the option to disable
>> >>>> RSTA for the LoggerPanel. This could be done with a property.
>> >>>>
>> >>>> At least then there would be a work round if RSTA proves problematic.
>> >>>>
>> >>>> On 24 January 2015 at 19:56, Felix Schumacher
>> >>>> <felix.schumacher@internetallee.de
>> <javascript:_e(%7B%7D,'cvml','felix.schumacher@internetallee.de');>
>> <javascript:;>> wrote:
>> >>>>> Am 24.01.2015 um 16:30 schrieb Philippe Mouawad:
>> >>>>>
>> >>>>>> Hello,
>> >>>>>> It appears 2.12 suffers from an OOM in GUI mode :
>> >>>>>>
>> >>>>>> - https://issues.apache.org/bugzilla/show_bug.cgi?id=57440
>> >>>>>>
>> >>>>>> This OOM seems to be due to RSyntaxTexarea bug:
>> >>>>>>
>> >>>>>> - https://github.com/bobbylight/RSyntaxTextArea/issues/99
>> >>>>>>
>> >>>>>> It appeared after the rework of LoggerPanel#processEvent way of
>> >> appending
>> >>>>>> event.
>> >>>>>>
>> >>>>>> Now that it receivs log event even when closed this OOM has more
>> >> chances
>> >>>>>> to
>> >>>>>> appear.
>> >>>>>>
>> >>>>>> I reverted to 2.11 way of appending events to fix OOM waiting for
>> >> answer
>> >>>>>> from rsyntaxtarea project.
>> >>>>>>
>> >>>>>> There was also a bug in the way limit=0 was set that had no
>> effect, I
>> >>>>>> fixed
>> >>>>>> it as part of the bug.
>> >>>>>>
>> >>>>>> There is a workaround which is to set:
>> >>>>>>
>> >>>>>> - jmeter.loggerpanel.enable_when_closed=false
>> >>>>>>
>> >>>>>> But if user opens panel, OOM will occur if lot of logs occur
>> >> (specially if
>> >>>>>> stacktraces).
>> >>>>>>
>> >>>>>> If we release, it cannot be named 2.12.1 because we have some
>> "big?"
>> >>>>>> features in this versions so it would not be a minor one.
>> >>>>>>
>> >>>>>> Regarding the frequency and impact of this bug, in our company I
>> had 2
>> >>>>>> reports in 5 days of this OOM so I think it is not to be ignored.
>> >>>>>>
>> >>>>>>
>> >>>>>> Thoughts ?
>> >>>>>>
>> >>>>> +1 to release 2.13. I don't think a we should go for 2.x.y.
>> >>>>>
>> >>>>> Regards
>> >>>>> Felix
>> >>
>>
>>
>
>
> --
> Cordialement.
> Philippe Mouawad.
>
>
>
--
Cordialement.
Philippe Mouawad.
Re: Release 2.13 ?
Posted by Philippe Mouawad <ph...@gmail.com>.
Thanks Andrey,
If possible we should fix this one before:
- https://issues.apache.org/bugzilla/show_bug.cgi?id=57514
And I intend to commit a BackendListener client implementation related to
reporting.
See a thread I will start.
Regards
On Fri, Jan 30, 2015 at 12:10 PM, Andrey Pokhilko <ap...@ya.ru> wrote:
> I have committed remote retry feature into trunk. Now I have no more
> reasons to delay 2.13 release. Instead, I support it to be out as soon
> as it is possible.
>
> Andrey Pokhilko
>
> On 01/25/2015 07:02 PM, Philippe Mouawad wrote:
> > +1 for inclusion (will reconsider once PR is available :-) )
> > Regards
> >
> > On Sunday, January 25, 2015, Andrey Pokhilko <ap...@ya.ru> wrote:
> >
> >> Ah, I forgot one thing that I wanted to commit in 2.13: remote retry
> >> feature.
> >>
> >> It is needed when you run distributed test with tens of slaves and some
> >> of them fail because of network glitches or other reasons.
> >>
> >> May I do that before starting release process for 2.13? As usual, I'll
> >> show it as GitHub PR first for easy review, and there will be bugzilla
> >> with explanation.
> >>
> >> --
> >> Andrey Pokhilko
> >>
> >> On 01/25/2015 05:11 PM, Milamber wrote:
> >>> Hello,
> >>>
> >>> +1 for me to release a 2.13 version. (I can act as RM)
> >>> +1 too for a new property to disable RSTA on Logger panel before the
> new
> >>> release.
> >>>
> >>> Milamber
> >>>
> >>> On 25/01/2015 00:20, sebb wrote:
> >>>> OK to name it 2.13 and to release it.
> >>>>
> >>>> Given that there have been some issues with using RSyntaxTextArea, I
> >>>> wonder whether what it provides for the LoggerPanel is worth the
> >>>> potential disadvantages.
> >>>>
> >>>> I have just had a look at the display, and I'm not sure it provides
> >>>> much apart from line numbering..
> >>>>
> >>>> I can see that RSTA is beneficial for the GUI fields, but these are
> >>>> generally quite small, whereas the logging panel can grow without
> >>>> bound.
> >>>>
> >>>> At the moment the user has no choice as to whether to use it.
> >>>>
> >>>> Rather than release 2.13 and hope that the issues have been solved, I
> >>>> think it would be better to at least provide the option to disable
> >>>> RSTA for the LoggerPanel. This could be done with a property.
> >>>>
> >>>> At least then there would be a work round if RSTA proves problematic.
> >>>>
> >>>> On 24 January 2015 at 19:56, Felix Schumacher
> >>>> <felix.schumacher@internetallee.de <javascript:;>> wrote:
> >>>>> Am 24.01.2015 um 16:30 schrieb Philippe Mouawad:
> >>>>>
> >>>>>> Hello,
> >>>>>> It appears 2.12 suffers from an OOM in GUI mode :
> >>>>>>
> >>>>>> - https://issues.apache.org/bugzilla/show_bug.cgi?id=57440
> >>>>>>
> >>>>>> This OOM seems to be due to RSyntaxTexarea bug:
> >>>>>>
> >>>>>> - https://github.com/bobbylight/RSyntaxTextArea/issues/99
> >>>>>>
> >>>>>> It appeared after the rework of LoggerPanel#processEvent way of
> >> appending
> >>>>>> event.
> >>>>>>
> >>>>>> Now that it receivs log event even when closed this OOM has more
> >> chances
> >>>>>> to
> >>>>>> appear.
> >>>>>>
> >>>>>> I reverted to 2.11 way of appending events to fix OOM waiting for
> >> answer
> >>>>>> from rsyntaxtarea project.
> >>>>>>
> >>>>>> There was also a bug in the way limit=0 was set that had no effect,
> I
> >>>>>> fixed
> >>>>>> it as part of the bug.
> >>>>>>
> >>>>>> There is a workaround which is to set:
> >>>>>>
> >>>>>> - jmeter.loggerpanel.enable_when_closed=false
> >>>>>>
> >>>>>> But if user opens panel, OOM will occur if lot of logs occur
> >> (specially if
> >>>>>> stacktraces).
> >>>>>>
> >>>>>> If we release, it cannot be named 2.12.1 because we have some "big?"
> >>>>>> features in this versions so it would not be a minor one.
> >>>>>>
> >>>>>> Regarding the frequency and impact of this bug, in our company I
> had 2
> >>>>>> reports in 5 days of this OOM so I think it is not to be ignored.
> >>>>>>
> >>>>>>
> >>>>>> Thoughts ?
> >>>>>>
> >>>>> +1 to release 2.13. I don't think a we should go for 2.x.y.
> >>>>>
> >>>>> Regards
> >>>>> Felix
> >>
>
>
--
Cordialement.
Philippe Mouawad.
Re: Release 2.13 ?
Posted by Andrey Pokhilko <ap...@ya.ru>.
I have committed remote retry feature into trunk. Now I have no more
reasons to delay 2.13 release. Instead, I support it to be out as soon
as it is possible.
Andrey Pokhilko
On 01/25/2015 07:02 PM, Philippe Mouawad wrote:
> +1 for inclusion (will reconsider once PR is available :-) )
> Regards
>
> On Sunday, January 25, 2015, Andrey Pokhilko <ap...@ya.ru> wrote:
>
>> Ah, I forgot one thing that I wanted to commit in 2.13: remote retry
>> feature.
>>
>> It is needed when you run distributed test with tens of slaves and some
>> of them fail because of network glitches or other reasons.
>>
>> May I do that before starting release process for 2.13? As usual, I'll
>> show it as GitHub PR first for easy review, and there will be bugzilla
>> with explanation.
>>
>> --
>> Andrey Pokhilko
>>
>> On 01/25/2015 05:11 PM, Milamber wrote:
>>> Hello,
>>>
>>> +1 for me to release a 2.13 version. (I can act as RM)
>>> +1 too for a new property to disable RSTA on Logger panel before the new
>>> release.
>>>
>>> Milamber
>>>
>>> On 25/01/2015 00:20, sebb wrote:
>>>> OK to name it 2.13 and to release it.
>>>>
>>>> Given that there have been some issues with using RSyntaxTextArea, I
>>>> wonder whether what it provides for the LoggerPanel is worth the
>>>> potential disadvantages.
>>>>
>>>> I have just had a look at the display, and I'm not sure it provides
>>>> much apart from line numbering..
>>>>
>>>> I can see that RSTA is beneficial for the GUI fields, but these are
>>>> generally quite small, whereas the logging panel can grow without
>>>> bound.
>>>>
>>>> At the moment the user has no choice as to whether to use it.
>>>>
>>>> Rather than release 2.13 and hope that the issues have been solved, I
>>>> think it would be better to at least provide the option to disable
>>>> RSTA for the LoggerPanel. This could be done with a property.
>>>>
>>>> At least then there would be a work round if RSTA proves problematic.
>>>>
>>>> On 24 January 2015 at 19:56, Felix Schumacher
>>>> <felix.schumacher@internetallee.de <javascript:;>> wrote:
>>>>> Am 24.01.2015 um 16:30 schrieb Philippe Mouawad:
>>>>>
>>>>>> Hello,
>>>>>> It appears 2.12 suffers from an OOM in GUI mode :
>>>>>>
>>>>>> - https://issues.apache.org/bugzilla/show_bug.cgi?id=57440
>>>>>>
>>>>>> This OOM seems to be due to RSyntaxTexarea bug:
>>>>>>
>>>>>> - https://github.com/bobbylight/RSyntaxTextArea/issues/99
>>>>>>
>>>>>> It appeared after the rework of LoggerPanel#processEvent way of
>> appending
>>>>>> event.
>>>>>>
>>>>>> Now that it receivs log event even when closed this OOM has more
>> chances
>>>>>> to
>>>>>> appear.
>>>>>>
>>>>>> I reverted to 2.11 way of appending events to fix OOM waiting for
>> answer
>>>>>> from rsyntaxtarea project.
>>>>>>
>>>>>> There was also a bug in the way limit=0 was set that had no effect, I
>>>>>> fixed
>>>>>> it as part of the bug.
>>>>>>
>>>>>> There is a workaround which is to set:
>>>>>>
>>>>>> - jmeter.loggerpanel.enable_when_closed=false
>>>>>>
>>>>>> But if user opens panel, OOM will occur if lot of logs occur
>> (specially if
>>>>>> stacktraces).
>>>>>>
>>>>>> If we release, it cannot be named 2.12.1 because we have some "big?"
>>>>>> features in this versions so it would not be a minor one.
>>>>>>
>>>>>> Regarding the frequency and impact of this bug, in our company I had 2
>>>>>> reports in 5 days of this OOM so I think it is not to be ignored.
>>>>>>
>>>>>>
>>>>>> Thoughts ?
>>>>>>
>>>>> +1 to release 2.13. I don't think a we should go for 2.x.y.
>>>>>
>>>>> Regards
>>>>> Felix
>>
Re: Release 2.13 ?
Posted by Philippe Mouawad <ph...@gmail.com>.
+1 for inclusion (will reconsider once PR is available :-) )
Regards
On Sunday, January 25, 2015, Andrey Pokhilko <ap...@ya.ru> wrote:
> Ah, I forgot one thing that I wanted to commit in 2.13: remote retry
> feature.
>
> It is needed when you run distributed test with tens of slaves and some
> of them fail because of network glitches or other reasons.
>
> May I do that before starting release process for 2.13? As usual, I'll
> show it as GitHub PR first for easy review, and there will be bugzilla
> with explanation.
>
> --
> Andrey Pokhilko
>
> On 01/25/2015 05:11 PM, Milamber wrote:
> > Hello,
> >
> > +1 for me to release a 2.13 version. (I can act as RM)
> > +1 too for a new property to disable RSTA on Logger panel before the new
> > release.
> >
> > Milamber
> >
> > On 25/01/2015 00:20, sebb wrote:
> >> OK to name it 2.13 and to release it.
> >>
> >> Given that there have been some issues with using RSyntaxTextArea, I
> >> wonder whether what it provides for the LoggerPanel is worth the
> >> potential disadvantages.
> >>
> >> I have just had a look at the display, and I'm not sure it provides
> >> much apart from line numbering..
> >>
> >> I can see that RSTA is beneficial for the GUI fields, but these are
> >> generally quite small, whereas the logging panel can grow without
> >> bound.
> >>
> >> At the moment the user has no choice as to whether to use it.
> >>
> >> Rather than release 2.13 and hope that the issues have been solved, I
> >> think it would be better to at least provide the option to disable
> >> RSTA for the LoggerPanel. This could be done with a property.
> >>
> >> At least then there would be a work round if RSTA proves problematic.
> >>
> >> On 24 January 2015 at 19:56, Felix Schumacher
> >> <felix.schumacher@internetallee.de <javascript:;>> wrote:
> >>> Am 24.01.2015 um 16:30 schrieb Philippe Mouawad:
> >>>
> >>>> Hello,
> >>>> It appears 2.12 suffers from an OOM in GUI mode :
> >>>>
> >>>> - https://issues.apache.org/bugzilla/show_bug.cgi?id=57440
> >>>>
> >>>> This OOM seems to be due to RSyntaxTexarea bug:
> >>>>
> >>>> - https://github.com/bobbylight/RSyntaxTextArea/issues/99
> >>>>
> >>>> It appeared after the rework of LoggerPanel#processEvent way of
> appending
> >>>> event.
> >>>>
> >>>> Now that it receivs log event even when closed this OOM has more
> chances
> >>>> to
> >>>> appear.
> >>>>
> >>>> I reverted to 2.11 way of appending events to fix OOM waiting for
> answer
> >>>> from rsyntaxtarea project.
> >>>>
> >>>> There was also a bug in the way limit=0 was set that had no effect, I
> >>>> fixed
> >>>> it as part of the bug.
> >>>>
> >>>> There is a workaround which is to set:
> >>>>
> >>>> - jmeter.loggerpanel.enable_when_closed=false
> >>>>
> >>>> But if user opens panel, OOM will occur if lot of logs occur
> (specially if
> >>>> stacktraces).
> >>>>
> >>>> If we release, it cannot be named 2.12.1 because we have some "big?"
> >>>> features in this versions so it would not be a minor one.
> >>>>
> >>>> Regarding the frequency and impact of this bug, in our company I had 2
> >>>> reports in 5 days of this OOM so I think it is not to be ignored.
> >>>>
> >>>>
> >>>> Thoughts ?
> >>>>
> >>> +1 to release 2.13. I don't think a we should go for 2.x.y.
> >>>
> >>> Regards
> >>> Felix
>
>
--
Cordialement.
Philippe Mouawad.
Re: Release 2.13 ?
Posted by Andrey Pokhilko <ap...@ya.ru>.
Ah, I forgot one thing that I wanted to commit in 2.13: remote retry
feature.
It is needed when you run distributed test with tens of slaves and some
of them fail because of network glitches or other reasons.
May I do that before starting release process for 2.13? As usual, I'll
show it as GitHub PR first for easy review, and there will be bugzilla
with explanation.
--
Andrey Pokhilko
On 01/25/2015 05:11 PM, Milamber wrote:
> Hello,
>
> +1 for me to release a 2.13 version. (I can act as RM)
> +1 too for a new property to disable RSTA on Logger panel before the new
> release.
>
> Milamber
>
> On 25/01/2015 00:20, sebb wrote:
>> OK to name it 2.13 and to release it.
>>
>> Given that there have been some issues with using RSyntaxTextArea, I
>> wonder whether what it provides for the LoggerPanel is worth the
>> potential disadvantages.
>>
>> I have just had a look at the display, and I'm not sure it provides
>> much apart from line numbering..
>>
>> I can see that RSTA is beneficial for the GUI fields, but these are
>> generally quite small, whereas the logging panel can grow without
>> bound.
>>
>> At the moment the user has no choice as to whether to use it.
>>
>> Rather than release 2.13 and hope that the issues have been solved, I
>> think it would be better to at least provide the option to disable
>> RSTA for the LoggerPanel. This could be done with a property.
>>
>> At least then there would be a work round if RSTA proves problematic.
>>
>> On 24 January 2015 at 19:56, Felix Schumacher
>> <fe...@internetallee.de> wrote:
>>> Am 24.01.2015 um 16:30 schrieb Philippe Mouawad:
>>>
>>>> Hello,
>>>> It appears 2.12 suffers from an OOM in GUI mode :
>>>>
>>>> - https://issues.apache.org/bugzilla/show_bug.cgi?id=57440
>>>>
>>>> This OOM seems to be due to RSyntaxTexarea bug:
>>>>
>>>> - https://github.com/bobbylight/RSyntaxTextArea/issues/99
>>>>
>>>> It appeared after the rework of LoggerPanel#processEvent way of appending
>>>> event.
>>>>
>>>> Now that it receivs log event even when closed this OOM has more chances
>>>> to
>>>> appear.
>>>>
>>>> I reverted to 2.11 way of appending events to fix OOM waiting for answer
>>>> from rsyntaxtarea project.
>>>>
>>>> There was also a bug in the way limit=0 was set that had no effect, I
>>>> fixed
>>>> it as part of the bug.
>>>>
>>>> There is a workaround which is to set:
>>>>
>>>> - jmeter.loggerpanel.enable_when_closed=false
>>>>
>>>> But if user opens panel, OOM will occur if lot of logs occur (specially if
>>>> stacktraces).
>>>>
>>>> If we release, it cannot be named 2.12.1 because we have some "big?"
>>>> features in this versions so it would not be a minor one.
>>>>
>>>> Regarding the frequency and impact of this bug, in our company I had 2
>>>> reports in 5 days of this OOM so I think it is not to be ignored.
>>>>
>>>>
>>>> Thoughts ?
>>>>
>>> +1 to release 2.13. I don't think a we should go for 2.x.y.
>>>
>>> Regards
>>> Felix
Re: Release 2.13 ?
Posted by Milamber <mi...@apache.org>.
Hello,
+1 for me to release a 2.13 version. (I can act as RM)
+1 too for a new property to disable RSTA on Logger panel before the new
release.
Milamber
On 25/01/2015 00:20, sebb wrote:
> OK to name it 2.13 and to release it.
>
> Given that there have been some issues with using RSyntaxTextArea, I
> wonder whether what it provides for the LoggerPanel is worth the
> potential disadvantages.
>
> I have just had a look at the display, and I'm not sure it provides
> much apart from line numbering..
>
> I can see that RSTA is beneficial for the GUI fields, but these are
> generally quite small, whereas the logging panel can grow without
> bound.
>
> At the moment the user has no choice as to whether to use it.
>
> Rather than release 2.13 and hope that the issues have been solved, I
> think it would be better to at least provide the option to disable
> RSTA for the LoggerPanel. This could be done with a property.
>
> At least then there would be a work round if RSTA proves problematic.
>
> On 24 January 2015 at 19:56, Felix Schumacher
> <fe...@internetallee.de> wrote:
>> Am 24.01.2015 um 16:30 schrieb Philippe Mouawad:
>>
>>> Hello,
>>> It appears 2.12 suffers from an OOM in GUI mode :
>>>
>>> - https://issues.apache.org/bugzilla/show_bug.cgi?id=57440
>>>
>>> This OOM seems to be due to RSyntaxTexarea bug:
>>>
>>> - https://github.com/bobbylight/RSyntaxTextArea/issues/99
>>>
>>> It appeared after the rework of LoggerPanel#processEvent way of appending
>>> event.
>>>
>>> Now that it receivs log event even when closed this OOM has more chances
>>> to
>>> appear.
>>>
>>> I reverted to 2.11 way of appending events to fix OOM waiting for answer
>>> from rsyntaxtarea project.
>>>
>>> There was also a bug in the way limit=0 was set that had no effect, I
>>> fixed
>>> it as part of the bug.
>>>
>>> There is a workaround which is to set:
>>>
>>> - jmeter.loggerpanel.enable_when_closed=false
>>>
>>> But if user opens panel, OOM will occur if lot of logs occur (specially if
>>> stacktraces).
>>>
>>> If we release, it cannot be named 2.12.1 because we have some "big?"
>>> features in this versions so it would not be a minor one.
>>>
>>> Regarding the frequency and impact of this bug, in our company I had 2
>>> reports in 5 days of this OOM so I think it is not to be ignored.
>>>
>>>
>>> Thoughts ?
>>>
>> +1 to release 2.13. I don't think a we should go for 2.x.y.
>>
>> Regards
>> Felix
Re: Release 2.13 ?
Posted by sebb <se...@gmail.com>.
On 26 January 2015 at 12:25, Philippe Mouawad
<ph...@gmail.com> wrote:
> Hi,
> I think I will delay performance optimization as I upgraded yesterday
> evening to HttpClient 4.4 and there are a lot of deprecations that need to
> be fixed before implementing this enhancement.
> @sebb, as I asked many times, I thought you had started the upgrade ? did
> you or did I misunderstood ?
Yes, I made a start. I've created a branch - HC4 - with some changes,
but it is far from complete.
> Is there a migration guide from 4.2.X to 4.4.X ? Reading website I didn't
> see one, it only spoke about the examples to follow to use new API.
No, there does not seem to be a migration guide.
The deprecated classes have pointers to the replacements, but there
have been some fundamental changes that mean one cannot just rename
the classes.
I think we will basically have to rewrite HTTPHC4Impl using the examples.
There are one or two other classes - e.g. MeasuringConnectionManager -
that will also need rewriting.
I tried to start with the smaller classes, but the larger classes are
dependent on them, so I think one just has to start at the top and
work down.
This will clearly need to wait until a future release.
>
> Thanks
> Regards
>
>
> On Sun, Jan 25, 2015 at 8:07 PM, Philippe Mouawad <
> philippe.mouawad@gmail.com> wrote:
>
>>
>>
>> On Sunday, January 25, 2015, sebb <se...@gmail.com> wrote:
>>
>>> On 25 January 2015 at 14:30, Philippe Mouawad
>>> <ph...@gmail.com> wrote:
>>> > On Sun, Jan 25, 2015 at 1:20 AM, sebb <se...@gmail.com> wrote:
>>> >
>>> >> OK to name it 2.13 and to release it.
>>> >>
>>> >
>>> > Thanks
>>> >
>>> >>
>>> >> Given that there have been some issues with using RSyntaxTextArea, I
>>> >> wonder whether what it provides for the LoggerPanel is worth the
>>> >> potential disadvantages.
>>> >>
>>> >> I have just had a look at the display, and I'm not sure it provides
>>> >> much apart from line numbering..
>>> >>
>>> >> I can see that RSTA is beneficial for the GUI fields, but these are
>>> >> generally quite small, whereas the logging panel can grow without
>>> >> bound.
>>> >>
>>> >> At the moment the user has no choice as to whether to use it.
>>> >>
>>> >> Rather than release 2.13 and hope that the issues have been solved, I
>>> >> think it would be better to at least provide the option to disable
>>> >> RSTA for the LoggerPanel. This could be done with a property.
>>> >>
>>> >> We do not hope issues are solved , we have explanation of source of
>>> issues
>>> > and they are fixed now (1 (limit) by change in constructor, the second
>>> by
>>> > reverting to old way of adding events).
>>> > I made some tests enabling LoggerPanel and making logs huge, I didn't
>>> > notice memory leak, but other checks are welcome.
>>> > We are expecting a fix from RTSA but we can work without it.
>>> > Adding a new property does not seem to me a good idea:
>>> > - Another new one (we have for something like 237 JMETER PROPERTIES),
>>>
>>> So what?
>>
>>
>> Makes it hard for newbies.
>> And less maintainable for us.
>> It is great that we handle backward compatibility but maybe at some
>> version we should remove properties that allowed to retain old behaviour.
>>
>>
>>
>>> > - adding a new one to propose a choice for customizing logger panel does
>>> > not seem suitable for me. If we are not satisfied with RTSA for this,
>>> then
>>> > let's just drop it.
>>>
>>> Fine by me if you want to drop it.
>>> However if it is kept, then I want there to be a way of disabling it
>>> if necessary which does not involve creating a new release.
>>>
>>> > By the way making some review and documenting properties would may be a
>>> > good idea to ensure they are all useful and still up to date. Shall I
>>> open
>>> > a bugzilla for this ?
>>>
>>> OK.
>>
>> Will do soon
>>
>>>
>>> >
>>> > At least then there would be a work round if RSTA proves problematic.
>>> >
>>> > As I said, in current nightly build, issue is fixed but other commiters
>>> > double checks are welcome to be sure.
>>>
>>> There's no guarantee that tests will find all the issues.
>>>
>>> Since it has caused problems in the past, and the log is unbounded in
>>> size, I think it is quite likely that this use of RSTA will be
>>> problematic.
>>
>>
>> yes but we bounded the number of lines to retain in logs.
>>
>>
>>> Even if it does not have a memory leak, it may well require more
>>> memory than a standard TextArea.
>>
>> But is it worth ? Shouldn't we quantify ?
>>
>>
>>>
>>> So it seems sensible to provide an opt-out that does not require
>>> re-releasing JMeter.
>>>
>>>
>>
>>> >
>>> >>
>>> >> On 24 January 2015 at 19:56, Felix Schumacher
>>> >> <fe...@internetallee.de> wrote:
>>> >> > Am 24.01.2015 um 16:30 schrieb Philippe Mouawad:
>>> >> >
>>> >> >> Hello,
>>> >> >> It appears 2.12 suffers from an OOM in GUI mode :
>>> >> >>
>>> >> >> - https://issues.apache.org/bugzilla/show_bug.cgi?id=57440
>>> >> >>
>>> >> >> This OOM seems to be due to RSyntaxTexarea bug:
>>> >> >>
>>> >> >> - https://github.com/bobbylight/RSyntaxTextArea/issues/99
>>> >> >>
>>> >> >> It appeared after the rework of LoggerPanel#processEvent way of
>>> >> appending
>>> >> >> event.
>>> >> >>
>>> >> >> Now that it receivs log event even when closed this OOM has more
>>> chances
>>> >> >> to
>>> >> >> appear.
>>> >> >>
>>> >> >> I reverted to 2.11 way of appending events to fix OOM waiting for
>>> answer
>>> >> >> from rsyntaxtarea project.
>>> >> >>
>>> >> >> There was also a bug in the way limit=0 was set that had no effect,
>>> I
>>> >> >> fixed
>>> >> >> it as part of the bug.
>>> >> >>
>>> >> >> There is a workaround which is to set:
>>> >> >>
>>> >> >> - jmeter.loggerpanel.enable_when_closed=false
>>> >> >>
>>> >> >> But if user opens panel, OOM will occur if lot of logs occur
>>> (specially
>>> >> if
>>> >> >> stacktraces).
>>> >> >>
>>> >> >> If we release, it cannot be named 2.12.1 because we have some "big?"
>>> >> >> features in this versions so it would not be a minor one.
>>> >> >>
>>> >> >> Regarding the frequency and impact of this bug, in our company I
>>> had 2
>>> >> >> reports in 5 days of this OOM so I think it is not to be ignored.
>>> >> >>
>>> >> >>
>>> >> >> Thoughts ?
>>> >> >>
>>> >> > +1 to release 2.13. I don't think a we should go for 2.x.y.
>>> >> >
>>> >> > Regards
>>> >> > Felix
>>> >>
>>> >
>>> >
>>> >
>>> > --
>>> > Cordialement.
>>> > Philippe Mouawad.
>>>
>>
>>
>> --
>> Cordialement.
>> Philippe Mouawad.
>>
>>
>>
>>
>
>
> --
> Cordialement.
> Philippe Mouawad.
Re: Release 2.13 ?
Posted by Philippe Mouawad <ph...@gmail.com>.
Hi,
I think I will delay performance optimization as I upgraded yesterday
evening to HttpClient 4.4 and there are a lot of deprecations that need to
be fixed before implementing this enhancement.
@sebb, as I asked many times, I thought you had started the upgrade ? did
you or did I misunderstood ?
Is there a migration guide from 4.2.X to 4.4.X ? Reading website I didn't
see one, it only spoke about the examples to follow to use new API.
Thanks
Regards
On Sun, Jan 25, 2015 at 8:07 PM, Philippe Mouawad <
philippe.mouawad@gmail.com> wrote:
>
>
> On Sunday, January 25, 2015, sebb <se...@gmail.com> wrote:
>
>> On 25 January 2015 at 14:30, Philippe Mouawad
>> <ph...@gmail.com> wrote:
>> > On Sun, Jan 25, 2015 at 1:20 AM, sebb <se...@gmail.com> wrote:
>> >
>> >> OK to name it 2.13 and to release it.
>> >>
>> >
>> > Thanks
>> >
>> >>
>> >> Given that there have been some issues with using RSyntaxTextArea, I
>> >> wonder whether what it provides for the LoggerPanel is worth the
>> >> potential disadvantages.
>> >>
>> >> I have just had a look at the display, and I'm not sure it provides
>> >> much apart from line numbering..
>> >>
>> >> I can see that RSTA is beneficial for the GUI fields, but these are
>> >> generally quite small, whereas the logging panel can grow without
>> >> bound.
>> >>
>> >> At the moment the user has no choice as to whether to use it.
>> >>
>> >> Rather than release 2.13 and hope that the issues have been solved, I
>> >> think it would be better to at least provide the option to disable
>> >> RSTA for the LoggerPanel. This could be done with a property.
>> >>
>> >> We do not hope issues are solved , we have explanation of source of
>> issues
>> > and they are fixed now (1 (limit) by change in constructor, the second
>> by
>> > reverting to old way of adding events).
>> > I made some tests enabling LoggerPanel and making logs huge, I didn't
>> > notice memory leak, but other checks are welcome.
>> > We are expecting a fix from RTSA but we can work without it.
>> > Adding a new property does not seem to me a good idea:
>> > - Another new one (we have for something like 237 JMETER PROPERTIES),
>>
>> So what?
>
>
> Makes it hard for newbies.
> And less maintainable for us.
> It is great that we handle backward compatibility but maybe at some
> version we should remove properties that allowed to retain old behaviour.
>
>
>
>> > - adding a new one to propose a choice for customizing logger panel does
>> > not seem suitable for me. If we are not satisfied with RTSA for this,
>> then
>> > let's just drop it.
>>
>> Fine by me if you want to drop it.
>> However if it is kept, then I want there to be a way of disabling it
>> if necessary which does not involve creating a new release.
>>
>> > By the way making some review and documenting properties would may be a
>> > good idea to ensure they are all useful and still up to date. Shall I
>> open
>> > a bugzilla for this ?
>>
>> OK.
>
> Will do soon
>
>>
>> >
>> > At least then there would be a work round if RSTA proves problematic.
>> >
>> > As I said, in current nightly build, issue is fixed but other commiters
>> > double checks are welcome to be sure.
>>
>> There's no guarantee that tests will find all the issues.
>>
>> Since it has caused problems in the past, and the log is unbounded in
>> size, I think it is quite likely that this use of RSTA will be
>> problematic.
>
>
> yes but we bounded the number of lines to retain in logs.
>
>
>> Even if it does not have a memory leak, it may well require more
>> memory than a standard TextArea.
>
> But is it worth ? Shouldn't we quantify ?
>
>
>>
>> So it seems sensible to provide an opt-out that does not require
>> re-releasing JMeter.
>>
>>
>
>> >
>> >>
>> >> On 24 January 2015 at 19:56, Felix Schumacher
>> >> <fe...@internetallee.de> wrote:
>> >> > Am 24.01.2015 um 16:30 schrieb Philippe Mouawad:
>> >> >
>> >> >> Hello,
>> >> >> It appears 2.12 suffers from an OOM in GUI mode :
>> >> >>
>> >> >> - https://issues.apache.org/bugzilla/show_bug.cgi?id=57440
>> >> >>
>> >> >> This OOM seems to be due to RSyntaxTexarea bug:
>> >> >>
>> >> >> - https://github.com/bobbylight/RSyntaxTextArea/issues/99
>> >> >>
>> >> >> It appeared after the rework of LoggerPanel#processEvent way of
>> >> appending
>> >> >> event.
>> >> >>
>> >> >> Now that it receivs log event even when closed this OOM has more
>> chances
>> >> >> to
>> >> >> appear.
>> >> >>
>> >> >> I reverted to 2.11 way of appending events to fix OOM waiting for
>> answer
>> >> >> from rsyntaxtarea project.
>> >> >>
>> >> >> There was also a bug in the way limit=0 was set that had no effect,
>> I
>> >> >> fixed
>> >> >> it as part of the bug.
>> >> >>
>> >> >> There is a workaround which is to set:
>> >> >>
>> >> >> - jmeter.loggerpanel.enable_when_closed=false
>> >> >>
>> >> >> But if user opens panel, OOM will occur if lot of logs occur
>> (specially
>> >> if
>> >> >> stacktraces).
>> >> >>
>> >> >> If we release, it cannot be named 2.12.1 because we have some "big?"
>> >> >> features in this versions so it would not be a minor one.
>> >> >>
>> >> >> Regarding the frequency and impact of this bug, in our company I
>> had 2
>> >> >> reports in 5 days of this OOM so I think it is not to be ignored.
>> >> >>
>> >> >>
>> >> >> Thoughts ?
>> >> >>
>> >> > +1 to release 2.13. I don't think a we should go for 2.x.y.
>> >> >
>> >> > Regards
>> >> > Felix
>> >>
>> >
>> >
>> >
>> > --
>> > Cordialement.
>> > Philippe Mouawad.
>>
>
>
> --
> Cordialement.
> Philippe Mouawad.
>
>
>
>
--
Cordialement.
Philippe Mouawad.
Re: Release 2.13 ?
Posted by Philippe Mouawad <ph...@gmail.com>.
On Sunday, January 25, 2015, sebb <se...@gmail.com> wrote:
> On 25 January 2015 at 14:30, Philippe Mouawad
> <philippe.mouawad@gmail.com <javascript:;>> wrote:
> > On Sun, Jan 25, 2015 at 1:20 AM, sebb <sebbaz@gmail.com <javascript:;>>
> wrote:
> >
> >> OK to name it 2.13 and to release it.
> >>
> >
> > Thanks
> >
> >>
> >> Given that there have been some issues with using RSyntaxTextArea, I
> >> wonder whether what it provides for the LoggerPanel is worth the
> >> potential disadvantages.
> >>
> >> I have just had a look at the display, and I'm not sure it provides
> >> much apart from line numbering..
> >>
> >> I can see that RSTA is beneficial for the GUI fields, but these are
> >> generally quite small, whereas the logging panel can grow without
> >> bound.
> >>
> >> At the moment the user has no choice as to whether to use it.
> >>
> >> Rather than release 2.13 and hope that the issues have been solved, I
> >> think it would be better to at least provide the option to disable
> >> RSTA for the LoggerPanel. This could be done with a property.
> >>
> >> We do not hope issues are solved , we have explanation of source of
> issues
> > and they are fixed now (1 (limit) by change in constructor, the second by
> > reverting to old way of adding events).
> > I made some tests enabling LoggerPanel and making logs huge, I didn't
> > notice memory leak, but other checks are welcome.
> > We are expecting a fix from RTSA but we can work without it.
> > Adding a new property does not seem to me a good idea:
> > - Another new one (we have for something like 237 JMETER PROPERTIES),
>
> So what?
Makes it hard for newbies.
And less maintainable for us.
It is great that we handle backward compatibility but maybe at some
version we should remove properties that allowed to retain old behaviour.
> > - adding a new one to propose a choice for customizing logger panel does
> > not seem suitable for me. If we are not satisfied with RTSA for this,
> then
> > let's just drop it.
>
> Fine by me if you want to drop it.
> However if it is kept, then I want there to be a way of disabling it
> if necessary which does not involve creating a new release.
>
> > By the way making some review and documenting properties would may be a
> > good idea to ensure they are all useful and still up to date. Shall I
> open
> > a bugzilla for this ?
>
> OK.
Will do soon
>
> >
> > At least then there would be a work round if RSTA proves problematic.
> >
> > As I said, in current nightly build, issue is fixed but other commiters
> > double checks are welcome to be sure.
>
> There's no guarantee that tests will find all the issues.
>
> Since it has caused problems in the past, and the log is unbounded in
> size, I think it is quite likely that this use of RSTA will be
> problematic.
yes but we bounded the number of lines to retain in logs.
> Even if it does not have a memory leak, it may well require more
> memory than a standard TextArea.
But is it worth ? Shouldn't we quantify ?
>
> So it seems sensible to provide an opt-out that does not require
> re-releasing JMeter.
>
>
> >
> >>
> >> On 24 January 2015 at 19:56, Felix Schumacher
> >> <felix.schumacher@internetallee.de <javascript:;>> wrote:
> >> > Am 24.01.2015 um 16:30 schrieb Philippe Mouawad:
> >> >
> >> >> Hello,
> >> >> It appears 2.12 suffers from an OOM in GUI mode :
> >> >>
> >> >> - https://issues.apache.org/bugzilla/show_bug.cgi?id=57440
> >> >>
> >> >> This OOM seems to be due to RSyntaxTexarea bug:
> >> >>
> >> >> - https://github.com/bobbylight/RSyntaxTextArea/issues/99
> >> >>
> >> >> It appeared after the rework of LoggerPanel#processEvent way of
> >> appending
> >> >> event.
> >> >>
> >> >> Now that it receivs log event even when closed this OOM has more
> chances
> >> >> to
> >> >> appear.
> >> >>
> >> >> I reverted to 2.11 way of appending events to fix OOM waiting for
> answer
> >> >> from rsyntaxtarea project.
> >> >>
> >> >> There was also a bug in the way limit=0 was set that had no effect, I
> >> >> fixed
> >> >> it as part of the bug.
> >> >>
> >> >> There is a workaround which is to set:
> >> >>
> >> >> - jmeter.loggerpanel.enable_when_closed=false
> >> >>
> >> >> But if user opens panel, OOM will occur if lot of logs occur
> (specially
> >> if
> >> >> stacktraces).
> >> >>
> >> >> If we release, it cannot be named 2.12.1 because we have some "big?"
> >> >> features in this versions so it would not be a minor one.
> >> >>
> >> >> Regarding the frequency and impact of this bug, in our company I had
> 2
> >> >> reports in 5 days of this OOM so I think it is not to be ignored.
> >> >>
> >> >>
> >> >> Thoughts ?
> >> >>
> >> > +1 to release 2.13. I don't think a we should go for 2.x.y.
> >> >
> >> > Regards
> >> > Felix
> >>
> >
> >
> >
> > --
> > Cordialement.
> > Philippe Mouawad.
>
--
Cordialement.
Philippe Mouawad.
Re: Release 2.13 ?
Posted by sebb <se...@gmail.com>.
On 25 January 2015 at 14:30, Philippe Mouawad
<ph...@gmail.com> wrote:
> On Sun, Jan 25, 2015 at 1:20 AM, sebb <se...@gmail.com> wrote:
>
>> OK to name it 2.13 and to release it.
>>
>
> Thanks
>
>>
>> Given that there have been some issues with using RSyntaxTextArea, I
>> wonder whether what it provides for the LoggerPanel is worth the
>> potential disadvantages.
>>
>> I have just had a look at the display, and I'm not sure it provides
>> much apart from line numbering..
>>
>> I can see that RSTA is beneficial for the GUI fields, but these are
>> generally quite small, whereas the logging panel can grow without
>> bound.
>>
>> At the moment the user has no choice as to whether to use it.
>>
>> Rather than release 2.13 and hope that the issues have been solved, I
>> think it would be better to at least provide the option to disable
>> RSTA for the LoggerPanel. This could be done with a property.
>>
>> We do not hope issues are solved , we have explanation of source of issues
> and they are fixed now (1 (limit) by change in constructor, the second by
> reverting to old way of adding events).
> I made some tests enabling LoggerPanel and making logs huge, I didn't
> notice memory leak, but other checks are welcome.
> We are expecting a fix from RTSA but we can work without it.
> Adding a new property does not seem to me a good idea:
> - Another new one (we have for something like 237 JMETER PROPERTIES),
So what?
> - adding a new one to propose a choice for customizing logger panel does
> not seem suitable for me. If we are not satisfied with RTSA for this, then
> let's just drop it.
Fine by me if you want to drop it.
However if it is kept, then I want there to be a way of disabling it
if necessary which does not involve creating a new release.
> By the way making some review and documenting properties would may be a
> good idea to ensure they are all useful and still up to date. Shall I open
> a bugzilla for this ?
OK.
>
> At least then there would be a work round if RSTA proves problematic.
>
> As I said, in current nightly build, issue is fixed but other commiters
> double checks are welcome to be sure.
There's no guarantee that tests will find all the issues.
Since it has caused problems in the past, and the log is unbounded in
size, I think it is quite likely that this use of RSTA will be
problematic.
Even if it does not have a memory leak, it may well require more
memory than a standard TextArea.
So it seems sensible to provide an opt-out that does not require
re-releasing JMeter.
>
>>
>> On 24 January 2015 at 19:56, Felix Schumacher
>> <fe...@internetallee.de> wrote:
>> > Am 24.01.2015 um 16:30 schrieb Philippe Mouawad:
>> >
>> >> Hello,
>> >> It appears 2.12 suffers from an OOM in GUI mode :
>> >>
>> >> - https://issues.apache.org/bugzilla/show_bug.cgi?id=57440
>> >>
>> >> This OOM seems to be due to RSyntaxTexarea bug:
>> >>
>> >> - https://github.com/bobbylight/RSyntaxTextArea/issues/99
>> >>
>> >> It appeared after the rework of LoggerPanel#processEvent way of
>> appending
>> >> event.
>> >>
>> >> Now that it receivs log event even when closed this OOM has more chances
>> >> to
>> >> appear.
>> >>
>> >> I reverted to 2.11 way of appending events to fix OOM waiting for answer
>> >> from rsyntaxtarea project.
>> >>
>> >> There was also a bug in the way limit=0 was set that had no effect, I
>> >> fixed
>> >> it as part of the bug.
>> >>
>> >> There is a workaround which is to set:
>> >>
>> >> - jmeter.loggerpanel.enable_when_closed=false
>> >>
>> >> But if user opens panel, OOM will occur if lot of logs occur (specially
>> if
>> >> stacktraces).
>> >>
>> >> If we release, it cannot be named 2.12.1 because we have some "big?"
>> >> features in this versions so it would not be a minor one.
>> >>
>> >> Regarding the frequency and impact of this bug, in our company I had 2
>> >> reports in 5 days of this OOM so I think it is not to be ignored.
>> >>
>> >>
>> >> Thoughts ?
>> >>
>> > +1 to release 2.13. I don't think a we should go for 2.x.y.
>> >
>> > Regards
>> > Felix
>>
>
>
>
> --
> Cordialement.
> Philippe Mouawad.
Re: Release 2.13 ?
Posted by Philippe Mouawad <ph...@gmail.com>.
Hi,
Note my initial idea for using it in LoggerPanel was:
- to color in RED ERROR and WARNING logs
- at some step be able to search in it, 2 features that RTSA offers (
http://fifesoft.com/rsyntaxtextarea/examples/example4.php)
Currently it is still easier to open jmeter.log in an editor and do it but
I thought being able to do it in JMeter GUI was better.
But I didn't have time to implement it and for now I think we should (I
will on my side) concentrate efforts on the following items:
-
http://mail-archives.apache.org/mod_mbox/jmeter-dev/201410.mbox/%3CCAH9fUpa_KfcSDSkKx-+3dsQhfHv9amaPNdoYSnMMUvQ30dV5YQ@mail.gmail.com%3E
I think that UNDO/REDO should be given some attention to make it enabled in
future version, not 2.13 maybe but it would be nice.
- https://issues.apache.org/bugzilla/show_bug.cgi?id=57043
- https://issues.apache.org/bugzilla/show_bug.cgi?id=57039
- https://issues.apache.org/bugzilla/show_bug.cgi?id=57040
- Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53540
By the way maybe these bugs should be mentioned in the message that shows
how to enable it. I had some feedback from customers that enabled it and
noticed slowdowns ( I answered these issues were known that's why feature
was disabled by default), so not obvious.
For 2.13 release, if you can give me some time I would like to implement
Performance improvement thanks to Oleg answers on friday. I will notify if
I think it takes me too much time.
Regards
Philippe
On Sun, Jan 25, 2015 at 3:30 PM, Philippe Mouawad <
philippe.mouawad@gmail.com> wrote:
>
>
> On Sun, Jan 25, 2015 at 1:20 AM, sebb <se...@gmail.com> wrote:
>
>> OK to name it 2.13 and to release it.
>>
>
> Thanks
>
>>
>> Given that there have been some issues with using RSyntaxTextArea, I
>> wonder whether what it provides for the LoggerPanel is worth the
>> potential disadvantages.
>>
>> I have just had a look at the display, and I'm not sure it provides
>> much apart from line numbering..
>>
>> I can see that RSTA is beneficial for the GUI fields, but these are
>> generally quite small, whereas the logging panel can grow without
>> bound.
>>
>> At the moment the user has no choice as to whether to use it.
>>
>> Rather than release 2.13 and hope that the issues have been solved, I
>> think it would be better to at least provide the option to disable
>> RSTA for the LoggerPanel. This could be done with a property.
>>
>> We do not hope issues are solved , we have explanation of source of
> issues and they are fixed now (1 (limit) by change in constructor, the
> second by reverting to old way of adding events).
> I made some tests enabling LoggerPanel and making logs huge, I didn't
> notice memory leak, but other checks are welcome.
> We are expecting a fix from RTSA but we can work without it.
> Adding a new property does not seem to me a good idea:
> - Another new one (we have for something like 237 JMETER PROPERTIES),
> - adding a new one to propose a choice for customizing logger panel does
> not seem suitable for me. If we are not satisfied with RTSA for this, then
> let's just drop it.
>
> By the way making some review and documenting properties would may be a
> good idea to ensure they are all useful and still up to date. Shall I open
> a bugzilla for this ?
>
>
> At least then there would be a work round if RSTA proves problematic.
>
> As I said, in current nightly build, issue is fixed but other commiters
> double checks are welcome to be sure.
>
>
>>
>> On 24 January 2015 at 19:56, Felix Schumacher
>> <fe...@internetallee.de> wrote:
>> > Am 24.01.2015 um 16:30 schrieb Philippe Mouawad:
>> >
>> >> Hello,
>> >> It appears 2.12 suffers from an OOM in GUI mode :
>> >>
>> >> - https://issues.apache.org/bugzilla/show_bug.cgi?id=57440
>> >>
>> >> This OOM seems to be due to RSyntaxTexarea bug:
>> >>
>> >> - https://github.com/bobbylight/RSyntaxTextArea/issues/99
>> >>
>> >> It appeared after the rework of LoggerPanel#processEvent way of
>> appending
>> >> event.
>> >>
>> >> Now that it receivs log event even when closed this OOM has more
>> chances
>> >> to
>> >> appear.
>> >>
>> >> I reverted to 2.11 way of appending events to fix OOM waiting for
>> answer
>> >> from rsyntaxtarea project.
>> >>
>> >> There was also a bug in the way limit=0 was set that had no effect, I
>> >> fixed
>> >> it as part of the bug.
>> >>
>> >> There is a workaround which is to set:
>> >>
>> >> - jmeter.loggerpanel.enable_when_closed=false
>> >>
>> >> But if user opens panel, OOM will occur if lot of logs occur
>> (specially if
>> >> stacktraces).
>> >>
>> >> If we release, it cannot be named 2.12.1 because we have some "big?"
>> >> features in this versions so it would not be a minor one.
>> >>
>> >> Regarding the frequency and impact of this bug, in our company I had 2
>> >> reports in 5 days of this OOM so I think it is not to be ignored.
>> >>
>> >>
>> >> Thoughts ?
>> >>
>> > +1 to release 2.13. I don't think a we should go for 2.x.y.
>> >
>> > Regards
>> > Felix
>>
>
>
>
> --
> Cordialement.
> Philippe Mouawad.
>
>
>
--
Cordialement.
Philippe Mouawad.
Re: Release 2.13 ?
Posted by Philippe Mouawad <ph...@gmail.com>.
On Sun, Jan 25, 2015 at 1:20 AM, sebb <se...@gmail.com> wrote:
> OK to name it 2.13 and to release it.
>
Thanks
>
> Given that there have been some issues with using RSyntaxTextArea, I
> wonder whether what it provides for the LoggerPanel is worth the
> potential disadvantages.
>
> I have just had a look at the display, and I'm not sure it provides
> much apart from line numbering..
>
> I can see that RSTA is beneficial for the GUI fields, but these are
> generally quite small, whereas the logging panel can grow without
> bound.
>
> At the moment the user has no choice as to whether to use it.
>
> Rather than release 2.13 and hope that the issues have been solved, I
> think it would be better to at least provide the option to disable
> RSTA for the LoggerPanel. This could be done with a property.
>
> We do not hope issues are solved , we have explanation of source of issues
and they are fixed now (1 (limit) by change in constructor, the second by
reverting to old way of adding events).
I made some tests enabling LoggerPanel and making logs huge, I didn't
notice memory leak, but other checks are welcome.
We are expecting a fix from RTSA but we can work without it.
Adding a new property does not seem to me a good idea:
- Another new one (we have for something like 237 JMETER PROPERTIES),
- adding a new one to propose a choice for customizing logger panel does
not seem suitable for me. If we are not satisfied with RTSA for this, then
let's just drop it.
By the way making some review and documenting properties would may be a
good idea to ensure they are all useful and still up to date. Shall I open
a bugzilla for this ?
At least then there would be a work round if RSTA proves problematic.
As I said, in current nightly build, issue is fixed but other commiters
double checks are welcome to be sure.
>
> On 24 January 2015 at 19:56, Felix Schumacher
> <fe...@internetallee.de> wrote:
> > Am 24.01.2015 um 16:30 schrieb Philippe Mouawad:
> >
> >> Hello,
> >> It appears 2.12 suffers from an OOM in GUI mode :
> >>
> >> - https://issues.apache.org/bugzilla/show_bug.cgi?id=57440
> >>
> >> This OOM seems to be due to RSyntaxTexarea bug:
> >>
> >> - https://github.com/bobbylight/RSyntaxTextArea/issues/99
> >>
> >> It appeared after the rework of LoggerPanel#processEvent way of
> appending
> >> event.
> >>
> >> Now that it receivs log event even when closed this OOM has more chances
> >> to
> >> appear.
> >>
> >> I reverted to 2.11 way of appending events to fix OOM waiting for answer
> >> from rsyntaxtarea project.
> >>
> >> There was also a bug in the way limit=0 was set that had no effect, I
> >> fixed
> >> it as part of the bug.
> >>
> >> There is a workaround which is to set:
> >>
> >> - jmeter.loggerpanel.enable_when_closed=false
> >>
> >> But if user opens panel, OOM will occur if lot of logs occur (specially
> if
> >> stacktraces).
> >>
> >> If we release, it cannot be named 2.12.1 because we have some "big?"
> >> features in this versions so it would not be a minor one.
> >>
> >> Regarding the frequency and impact of this bug, in our company I had 2
> >> reports in 5 days of this OOM so I think it is not to be ignored.
> >>
> >>
> >> Thoughts ?
> >>
> > +1 to release 2.13. I don't think a we should go for 2.x.y.
> >
> > Regards
> > Felix
>
--
Cordialement.
Philippe Mouawad.
Re: Release 2.13 ?
Posted by sebb <se...@gmail.com>.
OK to name it 2.13 and to release it.
Given that there have been some issues with using RSyntaxTextArea, I
wonder whether what it provides for the LoggerPanel is worth the
potential disadvantages.
I have just had a look at the display, and I'm not sure it provides
much apart from line numbering..
I can see that RSTA is beneficial for the GUI fields, but these are
generally quite small, whereas the logging panel can grow without
bound.
At the moment the user has no choice as to whether to use it.
Rather than release 2.13 and hope that the issues have been solved, I
think it would be better to at least provide the option to disable
RSTA for the LoggerPanel. This could be done with a property.
At least then there would be a work round if RSTA proves problematic.
On 24 January 2015 at 19:56, Felix Schumacher
<fe...@internetallee.de> wrote:
> Am 24.01.2015 um 16:30 schrieb Philippe Mouawad:
>
>> Hello,
>> It appears 2.12 suffers from an OOM in GUI mode :
>>
>> - https://issues.apache.org/bugzilla/show_bug.cgi?id=57440
>>
>> This OOM seems to be due to RSyntaxTexarea bug:
>>
>> - https://github.com/bobbylight/RSyntaxTextArea/issues/99
>>
>> It appeared after the rework of LoggerPanel#processEvent way of appending
>> event.
>>
>> Now that it receivs log event even when closed this OOM has more chances
>> to
>> appear.
>>
>> I reverted to 2.11 way of appending events to fix OOM waiting for answer
>> from rsyntaxtarea project.
>>
>> There was also a bug in the way limit=0 was set that had no effect, I
>> fixed
>> it as part of the bug.
>>
>> There is a workaround which is to set:
>>
>> - jmeter.loggerpanel.enable_when_closed=false
>>
>> But if user opens panel, OOM will occur if lot of logs occur (specially if
>> stacktraces).
>>
>> If we release, it cannot be named 2.12.1 because we have some "big?"
>> features in this versions so it would not be a minor one.
>>
>> Regarding the frequency and impact of this bug, in our company I had 2
>> reports in 5 days of this OOM so I think it is not to be ignored.
>>
>>
>> Thoughts ?
>>
> +1 to release 2.13. I don't think a we should go for 2.x.y.
>
> Regards
> Felix
Re: Release 2.13 ?
Posted by Felix Schumacher <fe...@internetallee.de>.
Am 24.01.2015 um 16:30 schrieb Philippe Mouawad:
> Hello,
> It appears 2.12 suffers from an OOM in GUI mode :
>
> - https://issues.apache.org/bugzilla/show_bug.cgi?id=57440
>
> This OOM seems to be due to RSyntaxTexarea bug:
>
> - https://github.com/bobbylight/RSyntaxTextArea/issues/99
>
> It appeared after the rework of LoggerPanel#processEvent way of appending
> event.
>
> Now that it receivs log event even when closed this OOM has more chances to
> appear.
>
> I reverted to 2.11 way of appending events to fix OOM waiting for answer
> from rsyntaxtarea project.
>
> There was also a bug in the way limit=0 was set that had no effect, I fixed
> it as part of the bug.
>
> There is a workaround which is to set:
>
> - jmeter.loggerpanel.enable_when_closed=false
>
> But if user opens panel, OOM will occur if lot of logs occur (specially if
> stacktraces).
>
> If we release, it cannot be named 2.12.1 because we have some "big?"
> features in this versions so it would not be a minor one.
>
> Regarding the frequency and impact of this bug, in our company I had 2
> reports in 5 days of this OOM so I think it is not to be ignored.
>
>
> Thoughts ?
>
+1 to release 2.13. I don't think a we should go for 2.x.y.
Regards
Felix