You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/06/16 00:23:15 UTC
[GitHub] codecov-io commented on issue #5219: Revert "[webpack] setup lazy
loading for all visualizations"
codecov-io commented on issue #5219: Revert "[webpack] setup lazy loading for all visualizations"
URL: https://github.com/apache/incubator-superset/pull/5219#issuecomment-397772236
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5219?src=pr&el=h1) Report
> Merging [#5219](https://codecov.io/gh/apache/incubator-superset/pull/5219?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/d5ebc430c2f0de7f4dbf01e5486e481153fef112?src=pr&el=desc) will **decrease** coverage by `14.08%`.
> The diff coverage is `56.81%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/5219?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5219 +/- ##
===========================================
- Coverage 77.48% 63.39% -14.09%
===========================================
Files 44 261 +217
Lines 8749 19959 +11210
Branches 0 2053 +2053
===========================================
+ Hits 6779 12654 +5875
- Misses 1970 7296 +5326
- Partials 0 9 +9
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5219?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/assets/src/visualizations/markup.js](https://codecov.io/gh/apache/incubator-superset/pull/5219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9tYXJrdXAuanM=) | `26.66% <ø> (ø)` | |
| [superset/assets/src/visualizations/time\_table.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy90aW1lX3RhYmxlLmpzeA==) | `16.81% <0%> (ø)` | |
| [...et/assets/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9TbGljZUhlYWRlci5qc3g=) | `31.14% <0%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/5219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `81.34% <100%> (ø)` | :arrow_up: |
| [superset/assets/src/components/Loading.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0xvYWRpbmcuanN4) | `87.5% <100%> (ø)` | |
| [...ts/src/visualizations/deckgl/layers/screengrid.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL3NjcmVlbmdyaWQuanN4) | `38.18% <100%> (ø)` | |
| [...ssets/src/visualizations/deckgl/layers/scatter.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL3NjYXR0ZXIuanN4) | `27.83% <100%> (ø)` | |
| [superset/assets/src/visualizations/index.js](https://codecov.io/gh/apache/incubator-superset/pull/5219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9pbmRleC5qcw==) | `100% <100%> (ø)` | |
| [superset/assets/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jaGFydC9DaGFydC5qc3g=) | `65% <48.38%> (ø)` | |
| [superset/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/5219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvX19pbml0X18ucHk=) | `72.32% <75%> (-0.79%)` | :arrow_down: |
| ... and [217 more](https://codecov.io/gh/apache/incubator-superset/pull/5219/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5219?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5219?src=pr&el=footer). Last update [d5ebc43...c9300ce](https://codecov.io/gh/apache/incubator-superset/pull/5219?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org