[jira] Commented: (JSPWIKI-260) MORE link of ReferringPagesPlugin is wrongly rendered.

["Janne Jalkanen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JSPWIKI-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594302#action_12594302 ] 

Janne Jalkanen commented on JSPWIKI-260:
----------------------------------------

That would require everyone to update their running jspwiki.properties file.  Much better to add it to the built-in properties (which can be overridden from the property line).  Otherwise everyone's system will break...

Alternatively, we could just create the HTML ourselves and not bother about the wiki translation...

> MORE link of ReferringPagesPlugin is wrongly rendered.
> ------------------------------------------------------
>
>                 Key: JSPWIKI-260
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-260
>             Project: JSPWiki
>          Issue Type: Bug
>          Components: Plugins
>    Affects Versions: 2.6.0, 2.6.1, 2.6.2
>            Reporter: Dirk Frederickx
>             Fix For: 2.8
>
>
> The ReferredPagesPlugin is first rendering its internal text in wiki-markup. At the end, the result is convered in HTML.
> However, the "more...." link gets composed incorrectly as html (url)
> {code}                    Object[] args = { "" + ( links.size() - items),
>                                       context.getURL( WikiContext.INFO, page.getName() ) };
>                     extras = MessageFormat.format(extras, args); 
>                     wikitext += extras;
> {code}
> This will render something like
> {code}
>     [more|/some-path/PageInfo?page=<pagename>]
> {code}
> which gets rendered wrongly as an attachment link, because of the embedded / character.
> Proposed solution:
> Add to jspwiki.properties an InterWiki link which allows easy links to the page info. 
> {code}
>     jspwiki.interWikiRef.Info = PageInfo.jsp?page=%s
> {code}
> which allows following markup, usable by the plugin
> {code}
>    [more|Info:<pagename>]
> {code}
> dirk

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.