[jira] [Commented] (CLOUDSTACK-10137) Re-installation fails for cloudstack-management

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247237#comment-16247237 ] 

ASF GitHub Bot commented on CLOUDSTACK-10137:
---------------------------------------------

rhtyd commented on a change in pull request #2316: CLOUDSTACK-10137: Only link log4j if not already present
URL: https://github.com/apache/cloudstack/pull/2316#discussion_r150183528
 
 

 ##########
 File path: debian/cloudstack-management.postinst
 ##########
 @@ -57,7 +57,9 @@ if [ "$1" = configure ]; then
     chgrp cloud ${CONFDIR}/${DBPROPS}
     chown -R cloud:cloud /var/log/cloudstack/management
 
-    ln -s ${CONFDIR}/log4j-cloud.xml ${CONFDIR}/log4j.xml
+    if [ ! -e "$CONFDIR/log4j.xml" ]; then
+        ln -s ${CONFDIR}/log4j-cloud.xml ${CONFDIR}/log4j.xml
 
 Review comment:
   @marcaurele perhaps we can fix it as `ln -sf`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Re-installation fails for cloudstack-management
> -----------------------------------------------
>
>                 Key: CLOUDSTACK-10137
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10137
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Marc-Aurèle Brothier
>            Assignee: Marc-Aurèle Brothier
>
> If you try to reinstall the package (using --reinstall for example) and build another version of it, the linking of {{log4j.xml}} will fail since the file already exists, and let the package improperly installed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)