You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by jiny2 <gi...@git.apache.org> on 2016/01/28 04:26:29 UTC
[GitHub] incubator-hawq pull request: HAWQ-367. Introduce seg_max_connectio...
GitHub user jiny2 opened a pull request:
https://github.com/apache/incubator-hawq/pull/301
HAWQ-367. Introduce seg_max_connections guc to set segment max_connections setting
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jiny2/incubator-hawq HAWQ-367
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/301.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #301
----
commit 73affae221c83e7fab14bf1f174062d9d804bef1
Author: YI JIN <yj...@pivotal.io>
Date: 2016-01-28T03:25:09Z
HAWQ-367. Introduce seg_max_connections guc to set segment max_connections setting
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-367. Introduce seg_max_connectio...
Posted by jiny2 <gi...@git.apache.org>.
Github user jiny2 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/301#discussion_r51076896
--- Diff: src/backend/utils/misc/guc.c ---
@@ -4617,6 +4617,20 @@ static struct config_int ConfigureNamesInt[] =
200, 10, MAX_MAX_BACKENDS, NULL, NULL
},
+ /*
+ * When HAWQ has one master and one segment deployed together in one physical
+ * machine, we can not separately set different max connection count. Thus,
+ * we introduce this guc for segment setting only.
+ */
+ {
+ {"seg_max_connections", PGC_POSTMASTER, CONN_AUTH_SETTINGS,
+ gettext_noop("Sets the maximum number of concurrent connections in a segment."),
+ NULL
+ },
+ &SegMaxBackends,
+ 1600, 80, MAX_MAX_BACKENDS, NULL, NULL
+ },
+
--- End diff --
Ok, I fix it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-367. Introduce seg_max_connectio...
Posted by jiny2 <gi...@git.apache.org>.
Github user jiny2 closed the pull request at:
https://github.com/apache/incubator-hawq/pull/301
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-367. Introduce seg_max_connectio...
Posted by yaoj2 <gi...@git.apache.org>.
Github user yaoj2 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/301#discussion_r51076744
--- Diff: src/backend/utils/misc/guc.c ---
@@ -4617,6 +4617,20 @@ static struct config_int ConfigureNamesInt[] =
200, 10, MAX_MAX_BACKENDS, NULL, NULL
},
+ /*
+ * When HAWQ has one master and one segment deployed together in one physical
+ * machine, we can not separately set different max connection count. Thus,
+ * we introduce this guc for segment setting only.
+ */
+ {
+ {"seg_max_connections", PGC_POSTMASTER, CONN_AUTH_SETTINGS,
+ gettext_noop("Sets the maximum number of concurrent connections in a segment."),
+ NULL
+ },
+ &SegMaxBackends,
+ 1600, 80, MAX_MAX_BACKENDS, NULL, NULL
+ },
+
--- End diff --
For default value, according to 1.x the default is 3 times master value. So we use 200 as master value then 200*3 * 8 we use 4800 as default value.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-367. Introduce seg_max_connectio...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/301#issuecomment-175969011
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-367. Introduce seg_max_connectio...
Posted by linwen <gi...@git.apache.org>.
Github user linwen commented on the pull request:
https://github.com/apache/incubator-hawq/pull/301#issuecomment-175987824
Looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---