You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/08/26 17:23:20 UTC
[jira] [Commented] (METRON-396) Make Stellar function resolution
happen via an annotation and classpath search
[ https://issues.apache.org/jira/browse/METRON-396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15439429#comment-15439429 ]
ASF GitHub Bot commented on METRON-396:
---------------------------------------
GitHub user cestella opened a pull request:
https://github.com/apache/incubator-metron/pull/233
METRON-396: Make Stellar function resolution happen via an annotation and classpath search
At the moment, the only way to add a stellar function is to implement StellarFunction and add the instance to the StellarFunctions enum. This is deficient in a few ways:
* It requires you to modify Metron code to add a stellar capability
* It requires you to make metron-common depend on your project
* There is no way to enforce documentation of the function
Instead, we should create an annotation which will define:
* function name
* namespace
* description
* List of parameters
* return documentation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cestella/incubator-metron METRON-396
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-metron/pull/233.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #233
----
commit 465d37e64861a57dc878f13e5c0685ab31ab3b73
Author: cstella <ce...@gmail.com>
Date: 2016-08-26T17:21:13Z
METRON-396: Make Stellar function resolution happen via an annotation and classpath search
----
> Make Stellar function resolution happen via an annotation and classpath search
> ------------------------------------------------------------------------------
>
> Key: METRON-396
> URL: https://issues.apache.org/jira/browse/METRON-396
> Project: Metron
> Issue Type: Improvement
> Reporter: Casey Stella
> Assignee: Casey Stella
> Labels: stellar
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> At the moment, the only way to add a stellar function is to implement StellarFunction and add the instance to the StellarFunctions enum. This is deficient in a few ways:
> * It requires you to modify Metron code to add a stellar capability
> * It requires you to make metron-common depend on your project
> * There is no way to enforce documentation of the function
> Instead, we should create an annotation which will define the name, namespace, description, parameters and returns.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)