[GitHub] vvraskin closed pull request #78: remove hardcoded env variables for run handler

[GitBox <gi...@apache.org>]

vvraskin closed pull request #78: remove hardcoded env variables for run handler
URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/78
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/core/nodejsActionBase/src/service.js b/core/nodejsActionBase/src/service.js
index daf365f..eb99b6e 100644
--- a/core/nodejsActionBase/src/service.js
+++ b/core/nodejsActionBase/src/service.js
@@ -156,12 +156,14 @@ function NodeActionService(config) {
     }
 
     function doRun(req) {
-        var msg = req.body || {};
-
-        var props = [ 'api_key', 'namespace', 'action_name', 'activation_id', 'deadline' ];
-        props.map(function (p) {
-            process.env['__OW_' + p.toUpperCase()] = msg[p];
-        });
+        var msg = req && req.body || {};
+        Object.keys(msg).forEach(
+            function (k) {
+                if(typeof msg[k] === 'string' && k !== 'value'){
+                    process.env['__OW_' + k.toUpperCase()] = msg[k];
+                }
+            }
+        );
 
         return userCodeRunner.run(msg.value).then(function(result) {
             if (typeof result !== "object") {


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services