You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/08/13 14:01:00 UTC

[jira] [Commented] (FLINK-10131) Improve logging around ResultSubpartition

    [ https://issues.apache.org/jira/browse/FLINK-10131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578317#comment-16578317 ] 

ASF GitHub Bot commented on FLINK-10131:
----------------------------------------

NicoK opened a new pull request #6547: [FLINK-10131][network] improve logging around subpartitions
URL: https://github.com/apache/flink/pull/6547
 
 
   ## What is the purpose of the change
   
   This PR improves several log messages in `PipelinedSubpartition` and `PipelinedSubpartition`.
   
   ## Brief change log
   
   - add task name
   - add subpartition index
   - bring `SpillableSubpartition` log messages around finishing and releasing it to the same level as `PipelinedSubpartition`
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): **no**
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
     - The serializers: **no**
     - The runtime per-record code paths (performance sensitive): **no**
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
     - The S3 file system connector: **no**
   
   ## Documentation
   
     - Does this pull request introduce a new feature? **no**
     - If yes, how is the feature documented? **not applicable**
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Improve logging around ResultSubpartition
> -----------------------------------------
>
>                 Key: FLINK-10131
>                 URL: https://issues.apache.org/jira/browse/FLINK-10131
>             Project: Flink
>          Issue Type: Improvement
>          Components: Logging, Network
>    Affects Versions: 1.5.2, 1.6.0, 1.7.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>            Priority: Major
>              Labels: pull-request-available
>
> All log messages in {{PipelinedSubpartition}} and {{SpillableSubpartition}} should contain the task name to improve debugging based on log files. Furthermore, subpartition log messages should at least contain their subpartition index to make them distinguishable.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)