You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Chuan Liu (JIRA)" <ji...@apache.org> on 2012/09/04 20:39:07 UTC

[jira] [Created] (HADOOP-8763) Set group owner on Windows failed

Chuan Liu created HADOOP-8763:
---------------------------------

             Summary: Set group owner on Windows failed
                 Key: HADOOP-8763
                 URL: https://issues.apache.org/jira/browse/HADOOP-8763
             Project: Hadoop Common
          Issue Type: Bug
            Reporter: Chuan Liu
            Assignee: Chuan Liu
            Priority: Minor
             Fix For: 1-win


RawLocalFileSystem.setOwner() method may incorrectly set the group owner of a file on Windows.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8763) Set group owner on Windows failed

Posted by "Chuan Liu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13452161#comment-13452161 ] 

Chuan Liu commented on HADOOP-8763:
-----------------------------------

Yes. This matches unix behavior. Previously, we return an error exit code which does not match Unix behavior. We does not match Unix in the case of 'chown [username]*:* [filename]'. I added a note at the end of the usage description.
                
> Set group owner on Windows failed
> ---------------------------------
>
>                 Key: HADOOP-8763
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8763
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Chuan Liu
>            Assignee: Chuan Liu
>            Priority: Minor
>             Fix For: 1-win
>
>         Attachments: HADOOP-8763-branch-1-win-2.patch, HADOOP-8763-branch-1-win.patch
>
>
> RawLocalFileSystem.setOwner() method may incorrectly set the group owner of a file on Windows.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8763) Set group owner on Windows failed

Posted by "Chuan Liu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chuan Liu updated HADOOP-8763:
------------------------------

    Attachment: HADOOP-8763-branch-1-win.patch

Attach a patch.
                
> Set group owner on Windows failed
> ---------------------------------
>
>                 Key: HADOOP-8763
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8763
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Chuan Liu
>            Assignee: Chuan Liu
>            Priority: Minor
>             Fix For: 1-win
>
>         Attachments: HADOOP-8763-branch-1-win.patch
>
>
> RawLocalFileSystem.setOwner() method may incorrectly set the group owner of a file on Windows.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8763) Set group owner on Windows failed

Posted by "Bikas Saha (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13454553#comment-13454553 ] 

Bikas Saha commented on HADOOP-8763:
------------------------------------

The following code seems to be an unrelated change? Also, do you mean BUILDIN or BUILTIN?
{code}
+  // Empty name is invalid. However, LookupAccountName() function will return a
+  // false Sid, i.e. Sid for 'BUILDIN', for an empty name instead failing. We
+  // report the error before calling LookupAccountName() function for this
+  // special case.
+  //
+  if (wcslen(acctName) == 0)
+    return FALSE;
{code}

Do you see any unexpected behavior for users because of the following?
{code}
+On Linux, if a colon but no group name follows the user name, the group of\n\
+the files is changed to that user\'s login group. Windows has no concept of\n\
+a user's login group. So we do not change the group owner in this case.\n",
 program)
{code}
                
> Set group owner on Windows failed
> ---------------------------------
>
>                 Key: HADOOP-8763
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8763
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Chuan Liu
>            Assignee: Chuan Liu
>            Priority: Minor
>             Fix For: 1-win
>
>         Attachments: HADOOP-8763-branch-1-win-2.patch, HADOOP-8763-branch-1-win.patch
>
>
> RawLocalFileSystem.setOwner() method may incorrectly set the group owner of a file on Windows.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8763) Set group owner on Windows failed

Posted by "Vinod Kumar Vavilapalli (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480524#comment-13480524 ] 

Vinod Kumar Vavilapalli commented on HADOOP-8763:
-------------------------------------------------

Hopefully the test works fine.

Checking this in.
                
> Set group owner on Windows failed
> ---------------------------------
>
>                 Key: HADOOP-8763
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8763
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Chuan Liu
>            Assignee: Chuan Liu
>            Priority: Minor
>             Fix For: 1-win
>
>         Attachments: HADOOP-8763-branch-1-win-2.patch, HADOOP-8763-branch-1-win-3.patch, HADOOP-8763-branch-1-win-4.patch, HADOOP-8763-branch-1-win.patch
>
>
> RawLocalFileSystem.setOwner() method may incorrectly set the group owner of a file on Windows.
> Specifically the following function in RawLocalFileSystem class will fail on Windows when username is null, i.e. only set group ownership.
> {code}
> public void setOwner(Path p, String username, String groupname)
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8763) Set group owner on Windows failed

Posted by "Vinod Kumar Vavilapalli (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455156#comment-13455156 ] 

Vinod Kumar Vavilapalli commented on HADOOP-8763:
-------------------------------------------------

We can just leave around the public constant Shell.SET_GROUP_COMMAND or deprecate it. I am okay leaving it around.

Not sure of your usage of asserts vs exit-code, but in src/winutils/chown.c, instead of asserts for zero-length string, we should log a msg to stderr and return an EXIT_FAILURE? Also, if both are empty also you should return EXIT_FAILURE?

bq. +On Linux, if a colon but no group name follows the user name, the group of\n\
+the files is changed to that user\'s login group.
This code won't be invoked on linux, because, ahm, this is winutils? In any case, that is not behaviour I know, a "chown user: filename" shouldn't change the group-name
                
> Set group owner on Windows failed
> ---------------------------------
>
>                 Key: HADOOP-8763
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8763
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Chuan Liu
>            Assignee: Chuan Liu
>            Priority: Minor
>             Fix For: 1-win
>
>         Attachments: HADOOP-8763-branch-1-win-2.patch, HADOOP-8763-branch-1-win.patch
>
>
> RawLocalFileSystem.setOwner() method may incorrectly set the group owner of a file on Windows.
> Specifically the following function in RawLocalFileSystem class will fail on Windows when username is null, i.e. only set group ownership.
> {code}
> public void setOwner(Path p, String username, String groupname)
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (HADOOP-8763) Set group owner on Windows failed

Posted by "Vinod Kumar Vavilapalli (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vinod Kumar Vavilapalli resolved HADOOP-8763.
---------------------------------------------

      Resolution: Fixed
    Hadoop Flags: Reviewed

I just committed this to branch-1-win. Thanks Chuan!
                
> Set group owner on Windows failed
> ---------------------------------
>
>                 Key: HADOOP-8763
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8763
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Chuan Liu
>            Assignee: Chuan Liu
>            Priority: Minor
>             Fix For: 1-win
>
>         Attachments: HADOOP-8763-branch-1-win-2.patch, HADOOP-8763-branch-1-win-3.patch, HADOOP-8763-branch-1-win-4.patch, HADOOP-8763-branch-1-win.patch
>
>
> RawLocalFileSystem.setOwner() method may incorrectly set the group owner of a file on Windows.
> Specifically the following function in RawLocalFileSystem class will fail on Windows when username is null, i.e. only set group ownership.
> {code}
> public void setOwner(Path p, String username, String groupname)
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8763) Set group owner on Windows failed

Posted by "Ivan Mitic (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13451630#comment-13451630 ] 

Ivan Mitic commented on HADOOP-8763:
------------------------------------

Thanks Chuan, patch looks good, +1

I see that {{winutils chown}} now allows both user and group to be empty, is that to match the unix behavior?
                
> Set group owner on Windows failed
> ---------------------------------
>
>                 Key: HADOOP-8763
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8763
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Chuan Liu
>            Assignee: Chuan Liu
>            Priority: Minor
>             Fix For: 1-win
>
>         Attachments: HADOOP-8763-branch-1-win-2.patch, HADOOP-8763-branch-1-win.patch
>
>
> RawLocalFileSystem.setOwner() method may incorrectly set the group owner of a file on Windows.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8763) Set group owner on Windows failed

Posted by "Chuan Liu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chuan Liu updated HADOOP-8763:
------------------------------

    Attachment: HADOOP-8763-branch-1-win-3.patch
    
> Set group owner on Windows failed
> ---------------------------------
>
>                 Key: HADOOP-8763
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8763
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Chuan Liu
>            Assignee: Chuan Liu
>            Priority: Minor
>             Fix For: 1-win
>
>         Attachments: HADOOP-8763-branch-1-win-2.patch, HADOOP-8763-branch-1-win-3.patch, HADOOP-8763-branch-1-win.patch
>
>
> RawLocalFileSystem.setOwner() method may incorrectly set the group owner of a file on Windows.
> Specifically the following function in RawLocalFileSystem class will fail on Windows when username is null, i.e. only set group ownership.
> {code}
> public void setOwner(Path p, String username, String groupname)
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8763) Set group owner on Windows failed

Posted by "Vinod Kumar Vavilapalli (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480426#comment-13480426 ] 

Vinod Kumar Vavilapalli commented on HADOOP-8763:
-------------------------------------------------

Thanks for the update, Chuan. I had to very carefully read your comments and chown page to understand what you said :)

bq.  I have left out this in new patch.
+1

Seems like common.c has disappeared in the mean while, can you update the patch? Tx.
                
> Set group owner on Windows failed
> ---------------------------------
>
>                 Key: HADOOP-8763
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8763
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Chuan Liu
>            Assignee: Chuan Liu
>            Priority: Minor
>             Fix For: 1-win
>
>         Attachments: HADOOP-8763-branch-1-win-2.patch, HADOOP-8763-branch-1-win-3.patch, HADOOP-8763-branch-1-win.patch
>
>
> RawLocalFileSystem.setOwner() method may incorrectly set the group owner of a file on Windows.
> Specifically the following function in RawLocalFileSystem class will fail on Windows when username is null, i.e. only set group ownership.
> {code}
> public void setOwner(Path p, String username, String groupname)
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8763) Set group owner on Windows failed

Posted by "Chuan Liu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13452171#comment-13452171 ] 

Chuan Liu commented on HADOOP-8763:
-----------------------------------

>What is the problem this patch is trying to solve? An example would be good.

The following function in RawLocalFileSystem class will fail on Windows when username is null, i.e. only set group ownership.
{noformat} 
public void setOwner(Path p, String username, String groupname)
{noformat} 
                
> Set group owner on Windows failed
> ---------------------------------
>
>                 Key: HADOOP-8763
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8763
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Chuan Liu
>            Assignee: Chuan Liu
>            Priority: Minor
>             Fix For: 1-win
>
>         Attachments: HADOOP-8763-branch-1-win-2.patch, HADOOP-8763-branch-1-win.patch
>
>
> RawLocalFileSystem.setOwner() method may incorrectly set the group owner of a file on Windows.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8763) Set group owner on Windows failed

Posted by "Ivan Mitic (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13450259#comment-13450259 ] 

Ivan Mitic commented on HADOOP-8763:
------------------------------------

Change looks great Chuan.

Two minor comments:
1. FileUtil#setOwner As this is a public api, it would be good to note that username and groupname cannot both be null.
2. FIleUtil.java:747 It seems that you moved a comment one line up.
                
> Set group owner on Windows failed
> ---------------------------------
>
>                 Key: HADOOP-8763
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8763
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Chuan Liu
>            Assignee: Chuan Liu
>            Priority: Minor
>             Fix For: 1-win
>
>         Attachments: HADOOP-8763-branch-1-win.patch
>
>
> RawLocalFileSystem.setOwner() method may incorrectly set the group owner of a file on Windows.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8763) Set group owner on Windows failed

Posted by "Bikas Saha (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13452154#comment-13452154 ] 

Bikas Saha commented on HADOOP-8763:
------------------------------------

What is the problem this patch is trying to solve? An example would be good.
                
> Set group owner on Windows failed
> ---------------------------------
>
>                 Key: HADOOP-8763
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8763
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Chuan Liu
>            Assignee: Chuan Liu
>            Priority: Minor
>             Fix For: 1-win
>
>         Attachments: HADOOP-8763-branch-1-win-2.patch, HADOOP-8763-branch-1-win.patch
>
>
> RawLocalFileSystem.setOwner() method may incorrectly set the group owner of a file on Windows.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8763) Set group owner on Windows failed

Posted by "Chuan Liu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chuan Liu updated HADOOP-8763:
------------------------------

    Attachment: HADOOP-8763-branch-1-win-4.patch

Upload a new patch reflecting the change in HADOOP-8908, in which 'common.c' was renamed to 'libwinutils.c'.
                
> Set group owner on Windows failed
> ---------------------------------
>
>                 Key: HADOOP-8763
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8763
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Chuan Liu
>            Assignee: Chuan Liu
>            Priority: Minor
>             Fix For: 1-win
>
>         Attachments: HADOOP-8763-branch-1-win-2.patch, HADOOP-8763-branch-1-win-3.patch, HADOOP-8763-branch-1-win-4.patch, HADOOP-8763-branch-1-win.patch
>
>
> RawLocalFileSystem.setOwner() method may incorrectly set the group owner of a file on Windows.
> Specifically the following function in RawLocalFileSystem class will fail on Windows when username is null, i.e. only set group ownership.
> {code}
> public void setOwner(Path p, String username, String groupname)
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8763) Set group owner on Windows failed

Posted by "Vinod Kumar Vavilapalli (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vinod Kumar Vavilapalli updated HADOOP-8763:
--------------------------------------------

    Description: 
RawLocalFileSystem.setOwner() method may incorrectly set the group owner of a file on Windows.

Specifically the following function in RawLocalFileSystem class will fail on Windows when username is null, i.e. only set group ownership.
{code}
public void setOwner(Path p, String username, String groupname)
{code}


  was:RawLocalFileSystem.setOwner() method may incorrectly set the group owner of a file on Windows.

    
> Set group owner on Windows failed
> ---------------------------------
>
>                 Key: HADOOP-8763
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8763
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Chuan Liu
>            Assignee: Chuan Liu
>            Priority: Minor
>             Fix For: 1-win
>
>         Attachments: HADOOP-8763-branch-1-win-2.patch, HADOOP-8763-branch-1-win.patch
>
>
> RawLocalFileSystem.setOwner() method may incorrectly set the group owner of a file on Windows.
> Specifically the following function in RawLocalFileSystem class will fail on Windows when username is null, i.e. only set group ownership.
> {code}
> public void setOwner(Path p, String username, String groupname)
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8763) Set group owner on Windows failed

Posted by "Chuan Liu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457240#comment-13457240 ] 

Chuan Liu commented on HADOOP-8763:
-----------------------------------

>The following code seems to be an unrelated change? Also, do you mean BUILDIN or BUILTIN?

You are right. It should be BUILTIN. This code is relevant in the sense it makes the function less prone to potential errors, which is used by 'winutils chown'.

>Do you see any unexpected behavior for users because of the following?

No. I did not see any unexpected behavior. This is just for future references.

>We can just leave around the public constant Shell.SET_GROUP_COMMAND or deprecate it. I am okay leaving it around.
I have left out this in new patch.

>Not sure of your usage of asserts vs exit-code, but in src/winutils/chown.c, instead of asserts for zero-length string, we should log a msg to stderr and return an EXIT_FAILURE? Also, if both are empty also you should return EXIT_FAILURE?

The assertions assert for previous parsing code. The parsing code will not initiate and allocate memory for 'userName' and 'groupName' of zero-length, i.e. 'userName' and 'groupName' are initiated or NULL in such cases. We should not return error in such cases because 'chown : file' is a correct usage here, though no user name or group name is given.

>This code won't be invoked on linux, because, ahm, this is winutils? In any case, that is not behaviour I know, a "chown user: filename" shouldn't change the group-name

I have tested the Linux behaviors. You can also check out the man page of 'chown': http://linux.die.net/man/1/chown
Again, as my answer to Bikas's question, this usage pattern is not found in Hadoop on Linux or Windows that I am aware of. I think it is good to document the difference here for future reference.

                
> Set group owner on Windows failed
> ---------------------------------
>
>                 Key: HADOOP-8763
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8763
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Chuan Liu
>            Assignee: Chuan Liu
>            Priority: Minor
>             Fix For: 1-win
>
>         Attachments: HADOOP-8763-branch-1-win-2.patch, HADOOP-8763-branch-1-win.patch
>
>
> RawLocalFileSystem.setOwner() method may incorrectly set the group owner of a file on Windows.
> Specifically the following function in RawLocalFileSystem class will fail on Windows when username is null, i.e. only set group ownership.
> {code}
> public void setOwner(Path p, String username, String groupname)
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8763) Set group owner on Windows failed

Posted by "Chuan Liu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chuan Liu updated HADOOP-8763:
------------------------------

    Attachment: HADOOP-8763-branch-1-win-2.patch

Attach a new patch addressing Ivan's comments.
                
> Set group owner on Windows failed
> ---------------------------------
>
>                 Key: HADOOP-8763
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8763
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Chuan Liu
>            Assignee: Chuan Liu
>            Priority: Minor
>             Fix For: 1-win
>
>         Attachments: HADOOP-8763-branch-1-win-2.patch, HADOOP-8763-branch-1-win.patch
>
>
> RawLocalFileSystem.setOwner() method may incorrectly set the group owner of a file on Windows.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira