You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/09 11:36:33 UTC
[GitHub] [flink] slinkydeveloper opened a new pull request #19020: [FLINK-XXX][table] Flip legacy casting to disable by default
slinkydeveloper opened a new pull request #19020:
URL: https://github.com/apache/flink/pull/19020
## What is the purpose of the change
This PR flips the legacy cast behavior to DISABLED by default. For details about the discussion, see https://lists.apache.org/thread/r13y3plwwyg3sngh8cz47flogq621txv.
It includes a couple of test fixes for tests relying on the bad behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19020: [FLINK-26551][table] Flip legacy casting to disable by default
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19020:
URL: https://github.com/apache/flink/pull/19020#issuecomment-1062833750
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "91b6e51ce99dc6f74161a657897a6f8476ad68b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32742",
"triggerID" : "91b6e51ce99dc6f74161a657897a6f8476ad68b0",
"triggerType" : "PUSH"
}, {
"hash" : "e16c14406fad0e2693e9e86f21ba3376e3ba743e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32753",
"triggerID" : "e16c14406fad0e2693e9e86f21ba3376e3ba743e",
"triggerType" : "PUSH"
}, {
"hash" : "c13f1a14f6ae980b8169441e532f400260945f27",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32819",
"triggerID" : "c13f1a14f6ae980b8169441e532f400260945f27",
"triggerType" : "PUSH"
}, {
"hash" : "322ad412390cb2ce36b2116129ec3d708623d39a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "322ad412390cb2ce36b2116129ec3d708623d39a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e16c14406fad0e2693e9e86f21ba3376e3ba743e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32753)
* c13f1a14f6ae980b8169441e532f400260945f27 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32819)
* 322ad412390cb2ce36b2116129ec3d708623d39a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] matriv commented on a change in pull request #19020: [FLINK-26551][table] Flip legacy casting to disable by default
Posted by GitBox <gi...@apache.org>.
matriv commented on a change in pull request #19020:
URL: https://github.com/apache/flink/pull/19020#discussion_r822684289
##########
File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/table/KafkaTableITCase.java
##########
@@ -299,29 +301,20 @@ public void testKafkaSourceSinkWithMetadata() throws Exception {
+ " %s\n"
+ ")",
topic, bootstraps, groupId, formatOptions());
-
tEnv.executeSql(createTable);
String initialValues =
"INSERT INTO kafka\n"
+ "VALUES\n"
- + " ('data 1', 1, TIMESTAMP '2020-03-08 13:12:11.123', MAP['k1', X'C0FFEE', 'k2', X'BABE'], TRUE),\n"
+ + " ('data 1', 1, TIMESTAMP '2020-03-08 13:12:11.123', MAP['k1', x'C0FFEE', 'k2', x'BABE01'], TRUE),\n"
Review comment:
This is not needed, please revert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19020: [FLINK-26551][table] Flip legacy casting to disable by default
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19020:
URL: https://github.com/apache/flink/pull/19020#issuecomment-1062833750
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "91b6e51ce99dc6f74161a657897a6f8476ad68b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32742",
"triggerID" : "91b6e51ce99dc6f74161a657897a6f8476ad68b0",
"triggerType" : "PUSH"
}, {
"hash" : "e16c14406fad0e2693e9e86f21ba3376e3ba743e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32753",
"triggerID" : "e16c14406fad0e2693e9e86f21ba3376e3ba743e",
"triggerType" : "PUSH"
}, {
"hash" : "c13f1a14f6ae980b8169441e532f400260945f27",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32819",
"triggerID" : "c13f1a14f6ae980b8169441e532f400260945f27",
"triggerType" : "PUSH"
}, {
"hash" : "322ad412390cb2ce36b2116129ec3d708623d39a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32839",
"triggerID" : "322ad412390cb2ce36b2116129ec3d708623d39a",
"triggerType" : "PUSH"
}, {
"hash" : "b7c8bf59b4fc3c7b847533b1e665b48b842930c9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32860",
"triggerID" : "b7c8bf59b4fc3c7b847533b1e665b48b842930c9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b7c8bf59b4fc3c7b847533b1e665b48b842930c9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32860)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19020: [FLINK-26551][table] Flip legacy casting to disable by default
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19020:
URL: https://github.com/apache/flink/pull/19020#issuecomment-1062833750
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "91b6e51ce99dc6f74161a657897a6f8476ad68b0",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32742",
"triggerID" : "91b6e51ce99dc6f74161a657897a6f8476ad68b0",
"triggerType" : "PUSH"
}, {
"hash" : "e16c14406fad0e2693e9e86f21ba3376e3ba743e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32753",
"triggerID" : "e16c14406fad0e2693e9e86f21ba3376e3ba743e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 91b6e51ce99dc6f74161a657897a6f8476ad68b0 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32742)
* e16c14406fad0e2693e9e86f21ba3376e3ba743e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32753)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19020: [FLINK-26551][table] Flip legacy casting to disable by default
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19020:
URL: https://github.com/apache/flink/pull/19020#issuecomment-1062833750
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "91b6e51ce99dc6f74161a657897a6f8476ad68b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32742",
"triggerID" : "91b6e51ce99dc6f74161a657897a6f8476ad68b0",
"triggerType" : "PUSH"
}, {
"hash" : "e16c14406fad0e2693e9e86f21ba3376e3ba743e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32753",
"triggerID" : "e16c14406fad0e2693e9e86f21ba3376e3ba743e",
"triggerType" : "PUSH"
}, {
"hash" : "c13f1a14f6ae980b8169441e532f400260945f27",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32819",
"triggerID" : "c13f1a14f6ae980b8169441e532f400260945f27",
"triggerType" : "PUSH"
}, {
"hash" : "322ad412390cb2ce36b2116129ec3d708623d39a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32839",
"triggerID" : "322ad412390cb2ce36b2116129ec3d708623d39a",
"triggerType" : "PUSH"
}, {
"hash" : "b7c8bf59b4fc3c7b847533b1e665b48b842930c9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32860",
"triggerID" : "b7c8bf59b4fc3c7b847533b1e665b48b842930c9",
"triggerType" : "PUSH"
}, {
"hash" : "ac7bb9bc4f9d49db28df7ebb1a9de59aab7e0baa",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32891",
"triggerID" : "ac7bb9bc4f9d49db28df7ebb1a9de59aab7e0baa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b7c8bf59b4fc3c7b847533b1e665b48b842930c9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32860)
* ac7bb9bc4f9d49db28df7ebb1a9de59aab7e0baa Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32891)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19020: [FLINK-26551][table] Flip legacy casting to disable by default
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19020:
URL: https://github.com/apache/flink/pull/19020#issuecomment-1062833750
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "91b6e51ce99dc6f74161a657897a6f8476ad68b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32742",
"triggerID" : "91b6e51ce99dc6f74161a657897a6f8476ad68b0",
"triggerType" : "PUSH"
}, {
"hash" : "e16c14406fad0e2693e9e86f21ba3376e3ba743e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32753",
"triggerID" : "e16c14406fad0e2693e9e86f21ba3376e3ba743e",
"triggerType" : "PUSH"
}, {
"hash" : "c13f1a14f6ae980b8169441e532f400260945f27",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32819",
"triggerID" : "c13f1a14f6ae980b8169441e532f400260945f27",
"triggerType" : "PUSH"
}, {
"hash" : "322ad412390cb2ce36b2116129ec3d708623d39a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32839",
"triggerID" : "322ad412390cb2ce36b2116129ec3d708623d39a",
"triggerType" : "PUSH"
}, {
"hash" : "b7c8bf59b4fc3c7b847533b1e665b48b842930c9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32860",
"triggerID" : "b7c8bf59b4fc3c7b847533b1e665b48b842930c9",
"triggerType" : "PUSH"
}, {
"hash" : "ac7bb9bc4f9d49db28df7ebb1a9de59aab7e0baa",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ac7bb9bc4f9d49db28df7ebb1a9de59aab7e0baa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b7c8bf59b4fc3c7b847533b1e665b48b842930c9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32860)
* ac7bb9bc4f9d49db28df7ebb1a9de59aab7e0baa UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19020: [FLINK-26551][table] Flip legacy casting to disable by default
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19020:
URL: https://github.com/apache/flink/pull/19020#issuecomment-1062833750
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "91b6e51ce99dc6f74161a657897a6f8476ad68b0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32742",
"triggerID" : "91b6e51ce99dc6f74161a657897a6f8476ad68b0",
"triggerType" : "PUSH"
}, {
"hash" : "e16c14406fad0e2693e9e86f21ba3376e3ba743e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e16c14406fad0e2693e9e86f21ba3376e3ba743e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 91b6e51ce99dc6f74161a657897a6f8476ad68b0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32742)
* e16c14406fad0e2693e9e86f21ba3376e3ba743e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19020: [FLINK-26551][table] Flip legacy casting to disable by default
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19020:
URL: https://github.com/apache/flink/pull/19020#issuecomment-1062833750
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "91b6e51ce99dc6f74161a657897a6f8476ad68b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32742",
"triggerID" : "91b6e51ce99dc6f74161a657897a6f8476ad68b0",
"triggerType" : "PUSH"
}, {
"hash" : "e16c14406fad0e2693e9e86f21ba3376e3ba743e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32753",
"triggerID" : "e16c14406fad0e2693e9e86f21ba3376e3ba743e",
"triggerType" : "PUSH"
}, {
"hash" : "c13f1a14f6ae980b8169441e532f400260945f27",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32819",
"triggerID" : "c13f1a14f6ae980b8169441e532f400260945f27",
"triggerType" : "PUSH"
}, {
"hash" : "322ad412390cb2ce36b2116129ec3d708623d39a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32839",
"triggerID" : "322ad412390cb2ce36b2116129ec3d708623d39a",
"triggerType" : "PUSH"
}, {
"hash" : "b7c8bf59b4fc3c7b847533b1e665b48b842930c9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32860",
"triggerID" : "b7c8bf59b4fc3c7b847533b1e665b48b842930c9",
"triggerType" : "PUSH"
}, {
"hash" : "ac7bb9bc4f9d49db28df7ebb1a9de59aab7e0baa",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32891",
"triggerID" : "ac7bb9bc4f9d49db28df7ebb1a9de59aab7e0baa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ac7bb9bc4f9d49db28df7ebb1a9de59aab7e0baa Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32891)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19020: [FLINK-XXX][table] Flip legacy casting to disable by default
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19020:
URL: https://github.com/apache/flink/pull/19020#issuecomment-1062833750
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "91b6e51ce99dc6f74161a657897a6f8476ad68b0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32742",
"triggerID" : "91b6e51ce99dc6f74161a657897a6f8476ad68b0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 91b6e51ce99dc6f74161a657897a6f8476ad68b0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32742)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19020: [FLINK-26551][table] Flip legacy casting to disable by default
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19020:
URL: https://github.com/apache/flink/pull/19020#issuecomment-1062833750
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "91b6e51ce99dc6f74161a657897a6f8476ad68b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32742",
"triggerID" : "91b6e51ce99dc6f74161a657897a6f8476ad68b0",
"triggerType" : "PUSH"
}, {
"hash" : "e16c14406fad0e2693e9e86f21ba3376e3ba743e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32753",
"triggerID" : "e16c14406fad0e2693e9e86f21ba3376e3ba743e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e16c14406fad0e2693e9e86f21ba3376e3ba743e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32753)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on a change in pull request #19020: [FLINK-XXX][table] Flip legacy casting to disable by default
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on a change in pull request #19020:
URL: https://github.com/apache/flink/pull/19020#discussion_r822558605
##########
File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/table/KafkaTableITCase.java
##########
@@ -299,29 +301,20 @@ public void testKafkaSourceSinkWithMetadata() throws Exception {
+ " %s\n"
+ ")",
topic, bootstraps, groupId, formatOptions());
-
tEnv.executeSql(createTable);
String initialValues =
"INSERT INTO kafka\n"
+ "VALUES\n"
- + " ('data 1', 1, TIMESTAMP '2020-03-08 13:12:11.123', MAP['k1', X'C0FFEE', 'k2', X'BABE'], TRUE),\n"
+ + " ('data 1', 1, TIMESTAMP '2020-03-08 13:12:11.123', MAP['k1', x'C0FFEE', 'k2', x'BABE01'], TRUE),\n"
+ " ('data 2', 2, TIMESTAMP '2020-03-09 13:12:11.123', CAST(NULL AS MAP<STRING, BYTES>), FALSE),\n"
- + " ('data 3', 3, TIMESTAMP '2020-03-10 13:12:11.123', MAP['k1', X'10', 'k2', X'20'], TRUE)";
+ + " ('data 3', 3, TIMESTAMP '2020-03-10 13:12:11.123', MAP['k1', X'102030', 'k2', X'203040'], TRUE)";
Review comment:
For more details about this, check https://issues.apache.org/jira/browse/FLINK-26549. The legacy behavior hide this issue, as no trimming and padding is performed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19020: [FLINK-XXX][table] Flip legacy casting to disable by default
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #19020:
URL: https://github.com/apache/flink/pull/19020#issuecomment-1062833750
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "91b6e51ce99dc6f74161a657897a6f8476ad68b0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "91b6e51ce99dc6f74161a657897a6f8476ad68b0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 91b6e51ce99dc6f74161a657897a6f8476ad68b0 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19020: [FLINK-26551][table] Flip legacy casting to disable by default
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19020:
URL: https://github.com/apache/flink/pull/19020#issuecomment-1062833750
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "91b6e51ce99dc6f74161a657897a6f8476ad68b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32742",
"triggerID" : "91b6e51ce99dc6f74161a657897a6f8476ad68b0",
"triggerType" : "PUSH"
}, {
"hash" : "e16c14406fad0e2693e9e86f21ba3376e3ba743e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32753",
"triggerID" : "e16c14406fad0e2693e9e86f21ba3376e3ba743e",
"triggerType" : "PUSH"
}, {
"hash" : "c13f1a14f6ae980b8169441e532f400260945f27",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c13f1a14f6ae980b8169441e532f400260945f27",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e16c14406fad0e2693e9e86f21ba3376e3ba743e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32753)
* c13f1a14f6ae980b8169441e532f400260945f27 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr closed pull request #19020: [FLINK-26551][table] Flip legacy casting to disable by default
Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #19020:
URL: https://github.com/apache/flink/pull/19020
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on a change in pull request #19020: [FLINK-26551][table] Flip legacy casting to disable by default
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on a change in pull request #19020:
URL: https://github.com/apache/flink/pull/19020#discussion_r822689482
##########
File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/table/KafkaTableITCase.java
##########
@@ -299,29 +301,20 @@ public void testKafkaSourceSinkWithMetadata() throws Exception {
+ " %s\n"
+ ")",
topic, bootstraps, groupId, formatOptions());
-
tEnv.executeSql(createTable);
String initialValues =
"INSERT INTO kafka\n"
+ "VALUES\n"
- + " ('data 1', 1, TIMESTAMP '2020-03-08 13:12:11.123', MAP['k1', X'C0FFEE', 'k2', X'BABE'], TRUE),\n"
+ + " ('data 1', 1, TIMESTAMP '2020-03-08 13:12:11.123', MAP['k1', x'C0FFEE', 'k2', x'BABE01'], TRUE),\n"
Review comment:
the `BABE01` is unfortunately needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19020: [FLINK-26551][table] Flip legacy casting to disable by default
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19020:
URL: https://github.com/apache/flink/pull/19020#issuecomment-1062833750
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "91b6e51ce99dc6f74161a657897a6f8476ad68b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32742",
"triggerID" : "91b6e51ce99dc6f74161a657897a6f8476ad68b0",
"triggerType" : "PUSH"
}, {
"hash" : "e16c14406fad0e2693e9e86f21ba3376e3ba743e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32753",
"triggerID" : "e16c14406fad0e2693e9e86f21ba3376e3ba743e",
"triggerType" : "PUSH"
}, {
"hash" : "c13f1a14f6ae980b8169441e532f400260945f27",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32819",
"triggerID" : "c13f1a14f6ae980b8169441e532f400260945f27",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e16c14406fad0e2693e9e86f21ba3376e3ba743e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32753)
* c13f1a14f6ae980b8169441e532f400260945f27 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32819)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19020: [FLINK-26551][table] Flip legacy casting to disable by default
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19020:
URL: https://github.com/apache/flink/pull/19020#issuecomment-1062833750
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "91b6e51ce99dc6f74161a657897a6f8476ad68b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32742",
"triggerID" : "91b6e51ce99dc6f74161a657897a6f8476ad68b0",
"triggerType" : "PUSH"
}, {
"hash" : "e16c14406fad0e2693e9e86f21ba3376e3ba743e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32753",
"triggerID" : "e16c14406fad0e2693e9e86f21ba3376e3ba743e",
"triggerType" : "PUSH"
}, {
"hash" : "c13f1a14f6ae980b8169441e532f400260945f27",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32819",
"triggerID" : "c13f1a14f6ae980b8169441e532f400260945f27",
"triggerType" : "PUSH"
}, {
"hash" : "322ad412390cb2ce36b2116129ec3d708623d39a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32839",
"triggerID" : "322ad412390cb2ce36b2116129ec3d708623d39a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c13f1a14f6ae980b8169441e532f400260945f27 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32819)
* 322ad412390cb2ce36b2116129ec3d708623d39a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32839)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19020: [FLINK-26551][table] Flip legacy casting to disable by default
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19020:
URL: https://github.com/apache/flink/pull/19020#issuecomment-1062833750
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "91b6e51ce99dc6f74161a657897a6f8476ad68b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32742",
"triggerID" : "91b6e51ce99dc6f74161a657897a6f8476ad68b0",
"triggerType" : "PUSH"
}, {
"hash" : "e16c14406fad0e2693e9e86f21ba3376e3ba743e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32753",
"triggerID" : "e16c14406fad0e2693e9e86f21ba3376e3ba743e",
"triggerType" : "PUSH"
}, {
"hash" : "c13f1a14f6ae980b8169441e532f400260945f27",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32819",
"triggerID" : "c13f1a14f6ae980b8169441e532f400260945f27",
"triggerType" : "PUSH"
}, {
"hash" : "322ad412390cb2ce36b2116129ec3d708623d39a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32839",
"triggerID" : "322ad412390cb2ce36b2116129ec3d708623d39a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 322ad412390cb2ce36b2116129ec3d708623d39a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32839)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19020: [FLINK-26551][table] Flip legacy casting to disable by default
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19020:
URL: https://github.com/apache/flink/pull/19020#issuecomment-1062833750
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "91b6e51ce99dc6f74161a657897a6f8476ad68b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32742",
"triggerID" : "91b6e51ce99dc6f74161a657897a6f8476ad68b0",
"triggerType" : "PUSH"
}, {
"hash" : "e16c14406fad0e2693e9e86f21ba3376e3ba743e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32753",
"triggerID" : "e16c14406fad0e2693e9e86f21ba3376e3ba743e",
"triggerType" : "PUSH"
}, {
"hash" : "c13f1a14f6ae980b8169441e532f400260945f27",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32819",
"triggerID" : "c13f1a14f6ae980b8169441e532f400260945f27",
"triggerType" : "PUSH"
}, {
"hash" : "322ad412390cb2ce36b2116129ec3d708623d39a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32839",
"triggerID" : "322ad412390cb2ce36b2116129ec3d708623d39a",
"triggerType" : "PUSH"
}, {
"hash" : "b7c8bf59b4fc3c7b847533b1e665b48b842930c9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b7c8bf59b4fc3c7b847533b1e665b48b842930c9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 322ad412390cb2ce36b2116129ec3d708623d39a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32839)
* b7c8bf59b4fc3c7b847533b1e665b48b842930c9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org