You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicemix.apache.org by "Ron Gavlin (JIRA)" <ji...@apache.org> on 2009/01/10 11:32:59 UTC
[jira] Created: (SM-1760) smx-jms provider should defer the
creation of a temporary replyTo destination until is receives a mep that
requires one
smx-jms provider should defer the creation of a temporary replyTo destination until is receives a mep that requires one
-----------------------------------------------------------------------------------------------------------------------
Key: SM-1760
URL: https://issues.apache.org/activemq/browse/SM-1760
Project: ServiceMix
Issue Type: Bug
Components: servicemix-jms
Affects Versions: servicemix-jms-2008.01
Reporter: Ron Gavlin
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SM-1760) smx-jms provider should not create a
temporary replyTo destination unless one is needed
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48631#action_48631 ]
Guillaume Nodet commented on SM-1760:
-------------------------------------
The patch includes the following:
* defer the creation of the container listener until actually needed (an InOut exchange with the default replyTo destination)
* do not resolve destination names at startup time
* do not create temporary queue until actually needed
Sending src/main/java/org/apache/servicemix/jms/endpoints/JmsProviderEndpoint.java
Sending src/test/java/org/apache/servicemix/jms/JmsProviderEndpointTest.java
Transmitting file data ..
Committed revision 733850.
> smx-jms provider should not create a temporary replyTo destination unless one is needed
> ---------------------------------------------------------------------------------------
>
> Key: SM-1760
> URL: https://issues.apache.org/activemq/browse/SM-1760
> Project: ServiceMix
> Issue Type: Bug
> Components: servicemix-jms
> Affects Versions: servicemix-jms-2008.01
> Reporter: Ron Gavlin
> Assignee: Guillaume Nodet
>
> After the recent patch for SM-1621, the smx-jms provider now always attempts to create a temporary replyTo destination if no replyTo destination is provided. In the case of a "stateless" in-only ME for which no JBI DONE/ERROR reply is expected, this does not seem correct.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (SM-1760) smx-jms provider should not
create a temporary replyTo destination unless one is needed
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48675#action_48675 ]
ffang edited comment on SM-1760 at 1/13/09 9:57 PM:
-----------------------------------------------------------
with this patch applied, the JmsProviderEndpointTest test will always hang at receive response message at
JmsTemplate.doReceive(Session session, MessageConsumer consumer) {
...
message = consumer.receive();
}
The problem comes from that this patch didn't create listenerContainer for temporary replyDest.
To avoid create unnecessary temporary replyDest for InOnly, we can defer the temporary replyDest creation in ProcessInOut, but not the endpoint activate.
create ticket SM-1764 to track the hanging test
was (Author: ffang):
with this patch applied, the JmsProviderEndpointTest test will always hang at receive response message at
JmsTemplate.doReceive(Session session, MessageConsumer consumer) {
...
message = consumer.receive();
}
The problem comes from that this patch didn't create listenerContainer for temporary replyDest.
To avoid create unnecessary temporary replyDest for InOnly, we can defer the temporary replyDest creation in ProcessInOut, but not the endpoint activate.
> smx-jms provider should not create a temporary replyTo destination unless one is needed
> ---------------------------------------------------------------------------------------
>
> Key: SM-1760
> URL: https://issues.apache.org/activemq/browse/SM-1760
> Project: ServiceMix
> Issue Type: Bug
> Components: servicemix-jms
> Affects Versions: servicemix-jms-2008.01
> Reporter: Ron Gavlin
> Assignee: Guillaume Nodet
> Fix For: servicemix-jms-2008.02, 3.3.1
>
>
> After the recent patch for SM-1621, the smx-jms provider now always attempts to create a temporary replyTo destination if no replyTo destination is provided. In the case of a "stateless" in-only ME for which no JBI DONE/ERROR reply is expected, this does not seem correct.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SM-1760) smx-jms provider should not create a
temporary replyTo destination unless one is needed
Posted by "Ron Gavlin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ron Gavlin updated SM-1760:
---------------------------
Description:
After the recent patch for SM-1621, the smx-jms provider now always attempts to create a temporary replyTo destination if no replyTo destination is provided. In the case of a "stateless" in-only ME for which no JBI DONE/ERROR reply is expected, this does not seem correct.
was:
After the recent patch for SM-1681, the smx-jms provider now always attempts to create a temporary replyTo destination if no replyTo destination is provided. In the case of a "stateless" in-only ME for which no JBI DONE/ERROR reply is expected, this does not seem correct.
> smx-jms provider should not create a temporary replyTo destination unless one is needed
> ---------------------------------------------------------------------------------------
>
> Key: SM-1760
> URL: https://issues.apache.org/activemq/browse/SM-1760
> Project: ServiceMix
> Issue Type: Bug
> Components: servicemix-jms
> Affects Versions: servicemix-jms-2008.01
> Reporter: Ron Gavlin
>
> After the recent patch for SM-1621, the smx-jms provider now always attempts to create a temporary replyTo destination if no replyTo destination is provided. In the case of a "stateless" in-only ME for which no JBI DONE/ERROR reply is expected, this does not seem correct.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SM-1760) smx-jms provider should defer the
creation of a temporary replyTo destination until it receives a ME w/a mep
that requires one
Posted by "Ron Gavlin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ron Gavlin updated SM-1760:
---------------------------
Summary: smx-jms provider should defer the creation of a temporary replyTo destination until it receives a ME w/a mep that requires one (was: smx-jms provider should defer the creation of a temporary replyTo destination until is receives a mep that requires one)
> smx-jms provider should defer the creation of a temporary replyTo destination until it receives a ME w/a mep that requires one
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: SM-1760
> URL: https://issues.apache.org/activemq/browse/SM-1760
> Project: ServiceMix
> Issue Type: Bug
> Components: servicemix-jms
> Affects Versions: servicemix-jms-2008.01
> Reporter: Ron Gavlin
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (SM-1760) smx-jms provider should not
create a temporary replyTo destination unless one is needed
Posted by "Ron Gavlin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48633#action_48633 ]
rgavlin edited comment on SM-1760 at 1/12/09 12:59 PM:
----------------------------------------------------------
Hi Guillaume,
Thanks for the patch. Would it be possible to backport this change to the SMX 3.2.x branch?
Thanks,
/Ron
was (Author: rgavlin):
Hi Guillaume,
Would it be possible to backport this change to the SMX 3.2.x branch?
Thanks,
/Ron
> smx-jms provider should not create a temporary replyTo destination unless one is needed
> ---------------------------------------------------------------------------------------
>
> Key: SM-1760
> URL: https://issues.apache.org/activemq/browse/SM-1760
> Project: ServiceMix
> Issue Type: Bug
> Components: servicemix-jms
> Affects Versions: servicemix-jms-2008.01
> Reporter: Ron Gavlin
> Assignee: Guillaume Nodet
> Fix For: servicemix-jms-2008.02
>
>
> After the recent patch for SM-1621, the smx-jms provider now always attempts to create a temporary replyTo destination if no replyTo destination is provided. In the case of a "stateless" in-only ME for which no JBI DONE/ERROR reply is expected, this does not seem correct.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SM-1760) smx-jms provider should not create a
temporary replyTo destination unless one is needed
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48617#action_48617 ]
Guillaume Nodet commented on SM-1760:
-------------------------------------
I agree that the endpoint should not create a temporary destination if not needed, though it should be harmless (but from a performance perspective of course).
For SM-1684, and this is related to using jms endpoints for explicit clustering, I'm thinking that we may want to create a new endpoint that should be able to handle clustering in a more specific way (preserving the jbi errors may be one requirement).
> smx-jms provider should not create a temporary replyTo destination unless one is needed
> ---------------------------------------------------------------------------------------
>
> Key: SM-1760
> URL: https://issues.apache.org/activemq/browse/SM-1760
> Project: ServiceMix
> Issue Type: Bug
> Components: servicemix-jms
> Affects Versions: servicemix-jms-2008.01
> Reporter: Ron Gavlin
>
> After the recent patch for SM-1621, the smx-jms provider now always attempts to create a temporary replyTo destination if no replyTo destination is provided. In the case of a "stateless" in-only ME for which no JBI DONE/ERROR reply is expected, this does not seem correct.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (SM-1760) smx-jms provider should not
create a temporary replyTo destination unless one is needed
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48675#action_48675 ]
ffang edited comment on SM-1760 at 1/13/09 9:52 PM:
-----------------------------------------------------------
with this patch applied, the JmsProviderEndpointTest test will always hang at receive response message at
JmsTemplate.doReceive(Session session, MessageConsumer consumer) {
...
message = consumer.receive();
}
The problem comes from that this patch didn't create listenerContainer for temporary replyDest.
To avoid create unnecessary temporary replyDest for InOnly, we can defer the temporary replyDest creation in ProcessInOut, but not the endpoint activate.
was (Author: ffang):
with this patch applied, the JmsProviderEndpointTest test will always hang at receive response message at
JmsTemplate.doReceive(Session session, MessageConsumer consumer) {
...
message = consumer.receive();
}
> smx-jms provider should not create a temporary replyTo destination unless one is needed
> ---------------------------------------------------------------------------------------
>
> Key: SM-1760
> URL: https://issues.apache.org/activemq/browse/SM-1760
> Project: ServiceMix
> Issue Type: Bug
> Components: servicemix-jms
> Affects Versions: servicemix-jms-2008.01
> Reporter: Ron Gavlin
> Assignee: Guillaume Nodet
> Fix For: servicemix-jms-2008.02, 3.3.1
>
>
> After the recent patch for SM-1621, the smx-jms provider now always attempts to create a temporary replyTo destination if no replyTo destination is provided. In the case of a "stateless" in-only ME for which no JBI DONE/ERROR reply is expected, this does not seem correct.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SM-1760) smx-jms provider should not create a
temporary replyTo destination unless one is needed
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet reassigned SM-1760:
-----------------------------------
Assignee: Guillaume Nodet
> smx-jms provider should not create a temporary replyTo destination unless one is needed
> ---------------------------------------------------------------------------------------
>
> Key: SM-1760
> URL: https://issues.apache.org/activemq/browse/SM-1760
> Project: ServiceMix
> Issue Type: Bug
> Components: servicemix-jms
> Affects Versions: servicemix-jms-2008.01
> Reporter: Ron Gavlin
> Assignee: Guillaume Nodet
>
> After the recent patch for SM-1621, the smx-jms provider now always attempts to create a temporary replyTo destination if no replyTo destination is provided. In the case of a "stateless" in-only ME for which no JBI DONE/ERROR reply is expected, this does not seem correct.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (SM-1760) smx-jms provider should not create a
temporary replyTo destination unless one is needed
Posted by "Ron Gavlin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ron Gavlin reopened SM-1760:
----------------------------
Hi Guillaume,
Would it be possible to backport this change to the SMX 3.2.x branch?
Thanks,
/Ron
> smx-jms provider should not create a temporary replyTo destination unless one is needed
> ---------------------------------------------------------------------------------------
>
> Key: SM-1760
> URL: https://issues.apache.org/activemq/browse/SM-1760
> Project: ServiceMix
> Issue Type: Bug
> Components: servicemix-jms
> Affects Versions: servicemix-jms-2008.01
> Reporter: Ron Gavlin
> Assignee: Guillaume Nodet
> Fix For: servicemix-jms-2008.02
>
>
> After the recent patch for SM-1621, the smx-jms provider now always attempts to create a temporary replyTo destination if no replyTo destination is provided. In the case of a "stateless" in-only ME for which no JBI DONE/ERROR reply is expected, this does not seem correct.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SM-1760) smx-jms provider should not create a
temporary replyTo destination unless one is needed
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet resolved SM-1760.
---------------------------------
Resolution: Fixed
Fix Version/s: servicemix-jms-2008.02
> smx-jms provider should not create a temporary replyTo destination unless one is needed
> ---------------------------------------------------------------------------------------
>
> Key: SM-1760
> URL: https://issues.apache.org/activemq/browse/SM-1760
> Project: ServiceMix
> Issue Type: Bug
> Components: servicemix-jms
> Affects Versions: servicemix-jms-2008.01
> Reporter: Ron Gavlin
> Assignee: Guillaume Nodet
> Fix For: servicemix-jms-2008.02
>
>
> After the recent patch for SM-1621, the smx-jms provider now always attempts to create a temporary replyTo destination if no replyTo destination is provided. In the case of a "stateless" in-only ME for which no JBI DONE/ERROR reply is expected, this does not seem correct.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SM-1760) smx-jms provider should not create a
temporary replyTo destination unless one is needed
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Freeman Fang resolved SM-1760.
------------------------------
Resolution: Fixed
> smx-jms provider should not create a temporary replyTo destination unless one is needed
> ---------------------------------------------------------------------------------------
>
> Key: SM-1760
> URL: https://issues.apache.org/activemq/browse/SM-1760
> Project: ServiceMix
> Issue Type: Bug
> Components: servicemix-jms
> Affects Versions: servicemix-jms-2008.01
> Reporter: Ron Gavlin
> Assignee: Guillaume Nodet
> Fix For: servicemix-jms-2008.02, 3.3.1
>
>
> After the recent patch for SM-1621, the smx-jms provider now always attempts to create a temporary replyTo destination if no replyTo destination is provided. In the case of a "stateless" in-only ME for which no JBI DONE/ERROR reply is expected, this does not seem correct.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (SM-1760) smx-jms provider should not create a
temporary replyTo destination unless one is needed
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Freeman Fang reopened SM-1760:
------------------------------
with this patch applied, the JmsProviderEndpointTest test will always hang
> smx-jms provider should not create a temporary replyTo destination unless one is needed
> ---------------------------------------------------------------------------------------
>
> Key: SM-1760
> URL: https://issues.apache.org/activemq/browse/SM-1760
> Project: ServiceMix
> Issue Type: Bug
> Components: servicemix-jms
> Affects Versions: servicemix-jms-2008.01
> Reporter: Ron Gavlin
> Assignee: Guillaume Nodet
> Fix For: servicemix-jms-2008.02, 3.3.1
>
>
> After the recent patch for SM-1621, the smx-jms provider now always attempts to create a temporary replyTo destination if no replyTo destination is provided. In the case of a "stateless" in-only ME for which no JBI DONE/ERROR reply is expected, this does not seem correct.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SM-1760) smx-jms provider should not create a
temporary replyTo destination unless one is needed
Posted by "Ron Gavlin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ron Gavlin updated SM-1760:
---------------------------
Regression: [Regression]
Summary: smx-jms provider should not create a temporary replyTo destination unless one is needed (was: smx-jms provider should defer the creation of a temporary replyTo destination until it receives a ME w/a mep that requires one)
> smx-jms provider should not create a temporary replyTo destination unless one is needed
> ---------------------------------------------------------------------------------------
>
> Key: SM-1760
> URL: https://issues.apache.org/activemq/browse/SM-1760
> Project: ServiceMix
> Issue Type: Bug
> Components: servicemix-jms
> Affects Versions: servicemix-jms-2008.01
> Reporter: Ron Gavlin
>
> After the recent patch for SM-1681, the smx-jms provider now always attempts to create a temporary replyTo destination if no replyTo destination is provided. In the case of a "stateless" in-only ME for which no JBI DONE/ERROR reply is expected, this does not seem correct.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (SM-1760) smx-jms provider should not
create a temporary replyTo destination unless one is needed
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48675#action_48675 ]
ffang edited comment on SM-1760 at 1/13/09 9:04 PM:
-----------------------------------------------------------
with this patch applied, the JmsProviderEndpointTest test will always hang at receive response message at
JmsTemplate.doReceive(Session session, MessageConsumer consumer) {
...
message = consumer.receive();
}
was (Author: ffang):
with this patch applied, the JmsProviderEndpointTest test will always hang
> smx-jms provider should not create a temporary replyTo destination unless one is needed
> ---------------------------------------------------------------------------------------
>
> Key: SM-1760
> URL: https://issues.apache.org/activemq/browse/SM-1760
> Project: ServiceMix
> Issue Type: Bug
> Components: servicemix-jms
> Affects Versions: servicemix-jms-2008.01
> Reporter: Ron Gavlin
> Assignee: Guillaume Nodet
> Fix For: servicemix-jms-2008.02, 3.3.1
>
>
> After the recent patch for SM-1621, the smx-jms provider now always attempts to create a temporary replyTo destination if no replyTo destination is provided. In the case of a "stateless" in-only ME for which no JBI DONE/ERROR reply is expected, this does not seem correct.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SM-1760) smx-jms provider should not create a
temporary replyTo destination unless one is needed
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet resolved SM-1760.
---------------------------------
Resolution: Fixed
Fix Version/s: 3.3.1
Sending servicemix-jms/src/main/java/org/apache/servicemix/jms/endpoints/JmsProviderEndpoint.java
Transmitting file data .
Committed revision 734082.
Sending src/main/java/org/apache/servicemix/jms/endpoints/JmsProviderEndpoint.java
Transmitting file data .
Committed revision 734086.
Backported to 3.2 branch
> smx-jms provider should not create a temporary replyTo destination unless one is needed
> ---------------------------------------------------------------------------------------
>
> Key: SM-1760
> URL: https://issues.apache.org/activemq/browse/SM-1760
> Project: ServiceMix
> Issue Type: Bug
> Components: servicemix-jms
> Affects Versions: servicemix-jms-2008.01
> Reporter: Ron Gavlin
> Assignee: Guillaume Nodet
> Fix For: servicemix-jms-2008.02, 3.3.1
>
>
> After the recent patch for SM-1621, the smx-jms provider now always attempts to create a temporary replyTo destination if no replyTo destination is provided. In the case of a "stateless" in-only ME for which no JBI DONE/ERROR reply is expected, this does not seem correct.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SM-1760) smx-jms provider should defer the
creation of a temporary replyTo destination until it receives a ME w/a mep
that requires one
Posted by "Ron Gavlin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ron Gavlin updated SM-1760:
---------------------------
Description:
After the recent patch for SM-1681, the smx-jms provider now always attempts to create a temporary replyTo destination if no replyTo destination is provided. In the case of a "stateless" in-only ME for which no JBI DONE/ERROR reply is expected, this does not seem correct.
So, should the former "stateless" boolean property which was recently removed from the JmsProviderEndpoint be resurrected such that when stateless=false, the endpoint knows: 1). to create a temporary replyTo queue if none has been provided 2). to wait for a DONE/ERROR JBI reply on the replyTo queue for MEs with an in-only MEP (see SM-1684)?
If this were the case, then if stateless=true, no replyTo destination is specified, and a ME with a non-in-only MEP is received, would this trigger an error condition? What would be the appropriate default for the stateless property?
/Ron
> smx-jms provider should defer the creation of a temporary replyTo destination until it receives a ME w/a mep that requires one
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: SM-1760
> URL: https://issues.apache.org/activemq/browse/SM-1760
> Project: ServiceMix
> Issue Type: Bug
> Components: servicemix-jms
> Affects Versions: servicemix-jms-2008.01
> Reporter: Ron Gavlin
>
> After the recent patch for SM-1681, the smx-jms provider now always attempts to create a temporary replyTo destination if no replyTo destination is provided. In the case of a "stateless" in-only ME for which no JBI DONE/ERROR reply is expected, this does not seem correct.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.