You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/10 11:31:39 UTC

[GitHub] [arrow] jorisvandenbossche commented on a diff in pull request #13102: ARROW-16508: [Archery][Dev] Add possibility to extend chat report message based on success or failures of jobs

jorisvandenbossche commented on code in PR #13102:
URL: https://github.com/apache/arrow/pull/13102#discussion_r869126238


##########
dev/archery/archery/crossbow/reports.py:
##########
@@ -71,6 +71,11 @@ def tasks_by_state(self):
             tasks_by_state[state][task_name] = task
         return tasks_by_state
 
+    @property
+    def contains_failures(self):
+        return any(self.tasks_by_state[state] for state in (
+            "error", "failure", "pending"))

Review Comment:
   I would personally not include "pending" here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org