You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "starocean999 (via GitHub)" <gi...@apache.org> on 2023/06/29 11:41:12 UTC
[GitHub] [doris] starocean999 opened a new pull request, #21346: [fix](nereids)need run ConvertInnerOrCrossJoin rule again after EliminateNotNull
starocean999 opened a new pull request, #21346:
URL: https://github.com/apache/doris/pull/21346
after running EliminateNotNull rule, the join conjuncts may be removed from inner join node. So need run ConvertInnerOrCrossJoin rule to convert inner join with no join conjuncts to cross join node.
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow merged pull request #21346: [fix](nereids)need run ConvertInnerOrCrossJoin rule again after EliminateNotNull
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow merged PR #21346:
URL: https://github.com/apache/doris/pull/21346
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] starocean999 commented on pull request #21346: [fix](nereids)need run ConvertInnerOrCrossJoin rule again after EliminateNotNull
Posted by "starocean999 (via GitHub)" <gi...@apache.org>.
starocean999 commented on PR #21346:
URL: https://github.com/apache/doris/pull/21346#issuecomment-1617242708
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on pull request #21346: [fix](nereids)need run ConvertInnerOrCrossJoin rule again after EliminateNotNull
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on PR #21346:
URL: https://github.com/apache/doris/pull/21346#issuecomment-1614155672
so we have a cross join at begin, convert it to inner join sometime, and need to be ceverted back to cross join at end?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] starocean999 commented on pull request #21346: [fix](nereids)need run ConvertInnerOrCrossJoin rule again after EliminateNotNull
Posted by "starocean999 (via GitHub)" <gi...@apache.org>.
starocean999 commented on PR #21346:
URL: https://github.com/apache/doris/pull/21346#issuecomment-1612979277
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21346: [fix](nereids)need run ConvertInnerOrCrossJoin rule again after EliminateNotNull
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21346:
URL: https://github.com/apache/doris/pull/21346#issuecomment-1618123271
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21346: [fix](nereids)need run ConvertInnerOrCrossJoin rule again after EliminateNotNull
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21346:
URL: https://github.com/apache/doris/pull/21346#issuecomment-1618123173
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] starocean999 commented on pull request #21346: [fix](nereids)need run ConvertInnerOrCrossJoin rule again after EliminateNotNull
Posted by "starocean999 (via GitHub)" <gi...@apache.org>.
starocean999 commented on PR #21346:
URL: https://github.com/apache/doris/pull/21346#issuecomment-1613992139
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org