You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metamodel.apache.org by kaspersorensen <gi...@git.apache.org> on 2018/11/23 19:01:30 UTC
[GitHub] metamodel pull request #195: METAMODEL-1205: Made CassandraUnit based test s...
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/195
METAMODEL-1205: Made CassandraUnit based test skip on JDK 9+
It seems that CassandraUnit simply does not work on JDK 9+, see related
comments in the code. For now I've added a JUnit `Assume` call which
ensures that the test code is skipped when CassandraUnit fails to come
up. Eventually, when they fix CassandraUnit, we should be able to
upgrade the CassandraUnit dependency and it would presumably start
working again.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kaspersorensen/metamodel METAMODEL-1205-cassandra
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metamodel/pull/195.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #195
----
commit 38d6bec0292b54bee899eabd55b11bf7b932725c
Author: Kasper Sørensen <i....@...>
Date: 2018-11-23T19:00:41Z
METAMODEL-1205: Made CassandraUnit based test skip on JDK 9+
It seems that CassandraUnit simply does not work on JDK 9+, see related
comments in the code. For now I've added a JUnit `Assume` call which
ensures that the test code is skipped when CassandraUnit fails to come
up. Eventually, when they fix CassandraUnit, we should be able to
upgrade the CassandraUnit dependency and it would presumably start
working again.
----
---
[GitHub] metamodel issue #195: METAMODEL-1205: Made CassandraUnit based test skip on ...
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/195
I don't think we need additional testing here - the CassandraUnit tests still run on Travis CI (just not in JDK9 builds)
---
[GitHub] metamodel pull request #195: METAMODEL-1205: Made CassandraUnit based test s...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metamodel/pull/195
---
[GitHub] metamodel issue #195: METAMODEL-1205: Made CassandraUnit based test skip on ...
Posted by LosD <gi...@git.apache.org>.
Github user LosD commented on the issue:
https://github.com/apache/metamodel/pull/195
Code LGTM (I could comment on the files with only cosmetic changes, but I wont... -ish :)).
Not sure what I can test. I never used Cassandra, and I don't (currently) have Java 9+ or anything Hadoop. But I `Assume.assumeTrue` that the test skipping has already been tested. ;)
If anything specifically you want me to check (also if it means playing around with Hadoop, Cassandra or Java 9+), let me know.
---
[GitHub] metamodel issue #195: METAMODEL-1205: Made CassandraUnit based test skip on ...
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/195
Note the "Update" in my PR description above. A lot more dependencies have been updated in this MR now to resolve JAR hell conflicts..
---
[GitHub] metamodel issue #195: METAMODEL-1205: Made CassandraUnit based test skip on ...
Posted by LosD <gi...@git.apache.org>.
Github user LosD commented on the issue:
https://github.com/apache/metamodel/pull/195
Some exploding SLF4J bindings.
---
[GitHub] metamodel issue #195: METAMODEL-1205: Made CassandraUnit based test skip on ...
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/195
D'oh! Seems cassandra unit now _requires_ the use of logback classic. That's kinda lame, but I'll switch it out for the test scope at least.
---