Re: [PR] Add support for Utf8View for date/temporal codepaths [datafusion]

["a10y (via GitHub)" <gi...@apache.org>]

a10y commented on code in PR #11518:
URL: https://github.com/apache/datafusion/pull/11518#discussion_r1681274778


##########
datafusion/functions/src/unicode/substr.rs:
##########
@@ -89,6 +100,63 @@ impl ScalarUDFImpl for SubstrFunc {
     }
 }
 
+// TODO(aduffy): just return a manipulated Utf8View array by modifying the view only.
+pub fn substr_view(args: &[ArrayRef]) -> Result<ArrayRef> {
+    match args.len() {

Review Comment:
   I'm going to revert this since it's outside the scope of this PR.
   
   Ideally, we'd be able to defer to the `substring` kernel in arrow_string, but that kernel needs to be fixed to support utf8views



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org