[GitHub] [tvm] quic-sanirudh commented on a diff in pull request #15601: [Unity] Add instruments to relay translator

["quic-sanirudh (via GitHub)" <gi...@apache.org>]

quic-sanirudh commented on code in PR #15601:
URL: https://github.com/apache/tvm/pull/15601#discussion_r1306676855


##########
python/tvm/relax/testing/relay_translator.py:
##########
@@ -255,6 +261,7 @@ def visit_func(node):
         opt_level=opt_level,
         config=pass_config,
         disabled_pass=disabled_pass,
+        instruments=instruments,

Review Comment:
   Thanks for your review @Lunderberg.
   
   I actually did it that way initially, but since the other arguments to `PassContext` such as `opt_level` and `pass_config` were taken as arguments to the relay translator, I modified it take instruments as an argument as well.
   
   I can change it back to be forwarded from current PassContext as you've suggested, either way is fine with me, but in that case, should we also remove `opt_level` and `pass_config` from being arguments and forward them from current context as well? Since that would be a breaking change, I'm a bit hesitant to do that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org