You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2018/04/03 03:43:00 UTC

[GitHub] wu-sheng opened a new pull request #1017: Because of key issue, system env override can't be supported.

wu-sheng opened a new pull request #1017: Because of key issue, system env override can't be supported.
URL: https://github.com/apache/incubator-skywalking/pull/1017
 
 
   Right now, in current implementation, we use `.` to separate the setting level, which is illegal in system env.
   
   At the same time, several setting keys in agent.config and application.yml include `_`, make the levels can't be separated by `_`, by following system env traditions.
   
   So, I have to revert the support, Now, only override by system properties is supported. Sadly.
   
   @peng-yongsheng Maybe, later, we can discuss about changing the setting keys.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services