You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2014/05/14 23:32:53 UTC
svn commit: r1594730 - in /tomcat/trunk:
java/org/apache/catalina/authenticator/SpnegoAuthenticator.java
webapps/docs/changelog.xml
Author: markt
Date: Wed May 14 21:32:52 2014
New Revision: 1594730
URL: http://svn.apache.org/r1594730
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56523
When using SPNEGO authentication, log the exceptions associated with failed user logins at debug level rather than error level.
Modified:
tomcat/trunk/java/org/apache/catalina/authenticator/SpnegoAuthenticator.java
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/java/org/apache/catalina/authenticator/SpnegoAuthenticator.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/authenticator/SpnegoAuthenticator.java?rev=1594730&r1=1594729&r2=1594730&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/authenticator/SpnegoAuthenticator.java (original)
+++ tomcat/trunk/java/org/apache/catalina/authenticator/SpnegoAuthenticator.java Wed May 14 21:32:52 2014
@@ -258,7 +258,14 @@ public class SpnegoAuthenticator extends
response.sendError(HttpServletResponse.SC_UNAUTHORIZED);
return false;
} catch (PrivilegedActionException e) {
- log.error(sm.getString("spnegoAuthenticator.serviceLoginFail"), e);
+ Throwable cause = e.getCause();
+ if (cause instanceof GSSException) {
+ if (log.isDebugEnabled()) {
+ log.debug(sm.getString("spnegoAuthenticator.serviceLoginFail"), e);
+ }
+ } else {
+ log.error(sm.getString("spnegoAuthenticator.serviceLoginFail"), e);
+ }
response.setHeader("WWW-Authenticate", "Negotiate");
response.sendError(HttpServletResponse.SC_UNAUTHORIZED);
return false;
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1594730&r1=1594729&r2=1594730&view=diff
==============================================================================
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Wed May 14 21:32:52 2014
@@ -45,6 +45,15 @@
issues to not "pop up" wrt. others).
-->
<section name="Tomcat 8.0.7 (markt)">
+ <subsection name="Catalina">
+ <changelog>
+ <fix>
+ <bug>56523</bug>: When using SPNEGO authentication, log the exceptions
+ associated with failed user logins at debug level rather than error
+ level. (markt)
+ </fix>
+ </changelog>
+ </subsection>
<subsection name="Jasper">
<changelog>
<fix>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org