You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Pallav Kulshreshtha <pa...@gmail.com> on 2017/02/27 19:29:22 UTC

Review Request 57100: Select operators should not appear before fetch

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57100/
-----------------------------------------------------------

Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.


Bugs: AMBARI-20215
    https://issues.apache.org/jira/browse/AMBARI-20215


Repository: ambari


Description
-------

modified logic to show select node.


Diffs
-----

  contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/processor.js a252498 
  contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 196a514 
  contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js 01d6000 

Diff: https://reviews.apache.org/r/57100/diff/


Testing
-------

manually tested.


Thanks,

Pallav Kulshreshtha


Re: Review Request 57100: Select operators should not appear before fetch

Posted by venkat sairam <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57100/#review167043
-----------------------------------------------------------


Ship it!




Ship It!

- venkat sairam


On Feb. 27, 2017, 7:29 p.m., Pallav Kulshreshtha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57100/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2017, 7:29 p.m.)
> 
> 
> Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
> 
> 
> Bugs: AMBARI-20215
>     https://issues.apache.org/jira/browse/AMBARI-20215
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> modified logic to show select node.
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/processor.js a252498 
>   contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 196a514 
>   contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js 01d6000 
> 
> Diff: https://reviews.apache.org/r/57100/diff/
> 
> 
> Testing
> -------
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>


Re: Review Request 57100: Select operators should not appear before fetch

Posted by Abhishek Kumar <la...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57100/#review167032
-----------------------------------------------------------


Ship it!




Ship It!

- Abhishek Kumar


On Feb. 27, 2017, 7:29 p.m., Pallav Kulshreshtha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57100/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2017, 7:29 p.m.)
> 
> 
> Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
> 
> 
> Bugs: AMBARI-20215
>     https://issues.apache.org/jira/browse/AMBARI-20215
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> modified logic to show select node.
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/processor.js a252498 
>   contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 196a514 
>   contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js 01d6000 
> 
> Diff: https://reviews.apache.org/r/57100/diff/
> 
> 
> Testing
> -------
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>


Re: Review Request 57100: Select operators should not appear before fetch

Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57100/#review167004
-----------------------------------------------------------


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 27, 2017, 7:29 p.m., Pallav Kulshreshtha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57100/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2017, 7:29 p.m.)
> 
> 
> Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
> 
> 
> Bugs: AMBARI-20215
>     https://issues.apache.org/jira/browse/AMBARI-20215
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> modified logic to show select node.
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/processor.js a252498 
>   contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 196a514 
>   contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js 01d6000 
> 
> Diff: https://reviews.apache.org/r/57100/diff/
> 
> 
> Testing
> -------
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>


Re: Review Request 57100: Select operators should not appear before fetch

Posted by Abhishek Kumar <la...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57100/#review167658
-----------------------------------------------------------


Ship it!




Ship It!

- Abhishek Kumar


On Feb. 27, 2017, 7:29 p.m., Pallav Kulshreshtha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57100/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2017, 7:29 p.m.)
> 
> 
> Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
> 
> 
> Bugs: AMBARI-20215
>     https://issues.apache.org/jira/browse/AMBARI-20215
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> modified logic to show select node.
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/processor.js a252498 
>   contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 196a514 
>   contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js 01d6000 
> 
> 
> Diff: https://reviews.apache.org/r/57100/diff/1/
> 
> 
> Testing
> -------
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>