You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Gautam Borad <gb...@gmail.com> on 2016/02/26 13:43:29 UTC
Review Request 44060: AMBARI-15199 : Handle log dir dependency for
Ranger KMS installation
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44060/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: AMBARI-15199
https://issues.apache.org/jira/browse/AMBARI-15199
Repository: ambari
Description
-------
**PROBLEM:**
Ranger KMS installation fails if log dir for Ranger KMS is not present.
**PROPOSED SOLUTION:**
Current implementation provides the permissions to the log dir, but it doesn't create the log dir if log dir is not present.
Need to create the log directory if it does not exist.
Diffs
-----
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py fcceaa6
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 7c7a7c8
Diff: https://reviews.apache.org/r/44060/diff/
Testing
-------
1) Tested Ranger KMS install by setting a non-existing log directory and verified that log directory is getting created and logs are getting saved in that directory.
2) Verified Ranger KMS install by setting a existing directory as a log directory and verified logs are getting saved in that directory.
Thanks,
Gautam Borad
Re: Review Request 44060: AMBARI-15199 : Handle log dir dependency for
Ranger KMS installation
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44060/#review121678
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Feb. 26, 2016, 7:43 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44060/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2016, 7:43 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-15199
> https://issues.apache.org/jira/browse/AMBARI-15199
>
>
> Repository: ambari
>
>
> Description
> -------
>
> **PROBLEM:**
> Ranger KMS installation fails if log dir for Ranger KMS is not present.
>
> **PROPOSED SOLUTION:**
> Current implementation provides the permissions to the log dir, but it doesn't create the log dir if log dir is not present.
> Need to create the log directory if it does not exist.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py fcceaa6
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 7c7a7c8
>
> Diff: https://reviews.apache.org/r/44060/diff/
>
>
> Testing
> -------
>
> 1) Tested Ranger KMS install by setting a non-existing log directory and verified that log directory is getting created and logs are getting saved in that directory.
>
> 2) Verified Ranger KMS install by setting a existing directory as a log directory and verified logs are getting saved in that directory.
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 44060: AMBARI-15199 : Handle log dir dependency for
Ranger KMS installation
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44060/#review125869
-----------------------------------------------------------
Was this committed? If so, can we close the review?
- Jonathan Hurley
On Feb. 26, 2016, 7:43 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44060/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2016, 7:43 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-15199
> https://issues.apache.org/jira/browse/AMBARI-15199
>
>
> Repository: ambari
>
>
> Description
> -------
>
> **PROBLEM:**
> Ranger KMS installation fails if log dir for Ranger KMS is not present.
>
> **PROPOSED SOLUTION:**
> Current implementation provides the permissions to the log dir, but it doesn't create the log dir if log dir is not present.
> Need to create the log directory if it does not exist.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py fcceaa6
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 7c7a7c8
>
> Diff: https://reviews.apache.org/r/44060/diff/
>
>
> Testing
> -------
>
> 1) Tested Ranger KMS install by setting a non-existing log directory and verified that log directory is getting created and logs are getting saved in that directory.
>
> 2) Verified Ranger KMS install by setting a existing directory as a log directory and verified logs are getting saved in that directory.
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 44060: AMBARI-15199 : Handle log dir dependency for
Ranger KMS installation
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On Feb. 29, 2016, 3:15 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py, lines 103-105
> > <https://reviews.apache.org/r/44060/diff/1/?file=1271897#file1271897line103>
> >
> > Could this be a security issue on systems where they only want specific users to access config directories? Granting a+rx?
>
> Gautam Borad wrote:
> This is for log directories only. Other components like hbase, knox, hive are having similar implementation. To be on safer side shall we keep 0754 ?
OK, as long as other impls have similar permissions.
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44060/#review121311
-----------------------------------------------------------
On Feb. 26, 2016, 7:43 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44060/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2016, 7:43 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-15199
> https://issues.apache.org/jira/browse/AMBARI-15199
>
>
> Repository: ambari
>
>
> Description
> -------
>
> **PROBLEM:**
> Ranger KMS installation fails if log dir for Ranger KMS is not present.
>
> **PROPOSED SOLUTION:**
> Current implementation provides the permissions to the log dir, but it doesn't create the log dir if log dir is not present.
> Need to create the log directory if it does not exist.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py fcceaa6
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 7c7a7c8
>
> Diff: https://reviews.apache.org/r/44060/diff/
>
>
> Testing
> -------
>
> 1) Tested Ranger KMS install by setting a non-existing log directory and verified that log directory is getting created and logs are getting saved in that directory.
>
> 2) Verified Ranger KMS install by setting a existing directory as a log directory and verified logs are getting saved in that directory.
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 44060: AMBARI-15199 : Handle log dir dependency for
Ranger KMS installation
Posted by Gautam Borad <gb...@gmail.com>.
> On Feb. 29, 2016, 8:15 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py, lines 103-105
> > <https://reviews.apache.org/r/44060/diff/1/?file=1271897#file1271897line103>
> >
> > Could this be a security issue on systems where they only want specific users to access config directories? Granting a+rx?
This is for log directories only. Other components like hbase, knox, hive are having similar implementation. To be on safer side shall we keep 0754 ?
- Gautam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44060/#review121311
-----------------------------------------------------------
On Feb. 26, 2016, 12:43 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44060/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2016, 12:43 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-15199
> https://issues.apache.org/jira/browse/AMBARI-15199
>
>
> Repository: ambari
>
>
> Description
> -------
>
> **PROBLEM:**
> Ranger KMS installation fails if log dir for Ranger KMS is not present.
>
> **PROPOSED SOLUTION:**
> Current implementation provides the permissions to the log dir, but it doesn't create the log dir if log dir is not present.
> Need to create the log directory if it does not exist.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py fcceaa6
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 7c7a7c8
>
> Diff: https://reviews.apache.org/r/44060/diff/
>
>
> Testing
> -------
>
> 1) Tested Ranger KMS install by setting a non-existing log directory and verified that log directory is getting created and logs are getting saved in that directory.
>
> 2) Verified Ranger KMS install by setting a existing directory as a log directory and verified logs are getting saved in that directory.
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 44060: AMBARI-15199 : Handle log dir dependency for
Ranger KMS installation
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44060/#review121311
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py (lines 103 - 105)
<https://reviews.apache.org/r/44060/#comment182995>
Could this be a security issue on systems where they only want specific users to access config directories? Granting a+rx?
- Jonathan Hurley
On Feb. 26, 2016, 7:43 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44060/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2016, 7:43 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-15199
> https://issues.apache.org/jira/browse/AMBARI-15199
>
>
> Repository: ambari
>
>
> Description
> -------
>
> **PROBLEM:**
> Ranger KMS installation fails if log dir for Ranger KMS is not present.
>
> **PROPOSED SOLUTION:**
> Current implementation provides the permissions to the log dir, but it doesn't create the log dir if log dir is not present.
> Need to create the log directory if it does not exist.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py fcceaa6
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 7c7a7c8
>
> Diff: https://reviews.apache.org/r/44060/diff/
>
>
> Testing
> -------
>
> 1) Tested Ranger KMS install by setting a non-existing log directory and verified that log directory is getting created and logs are getting saved in that directory.
>
> 2) Verified Ranger KMS install by setting a existing directory as a log directory and verified logs are getting saved in that directory.
>
>
> Thanks,
>
> Gautam Borad
>
>