[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5569: HDFS-16697.Add code to check the minimumRedundantVolumes value and add related log warning messages.

["ayushtkn (via GitHub)" <gi...@apache.org>]

ayushtkn commented on code in PR #5569:
URL: https://github.com/apache/hadoop/pull/5569#discussion_r1197581496


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeResourcePolicy.java:
##########
@@ -73,6 +79,11 @@ static boolean areResourcesAvailable(
       // required resources available.
       return requiredResourceCount > 0;
     } else {
+      if (minimumRedundantResources > resources.size()){
+        LOG.warn("The value of " + DFSConfigKeys.DFS_NAMENODE_CHECKED_VOLUMES_MINIMUM_KEY

Review Comment:
   this is normal api call and false is genuine response. add a info log not warn. And just log resource not available, and put the values of all three variables. 
   
   that is the most we can do, rest the admin need to be smart enough to decode what value is messed up and what damage it can cause



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org